Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]refactor r/aws_lb resource to use keyvaluetags + read after create + enums #11020

Closed
wants to merge 7 commits into from
Closed

[WIP]refactor r/aws_lb resource to use keyvaluetags + read after create + enums #11020

wants to merge 7 commits into from

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Nov 26, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLB_'

...

@DrFaust92
use enum + validation for load_balancer_type
e5ac630 
use enum + validation for `ip_address_type`
refactor to use keyvaluetags
refactor to read after create
@DrFaust92
refactor access logs func
16bd10b 
refactor tests
@DrFaust92 DrFaust92 requested a review from a team November 26, 2019 11:42
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 26, 2019
@DrFaust92 DrFaust92 changed the title [WIP]refactor r/aws_lb resource to use keyvaluetags + read after create [WIP]refactor r/aws_lb resource to use keyvaluetags + read after create + enums Nov 26, 2019
@DrFaust92
Copy link
Collaborator Author

closing this in favor of #11419
will handle read after create in a different PR

@DrFaust92 DrFaust92 closed this Dec 24, 2019
@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
@DrFaust92 DrFaust92 deleted the elbv2-logs branch December 27, 2021 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @breathingdust