Add Resource & Data Source aws_ec2_transit_gateway_peering_attachment #11162

Omarimcblack · 2019-12-05T20:08:12Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Related to #11117

Release note for CHANGELOG:

New Data Source: aws_ec2_transit_gateway_peering_attachment (#11162)
New Resource: aws_ec2_transit_gateway_peering_attachment (#11162)

Output from acceptance

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEc2TransitGatewayPeeringAttachment_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSEc2TransitGatewayPeeringAttachment_ -timeout 120m
=== RUN   TestAccAWSEc2TransitGatewayPeeringAttachment_basic
=== PAUSE TestAccAWSEc2TransitGatewayPeeringAttachment_basic
=== RUN   TestAccAWSEc2TransitGatewayPeeringAttachment_disappears
=== PAUSE TestAccAWSEc2TransitGatewayPeeringAttachment_disappears
=== RUN   TestAccAWSEc2TransitGatewayPeeringAttachment_Tags_sameAccount
=== PAUSE TestAccAWSEc2TransitGatewayPeeringAttachment_Tags_sameAccount
=== RUN   TestAccAWSEc2TransitGatewayPeeringAttachment_differentAccount
=== PAUSE TestAccAWSEc2TransitGatewayPeeringAttachment_differentAccount
=== CONT  TestAccAWSEc2TransitGatewayPeeringAttachment_basic
=== CONT  TestAccAWSEc2TransitGatewayPeeringAttachment_differentAccount
=== CONT  TestAccAWSEc2TransitGatewayPeeringAttachment_Tags_sameAccount
=== CONT  TestAccAWSEc2TransitGatewayPeeringAttachment_disappears
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_disappears (295.35s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_basic (396.29s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_differentAccount (430.52s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_Tags_sameAccount (453.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	453.725s


$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource -timeout 120m
=== RUN   TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter
=== PAUSE TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter
=== RUN   TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID
=== PAUSE TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID
=== RUN   TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Tags
=== PAUSE TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Tags
=== CONT  TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter
=== CONT  TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Tags
=== CONT  TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter (422.58s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID (425.54s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Tags (427.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	428.898s

Create and read functions implemented to interact with the AWS GO SDK for transit gateway peering attachments. waitFor functions added for Create/Read terraform operations. Describe function added for transit gateway peering attachments.

Create Update/Delete/refresh functions implemented to interact with the AWS GO SDK for transit gateway peering attachments waitFor functions added for Update/Delete terraform operations. Add provider resource mapping to provider.go

Work for transit_gateway_peering_attachment_accepter has now been moved into its own pr hashicorp#11185.

Create and read functions implemented to interact with the AWS GO SDK for transit gateway peering attachments. waitFor functions added for Create/Read terraform operations. Describe function added for transit gateway peering attachments.

Create Update/Delete/refresh functions implemented to interact with the AWS GO SDK for transit gateway peering attachments waitFor functions added for Update/Delete terraform operations. Add provider resource mapping to provider.go

Work for transit_gateway_peering_attachment_accepter has now been moved into its own pr hashicorp#11185.

as per hashicorp#10688

ewbankkit · 2019-12-17T21:58:24Z

@Omarimcblack @j-nix Let me know if you need any help with testing this or #11185.

Omarimcblack · 2019-12-20T16:31:48Z

Hi @ewbankkit we have been making use of the resources for our own deployments, we have some test locally - will push up sometime Monday and if you could take a look over that would be great!

Co-authored-by: j-nix <[email protected]>

bflad

Hi @Omarimcblack 👋 Thank you so much for this contribution. Overall this is looking great. A few little things and we should be able to get this in quickly. Please reach out with any questions or if you do not have time to implement the items. 👍

aws/data_source_aws_ec2_transit_gateway_peering_attachment.go

aws/ec2_transit_gateway.go

aws/resource_aws_ec2_transit_gateway_peering_attachment_test.go

website/docs/d/ec2_transit_gateway_peering_attachment.html.markdown

website/docs/r/ec2_transit_gateway_peering_attachment.html.markdown

aws/resource_aws_ec2_transit_gateway_peering_attachment_test.go

Local/peer terminology implemented based off the current account Co-Authored-By: Brian Flad <[email protected]>

use `owner_id` attr rather than data source for caller identity Co-Authored-By: Brian Flad <[email protected]>

Docs amended to provide different example & fix links Co-Authored-By: Brian Flad <[email protected]>

bflad · 2020-04-23T19:48:28Z

Hi @Omarimcblack / @j-nix 👋 Just checking in -- do you have plans to fix up the final review items and CI failure? Please let us know. Thanks!

…paginator function Co-authored-by: Omarimcblack <[email protected]>

…ther than enum Co-authored-by: Omarimcblack <[email protected]>

alternate provider Since local/peer terminology has been adopted it is important to test that the correct attributes are returned from a datasource when the alternate(accepter) provider is used Co-authored-by: j-nix <[email protected]>

jtcressy · 2020-04-29T23:12:16Z

@bflad is aws/aws-sdk-go#3284 a requirement for this MR or is this in queue for next review? I see the milestone v2.60.0 was added so it sounds like it's on track?

bflad · 2020-04-30T16:43:23Z

@jtcressy this should go out today; just need to track down why cross-account testing is failing.

bflad

All set, thanks @Omarimcblack! 🚀 Will handle a small testing fix post-merge.

Output from acceptance testing:

--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_basic (279.30s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_differentAccount (274.76s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_disappears (298.80s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_Tags_sameAccount (341.73s)

--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_differentAccount (290.68s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_sameAccount (281.60s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_differentAccount (291.70s)
--- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_sameAccount (308.69s)

ghost · 2020-05-01T01:18:39Z

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

…ng_attachment (hashicorp#11162) Output from acceptance testing: ``` --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_basic (279.30s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_differentAccount (274.76s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_disappears (298.80s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_Tags_sameAccount (341.73s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_differentAccount (290.68s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_sameAccount (281.60s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_differentAccount (291.70s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_sameAccount (308.69s) ```

… aws_ec2_transit_gateway_peering_attachment (hashicorp#11162) Output from acceptance testing: ``` --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_basic (279.30s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_differentAccount (274.76s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_disappears (298.80s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachment_Tags_sameAccount (341.73s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_differentAccount (290.68s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_Filter_sameAccount (281.60s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_differentAccount (291.70s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentDataSource_ID_sameAccount (308.69s) ```

ghost · 2020-05-31T17:10:31Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

Joe Horner and others added 2 commits December 5, 2019 19:20

Resource aws_ec2_transit_gateway_peering_attachment

6b2b24a

Create Update/Delete/refresh functions implemented to interact with the AWS GO SDK for transit gateway peering attachments waitFor functions added for Update/Delete terraform operations. Add provider resource mapping to provider.go

Omarimcblack requested a review from a team December 5, 2019 20:08

Remove references to tgw peering attachment acceptance

54b21e5

Work for transit_gateway_peering_attachment_accepter has now been moved into its own pr hashicorp#11185.

ghost added size/L Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. size/L Managed by automation to categorize the size of a PR. labels Dec 6, 2019

j-nix force-pushed the add_transit_gw_peering branch from 2e5426f to 54b21e5 Compare December 7, 2019 00:20

ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Dec 7, 2019

Joe Horner and others added 4 commits December 7, 2019 11:49

Resource aws_ec2_transit_gateway_peering_attachment

f8552d3

Create Update/Delete/refresh functions implemented to interact with the AWS GO SDK for transit gateway peering attachments waitFor functions added for Update/Delete terraform operations. Add provider resource mapping to provider.go

Remove references to tgw peering attachment acceptance

a37f145

Work for transit_gateway_peering_attachment_accepter has now been moved into its own pr hashicorp#11185.

Refactor tagging logic to keyvaluetags package

5094ff5

as per hashicorp#10688

Omarimcblack changed the base branch from master to transport-logging December 7, 2019 15:06

Omarimcblack changed the base branch from transport-logging to master December 7, 2019 15:06

Omarimcblack and others added 2 commits December 23, 2019 15:37

Add tgw-peer-attachment docs

348da35

Co-authored-by: j-nix <[email protected]>

Merge branch 'add_transit_gw_peering' into add_transit_gw_peering_docs

e4eb279

bflad added new-resource Introduces a new resource. new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. service/mediaconvert Issues and PRs that pertain to the mediaconvert service. labels Apr 16, 2020

bflad self-assigned this Apr 17, 2020

bflad suggested changes Apr 17, 2020

View reviewed changes

bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Apr 17, 2020

j-nix and others added 3 commits April 20, 2020 10:09

aws_ec2_transit_gateway_peering_attachment: local/peer terminology

1a2af88

Local/peer terminology implemented based off the current account Co-Authored-By: Brian Flad <[email protected]>

aws_ec2_transit_gateway_peering_attachment: simplify test logic

1c32337

use `owner_id` attr rather than data source for caller identity Co-Authored-By: Brian Flad <[email protected]>

aws_ec2_transit_gateway_peering_attachment: amend docs

3321080

Docs amended to provide different example & fix links Co-Authored-By: Brian Flad <[email protected]>

Joe Horner and others added 3 commits April 24, 2020 23:36

aws_ec2_transit_gateway_peering_attachment: Change test sweep to use …

04b8a62

…paginator function Co-authored-by: Omarimcblack <[email protected]>

aws_ec2_transit_gateway_peering_attachment: Add comment for string ra…

b2e4d5d

…ther than enum Co-authored-by: Omarimcblack <[email protected]>

Omarimcblack requested a review from bflad April 24, 2020 23:05

j-nix mentioned this pull request Apr 27, 2020

Missing enum value "initiatingRequest" for transit gateway peering attachment aws/aws-sdk-go#3284

Closed

3 tasks

bflad added this to the v2.60.0 milestone Apr 28, 2020

ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Apr 29, 2020

bflad approved these changes Apr 30, 2020

View reviewed changes

bflad merged commit 70279b8 into hashicorp:master Apr 30, 2020

bflad added a commit that referenced this pull request Apr 30, 2020

Update CHANGELOG for #11162

8ba95a0

Omarimcblack deleted the add_transit_gw_peering branch April 30, 2020 18:53

ghost locked and limited conversation to collaborators May 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Resource & Data Source aws_ec2_transit_gateway_peering_attachment #11162

Add Resource & Data Source aws_ec2_transit_gateway_peering_attachment #11162

Omarimcblack commented Dec 5, 2019 •

edited

Loading

ewbankkit commented Dec 17, 2019

Omarimcblack commented Dec 20, 2019

bflad left a comment

bflad commented Apr 23, 2020

jtcressy commented Apr 29, 2020

bflad commented Apr 30, 2020

bflad left a comment

ghost commented May 1, 2020

ghost commented May 31, 2020

Add Resource & Data Source aws_ec2_transit_gateway_peering_attachment #11162

Add Resource & Data Source aws_ec2_transit_gateway_peering_attachment #11162

Conversation

Omarimcblack commented Dec 5, 2019 • edited Loading

Community Note

ewbankkit commented Dec 17, 2019

Omarimcblack commented Dec 20, 2019

bflad left a comment

Choose a reason for hiding this comment

bflad commented Apr 23, 2020

jtcressy commented Apr 29, 2020

bflad commented Apr 30, 2020

bflad left a comment

Choose a reason for hiding this comment

ghost commented May 1, 2020

ghost commented May 31, 2020

Omarimcblack commented Dec 5, 2019 •

edited

Loading