[WIP] r/aws_opsworks_stack: Use correct region for ARN when updating tags #11849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
needs-triage
ewbankkit
commented
Feb 1, 2020
| @@ -359,6 +361,43 @@ func testAccOrganizationsAccountPreCheck(t *testing.T) { | |||
| t.Skip("skipping tests; this AWS account must not be an existing member of an AWS Organization") | |||
| } | |||
|
|
|||
| // testAccPreCheckHasDefaultVpc checks that the test region has a default VPC. | |||
| func testAccPreCheckHasDefaultVpc(t *testing.T) { | |||
There was a problem hiding this comment.
Copied from #11126.
TODOWork out how to do hard-coded |
ewbankkit
commented
Feb 1, 2020
| @@ -401,8 +400,6 @@ func opsworksConnForRegion(region string, meta interface{}) (*opsworks.OpsWorks, | |||
| return nil, fmt.Errorf("Error creating AWS session: %s", err) | |||
| } | |||
|
|
|||
| sess.Handlers.Build.PushBack(request.MakeAddToUserAgentHandler("APN/1.0 HashiCorp/1.0 Terraform", meta.(*AWSClient).terraformVersion)) | |||
There was a problem hiding this comment.
User agent configuration is in originalConn.Config.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
breathingdust
removed
the
needs-triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #6381.
Release note for CHANGELOG:
Output from acceptance testing:
TODO