Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sfn_state_machine - iam role eventual consistency + wait for delete + add arn attribute #12005

Merged
merged 10 commits into from
Jul 1, 2020
Merged

r/sfn_state_machine - iam role eventual consistency + wait for delete + add arn attribute #12005

merged 10 commits into from
Jul 1, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Feb 12, 2020 •
edited by anGie44
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #7893
Relates #13624

Release note for CHANGELOG:

resource_aws_sfn_state_machine: add `arn` attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSfnStateMachine_'
--- FAIL: TestAccAWSSfnStateMachine_createUpdate (114.32s)
    testing.go:640: Step 2 error: Check failed: Check 6/7 error: aws_sfn_state_machine.test: Attribute 'definition' didn't match ".*\\\"MaxAttempts\\\": 10.*", got "{\n  \"Comment\": \"A Hello World example of the Amazon States Language using an AWS Lambda Function\",\n  \"StartAt\": \"HelloWorld\",\n  \"States\": {\n    \"HelloWorld\": {\n      \"Type\": \"Task\",\n      \"Resource\": \"arn:aws:lambda:us-west-2:476956259333:function:tf-acc-4347576902814911718\",\n      \"Retry\": [\n        {\n          \"ErrorEquals\": [\"States.ALL\"],\n          \"IntervalSeconds\": 5,\n          \"MaxAttempts\": 5,\n          \"BackoffRate\": 8.0\n        }\n      ],\n      \"End\": true\n    }\n  }\n}\n"


--- PASS: TestAccAWSSfnStateMachine_Tags (147.65s)
--- PASS: TestAccAWSSfnStateMachine_disappears (4732.81s)

tests failing due to another eventual consistency issue.

@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. service/sfn Issues and PRs that pertain to the sfn service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Feb 12, 2020
@DrFaust92 DrFaust92 marked this pull request as ready for review February 13, 2020 09:36
@DrFaust92 DrFaust92 requested a review from a team February 13, 2020 09:36
@DrFaust92 DrFaust92 force-pushed the r/sfn-eventual-cinsistency branch from 2bb72f5 to 79cf35d Compare May 8, 2020 07:47
@DrFaust92 DrFaust92 changed the title r/sfn_state_machine - iam role eventual consistency + add arn attribute r/sfn_state_machine - iam role eventual consistency + wait for delete + add arn attribute May 8, 2020
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels May 22, 2020
@DrFaust92 DrFaust92 force-pushed the r/sfn-eventual-cinsistency branch from d326786 to 9aed2c0 Compare June 17, 2020 19:48
@bflad bflad linked an issue Jul 1, 2020 that may be closed by this pull request
IAM Role with policies created but not available for dependent resources #14008
Closed
@bflad bflad self-assigned this Jul 1, 2020
@bflad bflad added this to the v2.69.0 milestone Jul 1, 2020
bflad
bflad suggested changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few little things then I believe this is good to go, thanks @DrFaust92

aws/internal/service/sfn/waiter/status.go Show resolved Hide resolved
aws/resource_aws_sfn_state_machine.go Show resolved Hide resolved
aws/resource_aws_sfn_state_machine_test.go Outdated Show resolved Hide resolved
aws/resource_aws_sfn_state_machine_test.go Show resolved Hide resolved
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 1, 2020
@ghost ghost added service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/fsx Issues and PRs that pertain to the fsx service. service/iam Issues and PRs that pertain to the iam service. service/rds Issues and PRs that pertain to the rds service. service/route53 Issues and PRs that pertain to the route53 service. labels Jul 1, 2020
@DrFaust92 DrFaust92 force-pushed the r/sfn-eventual-cinsistency branch from c9393b8 to e631c9f Compare July 1, 2020 14:47
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Jul 1, 2020
@DrFaust92 DrFaust92 removed service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/fsx Issues and PRs that pertain to the fsx service. service/iam Issues and PRs that pertain to the iam service. service/rds Issues and PRs that pertain to the rds service. service/route53 Issues and PRs that pertain to the route53 service. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jul 1, 2020
@DrFaust92 DrFaust92 requested a review from bflad July 1, 2020 17:32
bflad
bflad approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing (unrelated consistent test failure due to #12506):

--- PASS: TestAccAWSSfnStateMachine_tags (55.38s)
--- FAIL: TestAccAWSSfnStateMachine_createUpdate (61.93s)
--- PASS: TestAccAWSSfnStateMachine_disappears (67.31s)

@bflad bflad merged commit efef33b into hashicorp:master Jul 1, 2020
bflad added a commit that referenced this pull request Jul 1, 2020
@bflad
Update CHANGELOG for #12005
de7897c
@ghost
Copy link

ghost commented Jul 3, 2020

This has been released in version 2.69.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 2, 2020
@DrFaust92 DrFaust92 deleted the r/sfn-eventual-cinsistency branch August 27, 2020 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. service/sfn Issues and PRs that pertain to the sfn service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.69.0
2 participants
@DrFaust92 @bflad