New data source: aws_wafv2_regex_pattern_set

[pvanbuijtene]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11179
Relates #11046
Depends on #12284 because of duplicated code for tests.

Release note for CHANGELOG:

**New Data Source:** `aws_wafv2_regex_pattern_set` (#12789)

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsWafv2Regex'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWafv2Regex -timeout 120m
=== RUN   TestAccDataSourceAwsWafv2RegexPatternSet_Basic
=== PAUSE TestAccDataSourceAwsWafv2RegexPatternSet_Basic
=== CONT  TestAccDataSourceAwsWafv2RegexPatternSet_Basic
--- PASS: TestAccDataSourceAwsWafv2RegexPatternSet_Basic (21.41s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       21.777s

[anGie44]

hi @pvanbuijtene, do you mind rebasing to isolate the data_source related changes?

[anGie44]

hi @pvanbuijtene, thanks again for your contributions! please find some follow-up suggestions and comments for your consideration. also if you could omit the resource and references to it in provider.go it would be greatly appreciated :)

[anGie44]

along the lines of using the AWS SDK's conversion functions, i think ideally we'd want to use aws.StringValue(foundIRegexPatternSet.Id) though this results in 2 conversions..this may be a case where passing the original pointer is permissible @bflad?

[pvanbuijtene]

@anGie44 the code has been updated and the resource code is removed, be aware this will break the build and test.

[anGie44]

thanks @pvanbuijtene! changes look great. just noted these 2 documentation changes

[anGie44]

Thanks so much for the changes @pvanbuijtene!

Note: acceptance test run and linting contingent on merge of #12284

[bflad]

FYI, there is a CI failure:

# github.com/terraform-providers/terraform-provider-aws/aws
aws/data_source_aws_wafv2_regex_pattern_set.go:108:40: undefined: flattenWafv2RegexPatternSet

[anGie44]

hi @pvanbuijtene, one last rebase and aws.erb update request for you now that master is up-to-date with the corresponding resource 🙏

[anGie44]

awesome, thanks @pvanbuijtene! 🚀

[ghost]

This has been released in version 2.63.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!