Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New data source: aws_wafv2_web_acl #12791

Merged
merged 1 commit into from
Jun 16, 2020
Merged

New data source: aws_wafv2_web_acl #12791

merged 1 commit into from
Jun 16, 2020

Conversation

pvanbuijtene
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11181
Relates #11046
Depends on #12688 because of duplicated code for tests.

Release note for CHANGELOG:

**New Data Source:** `aws_wafv2_web_acl` ()

Output from acceptance testing:

make build; make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsWafv2WebACL'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWafv2WebACL -timeout 120m
=== RUN   TestAccDataSourceAwsWafv2WebACL_Basic
=== PAUSE TestAccDataSourceAwsWafv2WebACL_Basic
=== CONT  TestAccDataSourceAwsWafv2WebACL_Basic
--- PASS: TestAccDataSourceAwsWafv2WebACL_Basic (38.61s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       39.052s

@pvanbuijtene pvanbuijtene requested a review from a team April 12, 2020 17:14
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/wafv2 Issues and PRs that pertain to the wafv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 12, 2020
@bflad bflad added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels May 1, 2020
@anGie44
Copy link
Contributor

anGie44 commented May 5, 2020

dropping a note here to rebase and isolate the data source changes when you get a chance @pvanbuijtene :)

@pvanbuijtene pvanbuijtene force-pushed the wafv2-web-acl-data-source branch from befaf5f to 21688db Compare May 7, 2020 20:36
anGie44
anGie44 reviewed May 13, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvanbuijtene implementation is off to great start! just some initial comments here in addition to the rebase comment above

aws/data_source_aws_wafv2_web_acl.go Show resolved Hide resolved
anGie44
anGie44 reviewed May 14, 2020
View reviewed changes
aws/provider.go Outdated Show resolved Hide resolved
@pvanbuijtene pvanbuijtene force-pushed the wafv2-web-acl-data-source branch from 21688db to 5fdf589 Compare May 16, 2020 07:35
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels May 16, 2020
@anGie44
Copy link
Contributor

anGie44 commented May 19, 2020

hi @pvanbuijtene, dropping a note here to please rebase :)

@anGie44 anGie44 added the waiting-response Maintainers are waiting on response from community or contributor. label May 19, 2020
@maryelizbeth maryelizbeth added this to the Roadmap milestone May 19, 2020
@pvanbuijtene pvanbuijtene force-pushed the wafv2-web-acl-data-source branch 2 times, most recently from b0c874b to 464f80b Compare May 22, 2020 17:57
@pvanbuijtene pvanbuijtene requested a review from anGie44 May 22, 2020 18:06
anGie44
anGie44 reviewed May 27, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Holding off acceptance test validation until the resource is merged #12688

@anGie44 anGie44 removed the waiting-response Maintainers are waiting on response from community or contributor. label Jun 8, 2020
@pvanbuijtene pvanbuijtene force-pushed the wafv2-web-acl-data-source branch 2 times, most recently from 8a139ab to bd0dad2 Compare June 13, 2020 10:10
anGie44
anGie44 approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor documentation comments otherwise LGTM @pvanbuijtene!

Output of acceptance test:

--- PASS: TestAccDataSourceAwsWafv2WebACL_Basic (37.64s)

website/docs/d/wafv2_web_acl.html.markdown Outdated Show resolved Hide resolved
website/docs/d/wafv2_web_acl.html.markdown Outdated Show resolved Hide resolved
@anGie44 anGie44 added the waiting-response Maintainers are waiting on response from community or contributor. label Jun 15, 2020
@pvanbuijtene pvanbuijtene force-pushed the wafv2-web-acl-data-source branch from bd0dad2 to 6ab410d Compare June 16, 2020 14:50
@pvanbuijtene
Copy link
Contributor Author

@anGie44 the changes are applied.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jun 16, 2020
@anGie44 anGie44 modified the milestones: Roadmap, v2.67.0 Jun 16, 2020
@anGie44 anGie44 merged commit 5a5521c into hashicorp:master Jun 16, 2020
anGie44 added a commit that referenced this pull request Jun 16, 2020
@anGie44
Update CHANGELOG for #12791
ddd0d88
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.67.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.67.0
Development

Successfully merging this pull request may close these issues.

Feature Request: WAFv2 Web ACL Data Source
4 participants
@pvanbuijtene @anGie44 @bflad @maryelizbeth