r/aws_wafregional_xss_match_set: Fix 'panic: interface conversion: interface {} is *schema.Set, not []interface {}'

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13014.

Also add read after create and plan-time validations, similar to #12777.

Release note for CHANGELOG:

resource/aws_wafregional_xss_match_set: Fix crash during resource update

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSWafRegionalXssMatchSet_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSWafRegionalXssMatchSet_ -timeout 120m
=== RUN   TestAccAWSWafRegionalXssMatchSet_basic
=== PAUSE TestAccAWSWafRegionalXssMatchSet_basic
=== RUN   TestAccAWSWafRegionalXssMatchSet_changeNameForceNew
=== PAUSE TestAccAWSWafRegionalXssMatchSet_changeNameForceNew
=== RUN   TestAccAWSWafRegionalXssMatchSet_disappears
=== PAUSE TestAccAWSWafRegionalXssMatchSet_disappears
=== RUN   TestAccAWSWafRegionalXssMatchSet_changeTuples
=== PAUSE TestAccAWSWafRegionalXssMatchSet_changeTuples
=== RUN   TestAccAWSWafRegionalXssMatchSet_noTuples
=== PAUSE TestAccAWSWafRegionalXssMatchSet_noTuples
=== CONT  TestAccAWSWafRegionalXssMatchSet_basic
=== CONT  TestAccAWSWafRegionalXssMatchSet_changeTuples
=== CONT  TestAccAWSWafRegionalXssMatchSet_disappears
=== CONT  TestAccAWSWafRegionalXssMatchSet_changeNameForceNew
=== CONT  TestAccAWSWafRegionalXssMatchSet_noTuples
--- PASS: TestAccAWSWafRegionalXssMatchSet_noTuples (26.75s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_disappears (30.52s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_basic (35.65s)
--- FAIL: TestAccAWSWafRegionalXssMatchSet_changeTuples (54.18s)
    testing.go:669: Step 2 error: After applying this step and refreshing, the plan was not empty:
        
        DIFF:
        
        UPDATE: aws_wafregional_xss_match_set.test
          id:                                      "da4c4cf8-24d3-4749-aef3-13a9b487abe5" => "da4c4cf8-24d3-4749-aef3-13a9b487abe5"
          name:                                    "tf-acc-test-8703340596436274492" => "tf-acc-test-8703340596436274492"
          xss_match_tuple.#:                       "2" => "2"
          xss_match_tuple.0.field_to_match.#:      "1" => "1"
          xss_match_tuple.0.field_to_match.0.data: "" => "GET"
          xss_match_tuple.0.field_to_match.0.type: "BODY" => "METHOD"
          xss_match_tuple.0.text_transformation:   "CMD_LINE" => "HTML_ENTITY_DECODE"
          xss_match_tuple.1.field_to_match.#:      "1" => "1"
          xss_match_tuple.1.field_to_match.0.data: "" => ""
          xss_match_tuple.1.field_to_match.0.type: "METHOD" => "BODY"
          xss_match_tuple.1.text_transformation:   "HTML_ENTITY_DECODE" => "CMD_LINE"
        
        
        
        STATE:
        
        aws_wafregional_xss_match_set.test:
          ID = da4c4cf8-24d3-4749-aef3-13a9b487abe5
          provider = provider.aws
          name = tf-acc-test-8703340596436274492
          xss_match_tuple.# = 2
          xss_match_tuple.0.field_to_match.# = 1
          xss_match_tuple.0.field_to_match.0.data = 
          xss_match_tuple.0.field_to_match.0.type = BODY
          xss_match_tuple.0.text_transformation = CMD_LINE
          xss_match_tuple.1.field_to_match.# = 1
          xss_match_tuple.1.field_to_match.0.data = 
          xss_match_tuple.1.field_to_match.0.type = METHOD
          xss_match_tuple.1.text_transformation = HTML_ENTITY_DECODE
--- PASS: TestAccAWSWafRegionalXssMatchSet_changeNameForceNew (56.69s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	56.745s
FAIL
GNUmakefile:26: recipe for target 'testacc' failed
make: *** [testacc] Error 1

[ewbankkit]

The diff during plan after update has been noted in #8865.
I will address that separately.

[bflad]

LGTM, thank you for fixing this, @ewbankkit 🚀

Output from acceptance testing (failure unrelated):

--- PASS: TestAccAWSWafRegionalXssMatchSet_basic (20.28s)
--- FAIL: TestAccAWSWafRegionalXssMatchSet_changeTuples (20.72s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_disappears (22.95s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_changeNameForceNew (26.83s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_noTuples (36.76s)

[sc250024]

Thanks @ewbankkit

[ewbankkit]

Also closes #12106.

[ghost]

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!