r/ec2_client_vpn_endpoint - add arn attribute + plan time validations

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13527

Release note for CHANGELOG:

resource_aws_ec2_client_vpn_endpoint: add `arn` attribute.
resource_aws_ec2_client_vpn_endpoint: add plan time validations for `root_certificate_chain_arn`, `client_cidr_block` and `server_certificate_arn`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsEc2ClientVpnEndpoint_ '
--- PASS: TestAccAwsEc2ClientVpnEndpoint_disappears (42.37s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_msAD (1751.79s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_mutualAuthAndMsAD (1774.49s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_withLogGroup (86.98s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_withDNSServers (80.35s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_tags (119.59s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_splitTunnel (82.66s)

[anGie44]

Looks great @DrFaust92! Confirmed ARN specs and output of acceptance tests:

--- PASS: TestAccAwsEc2ClientVpnEndpoint_disappears (11.70s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_basic (13.62s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_withDNSServers (19.59s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_splitTunnel (19.72s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_withLogGroup (24.22s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_tags (30.60s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_mutualAuthAndMsAD (1634.27s)
--- PASS: TestAccAwsEc2ClientVpnEndpoint_msAD (1745.23s)

[ewbankkit]

For any resource that we add an arn attribute that is synthesized using meta.(*AWSClient).accountid, we need to add it to the documented list of resources affected by the provider skip_requesting_account_id flag in website/docs/index.html.markdown.

A note to remind us recently got added to the Contributing Guide.

[anGie44]

ahh thanks for noting that @ewbankkit! @DrFaust92 do you mind updating the index markdown?

[DrFaust92]

@anGie44 , Done for this and other PRs that add ARN.
@ewbankkit , thanks for catching that

[ghost]

This has been released in version 2.65.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!