Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export RemoteAdministrationEndpoint attribute for aws_fsx_windows_file_system #13632

Closed
wants to merge 1 commit into from
Closed

export RemoteAdministrationEndpoint attribute for aws_fsx_windows_file_system #13632

wants to merge 1 commit into from

Conversation

drexler
Copy link
Contributor

@drexler drexler commented Jun 5, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13616

Release note for CHANGELOG:

Exports remote administration endpoint attribute on resource creation

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSFsxWindowsFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxWindowsFileSystem_basic -timeout 120m
=== RUN   TestAccAWSFsxWindowsFileSystem_basic
=== PAUSE TestAccAWSFsxWindowsFileSystem_basic
=== CONT  TestAccAWSFsxWindowsFileSystem_basic
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (2982.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2982.370s

...

@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/fsx Issues and PRs that pertain to the fsx service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 5, 2020
@drexler drexler changed the title feat: export of remote administration endpoint attribute Export RemoteAdministrationEndpoint attribute for aws_fsx_windows_file_system Jun 5, 2020
@drexler drexler changed the title Export RemoteAdministrationEndpoint attribute for aws_fsx_windows_file_system export RemoteAdministrationEndpoint attribute for aws_fsx_windows_file_system Jun 5, 2020
@drexler drexler force-pushed the fsx-remote-admin branch from e0d3a9a to 67d6026 Compare June 5, 2020 12:51
@DrFaust92
Copy link
Collaborator

FYI, ive addressed this as part of #12676

@drexler drexler closed this Jun 5, 2020
@ghost
Copy link

ghost commented Jul 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 5, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/fsx Issues and PRs that pertain to the fsx service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RemoteAdministrationEndpoint attribute for aws_fsx_windows_file_system
3 participants
@drexler @DrFaust92 @breathingdust