Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Fix hardcoded ARN (CloudTrail) #15663

Merged
merged 1 commit into from
Oct 21, 2020
Merged

tests/provider: Fix hardcoded ARN (CloudTrail) #15663

merged 1 commit into from
Oct 21, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 15, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15662

Release note for CHANGELOG:

NONE

The output from acceptance testing (GovCloud):

--- PASS: TestAccAWSCloudTrailServiceAccount_basic (15.42s)
--- PASS: TestAccAWSCloudTrailServiceAccount_Region (15.42s)
--- PASS: TestAccAWSCloudTrail_serial (837.99s)
    --- PASS: TestAccAWSCloudTrail_serial/Trail (837.99s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/includeGlobalServiceEvents (42.29s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/eventSelector (155.27s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/insightSelector (42.69s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/basic (74.04s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/cloudwatch (85.99s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/enableLogging (108.30s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/isMultiRegion (104.89s)
        --- SKIP: TestAccAWSCloudTrail_serial/Trail/isOrganization (1.95s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/logValidation (73.81s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/kmsKey (41.81s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/tags (106.96s)

The output from acceptance testing (commercial):

--- PASS: TestAccAWSCloudTrailServiceAccount_Region (9.74s)
--- PASS: TestAccAWSCloudTrailServiceAccount_basic (9.78s)
--- FAIL: TestAccAWSCloudTrail_serial (727.57s)
    --- FAIL: TestAccAWSCloudTrail_serial/Trail (727.57s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/includeGlobalServiceEvents (40.03s)
        --- SKIP: TestAccAWSCloudTrail_serial/Trail/isOrganization (0.86s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/logValidation (68.41s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/kmsKey (38.69s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/tags (100.21s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/eventSelector (153.04s)
        --- FAIL: TestAccAWSCloudTrail_serial/Trail/basic (53.20s)
        --- FAIL: TestAccAWSCloudTrail_serial/Trail/enableLogging (53.72s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/isMultiRegion (101.63s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/insightSelector (39.56s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/cloudwatch (78.21s)

**Failures are unrelated and due to permissions in the commercial alt account (I am "not authorized to perform: cloudtrail:StopLogging").

@YakDriver YakDriver requested a review from a team October 15, 2020 17:08
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 15, 2020
@YakDriver YakDriver mentioned this pull request Oct 15, 2020
Closed
69 tasks
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Oct 15, 2020
@bflad
Copy link
Contributor

bflad commented Oct 16, 2020

Extraneous go.mod/go.sum changes should be removed 👍

@bflad bflad self-assigned this Oct 16, 2020
bflad
bflad previously requested changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict 😉

@YakDriver YakDriver force-pushed the t-gov-hardarn-cloudtrail branch from d26b086 to be034c6 Compare October 17, 2020 14:05
@YakDriver YakDriver force-pushed the t-gov-hardarn-cloudtrail branch from be034c6 to 9080ecb Compare October 17, 2020 14:09
@YakDriver
Copy link
Member Author

What in the world has go done? Fixed.

@YakDriver YakDriver requested a review from bflad October 17, 2020 14:11
anGie44
anGie44 approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

aws/resource_aws_cloudtrail_test.go Show resolved Hide resolved
@YakDriver YakDriver added this to the v3.12.0 milestone Oct 21, 2020
@YakDriver YakDriver merged commit ce7c4c6 into master Oct 21, 2020
@YakDriver YakDriver deleted the t-gov-hardarn-cloudtrail branch October 21, 2020 19:34
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

@bflad bflad Awaiting requested review from bflad

Assignees

@bflad bflad

@anGie44 anGie44

Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@YakDriver @bflad @anGie44