-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_internet_gateway: Correct the ARN account id #17803
aws_internet_gateway: Correct the ARN account id #17803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
$ ACCTEST_PARALLELISM=2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInternetGateway_\|TestAccDataSourceAwsInternetGateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInternetGateway_\|TestAccDataSourceAwsInternetGateway_ -timeout 120m
=== RUN TestAccDataSourceAwsInternetGateway_typical
=== PAUSE TestAccDataSourceAwsInternetGateway_typical
=== RUN TestAccAWSInternetGateway_basic
=== PAUSE TestAccAWSInternetGateway_basic
=== RUN TestAccAWSInternetGateway_delete
=== PAUSE TestAccAWSInternetGateway_delete
=== RUN TestAccAWSInternetGateway_tags
=== PAUSE TestAccAWSInternetGateway_tags
=== RUN TestAccAWSInternetGateway_disappears
=== PAUSE TestAccAWSInternetGateway_disappears
=== CONT TestAccDataSourceAwsInternetGateway_typical
=== CONT TestAccAWSInternetGateway_tags
--- PASS: TestAccDataSourceAwsInternetGateway_typical (33.05s)
=== CONT TestAccAWSInternetGateway_disappears
--- PASS: TestAccAWSInternetGateway_disappears (31.14s)
=== CONT TestAccAWSInternetGateway_delete
--- PASS: TestAccAWSInternetGateway_tags (81.49s)
=== CONT TestAccAWSInternetGateway_basic
--- PASS: TestAccAWSInternetGateway_delete (51.40s)
--- PASS: TestAccAWSInternetGateway_basic (74.91s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 156.513s
LGTM 🚀 Thanks @shuheiktgw! Verified Acceptance Tests in Commercial (us-west-2) ACCTEST_PARALLELISM=2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInternetGateway_\|TestAccDataSourceAwsInternetGateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInternetGateway_\|TestAccDataSourceAwsInternetGateway_ -timeout 120m
=== RUN TestAccDataSourceAwsInternetGateway_typical
=== PAUSE TestAccDataSourceAwsInternetGateway_typical
=== RUN TestAccAWSInternetGateway_basic
=== PAUSE TestAccAWSInternetGateway_basic
=== RUN TestAccAWSInternetGateway_delete
=== PAUSE TestAccAWSInternetGateway_delete
=== RUN TestAccAWSInternetGateway_tags
=== PAUSE TestAccAWSInternetGateway_tags
=== RUN TestAccAWSInternetGateway_disappears
=== PAUSE TestAccAWSInternetGateway_disappears
=== CONT TestAccDataSourceAwsInternetGateway_typical
=== CONT TestAccAWSInternetGateway_tags
--- PASS: TestAccDataSourceAwsInternetGateway_typical (27.94s)
=== CONT TestAccAWSInternetGateway_disappears
--- PASS: TestAccAWSInternetGateway_disappears (24.34s)
=== CONT TestAccAWSInternetGateway_delete
--- PASS: TestAccAWSInternetGateway_tags (62.99s)
=== CONT TestAccAWSInternetGateway_basic
--- PASS: TestAccAWSInternetGateway_delete (41.48s)
--- PASS: TestAccAWSInternetGateway_basic (58.24s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 124.049s Verified Acceptance Tests in GovCloud (us-gov-west-1) ACCTEST_PARALLELISM=2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSInternetGateway_\|TestAccDataSourceAwsInternetGateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSInternetGateway_\|TestAccDataSourceAwsInternetGateway_ -timeout 120m
=== RUN TestAccDataSourceAwsInternetGateway_typical
=== PAUSE TestAccDataSourceAwsInternetGateway_typical
=== RUN TestAccAWSInternetGateway_basic
=== PAUSE TestAccAWSInternetGateway_basic
=== RUN TestAccAWSInternetGateway_delete
=== PAUSE TestAccAWSInternetGateway_delete
=== RUN TestAccAWSInternetGateway_tags
=== PAUSE TestAccAWSInternetGateway_tags
=== RUN TestAccAWSInternetGateway_disappears
=== PAUSE TestAccAWSInternetGateway_disappears
=== CONT TestAccDataSourceAwsInternetGateway_typical
=== CONT TestAccAWSInternetGateway_tags
--- PASS: TestAccDataSourceAwsInternetGateway_typical (23.07s)
=== CONT TestAccAWSInternetGateway_delete
--- PASS: TestAccAWSInternetGateway_tags (48.21s)
=== CONT TestAccAWSInternetGateway_basic
--- PASS: TestAccAWSInternetGateway_delete (32.09s)
=== CONT TestAccAWSInternetGateway_disappears
--- PASS: TestAccAWSInternetGateway_disappears (21.07s)
--- PASS: TestAccAWSInternetGateway_basic (48.21s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 98.979s |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates #16978
Output from acceptance testing:
Thank you for your review!