provider: Migrate to iamwaiter.PropagationTimeout constant and begin enabling go-mnd linter

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13199
Closes #16752
Reference: #16753

IAM eventual consistency handling has long been the source of needing retries in resource logic. Due to the lack of a consistent implementation (e.g. static constant) for how long to retry for these types of errors, there have been varying retry durations. The iamwaiter.PropagationTimeout constant was introduced for this purpose.

This change begins by introducing the go-mnd linter to enforce the usage of constants in function arguments. Example reports below. The rest of the changes are the minimum required to ensure iamwaiter.PropagationTimeout with its 2 minute duration is applied. You will note that this is fixing the duration in some cases to slightly increase it to the standard value. Any higher durations are ignored to reduce changes for now. As such, this can be reviewed by validating that a lower duration was not introduced and skipping acceptance testing since no logic changes should be introduced.

One caveat to go-mnd is that it currently ignores 1 as a magic number, which is possible in usage such as 1*time.Minute, and that ignored number cannot be overriden. An upstream issue will be created to ask the ignore-number configuration to overwrite instead of append.

Example previous report:

aws/resource_aws_api_gateway_account.go:99:23: mnd: Magic number: 2, in <argument> detected (gomnd)
	err = resource.Retry(2*time.Minute, func() *resource.RetryError {
	                     ^

Output from acceptance testing: N/A (see note above)

[bflad]

(Rebased to ensure this is up to date)

[gdavison]

LGTM 🚀

[ghost]

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!