Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/codepipeline: Add ErrorCheck #18265

Merged
merged 2 commits into from
Mar 19, 2021
Merged

tests/codepipeline: Add ErrorCheck #18265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a0d523
tests/r/codepipeline_webhook: Add ErrorCheck
YakDriver Mar 19, 2021
f639d9e
tests/r/codepipeline: Add ErrorCheck
YakDriver Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions aws/resource_aws_codepipeline_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ func TestAccAWSCodePipeline_basic(t *testing.T) {
testAccPreCheckAWSCodePipelineSupported(t)
testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t)
},
ErrorCheck: testAccErrorCheck(t, codepipeline.EndpointsID),
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSCodePipelineDestroy,
Steps: []resource.TestStep{
Expand Down Expand Up @@ -131,6 +132,7 @@ func TestAccAWSCodePipeline_disappears(t *testing.T) {
testAccPreCheckAWSCodePipelineSupported(t)
testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t)
},
ErrorCheck: testAccErrorCheck(t, codepipeline.EndpointsID),
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSCodePipelineDestroy,
Steps: []resource.TestStep{
Expand All @@ -157,6 +159,7 @@ func TestAccAWSCodePipeline_emptyStageArtifacts(t *testing.T) {
testAccPreCheckAWSCodePipelineSupported(t)
testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t)
},
ErrorCheck: testAccErrorCheck(t, codepipeline.EndpointsID),
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSCodePipelineDestroy,
Steps: []resource.TestStep{
Expand Down Expand Up @@ -198,6 +201,7 @@ func TestAccAWSCodePipeline_deployWithServiceRole(t *testing.T) {
testAccPreCheckAWSCodePipelineSupported(t)
testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t)
},
ErrorCheck: testAccErrorCheck(t, codepipeline.EndpointsID),
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSCodePipelineDestroy,
Steps: []resource.TestStep{
Expand Down Expand Up @@ -230,6 +234,7 @@ func TestAccAWSCodePipeline_tags(t *testing.T) {
testAccPreCheckAWSCodePipelineSupported(t)
testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t)
},
ErrorCheck: testAccErrorCheck(t, codepipeline.EndpointsID),
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSCodePipelineDestroy,
Steps: []resource.TestStep{
Expand Down Expand Up @@ -288,6 +293,7 @@ func TestAccAWSCodePipeline_multiregion_basic(t *testing.T) {
testAccPreCheckAWSCodePipelineSupported(t, testAccGetAlternateRegion())
testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t)
},
ErrorCheck: testAccErrorCheck(t, codepipeline.EndpointsID),
ProviderFactories: testAccProviderFactoriesAlternate(&providers),
CheckDestroy: testAccCheckAWSCodePipelineDestroy,
Steps: []resource.TestStep{
Expand Down Expand Up @@ -329,6 +335,7 @@ func TestAccAWSCodePipeline_multiregion_Update(t *testing.T) {
testAccPreCheckAWSCodePipelineSupported(t, testAccGetAlternateRegion())
testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t)
},
ErrorCheck: testAccErrorCheck(t, codepipeline.EndpointsID),
ProviderFactories: testAccProviderFactoriesAlternate(&providers),
CheckDestroy: testAccCheckAWSCodePipelineDestroy,
Steps: []resource.TestStep{
Expand Down Expand Up @@ -384,6 +391,7 @@ func TestAccAWSCodePipeline_multiregion_ConvertSingleRegion(t *testing.T) {
testAccPreCheckAWSCodePipelineSupported(t, testAccGetAlternateRegion())
testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t)
},
ErrorCheck: testAccErrorCheck(t, codepipeline.EndpointsID),
ProviderFactories: testAccProviderFactoriesAlternate(&providers),
CheckDestroy: testAccCheckAWSCodePipelineDestroy,
Steps: []resource.TestStep{
Expand Down Expand Up @@ -446,6 +454,7 @@ func TestAccAWSCodePipeline_WithNamespace(t *testing.T) {
testAccPreCheckAWSCodePipelineSupported(t)
testAccPartitionHasServicePreCheck(codestarconnections.EndpointsID, t)
},
ErrorCheck: testAccErrorCheck(t, codepipeline.EndpointsID),
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSCodePipelineDestroy,
Steps: []resource.TestStep{
Expand Down Expand Up @@ -478,6 +487,7 @@ func TestAccAWSCodePipeline_WithGitHubv1SourceAction(t *testing.T) {
testAccPreCheck(t)
testAccPreCheckAWSCodePipelineSupported(t)
},
ErrorCheck: testAccErrorCheck(t, codepipeline.EndpointsID),
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSCodePipelineDestroy,
Steps: []resource.TestStep{
Expand Down
5 changes: 5 additions & 0 deletions aws/resource_aws_codepipeline_webhook_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ func TestAccAWSCodePipelineWebhook_basic(t *testing.T) {
testAccPreCheck(t)
testAccPreCheckAWSCodePipelineSupported(t)
},
ErrorCheck: testAccErrorCheck(t, codepipeline.EndpointsID),
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSCodePipelineDestroy,
Steps: []resource.TestStep{
Expand Down Expand Up @@ -60,6 +61,7 @@ func TestAccAWSCodePipelineWebhook_ipAuth(t *testing.T) {
testAccPreCheck(t)
testAccPreCheckAWSCodePipelineSupported(t)
},
ErrorCheck: testAccErrorCheck(t, codepipeline.EndpointsID),
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSCodePipelineDestroy,
Steps: []resource.TestStep{
Expand Down Expand Up @@ -94,6 +96,7 @@ func TestAccAWSCodePipelineWebhook_unauthenticated(t *testing.T) {
testAccPreCheck(t)
testAccPreCheckAWSCodePipelineSupported(t)
},
ErrorCheck: testAccErrorCheck(t, codepipeline.EndpointsID),
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSCodePipelineDestroy,
Steps: []resource.TestStep{
Expand Down Expand Up @@ -126,6 +129,7 @@ func TestAccAWSCodePipelineWebhook_tags(t *testing.T) {
testAccPreCheck(t)
testAccPreCheckAWSCodePipelineSupported(t)
},
ErrorCheck: testAccErrorCheck(t, codepipeline.EndpointsID),
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSCodePipelineDestroy,
Steps: []resource.TestStep{
Expand Down Expand Up @@ -189,6 +193,7 @@ func TestAccAWSCodePipelineWebhook_UpdateAuthenticationConfiguration_SecretToken
testAccPreCheck(t)
testAccPreCheckAWSCodePipelineSupported(t)
},
ErrorCheck: testAccErrorCheck(t, codepipeline.EndpointsID),
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSCodePipelineDestroy,
Steps: []resource.TestStep{
Expand Down