r/vpn_connection - modify from/to vgw/tgw

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8500.
Closes #17945.
Closes #11284.
Closes #10548.
Closes #20685.
Closes #22177.
Closes #19079.
Closes #4728.
Supersedes #21796.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[DrFaust92]

Interesting enough the use case of moving from vgw to tgw is not working and i get this error:

Error: error modifying EC2 VPN Connection (): MissingParameter: The request must contain the parameter transitGatewayId

otherwise all 3 other cases are working.

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TESTARGS='-run=TestAccEC2VPNConnectionRoute_\|TestAccEC2VPNConnection_' PKG_NAME=internal/service/ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2VPNConnectionRoute_\|TestAccEC2VPNConnection_ -timeout 180m
=== RUN   TestAccEC2VPNConnectionRoute_basic
=== PAUSE TestAccEC2VPNConnectionRoute_basic
=== RUN   TestAccEC2VPNConnectionRoute_disappears
=== PAUSE TestAccEC2VPNConnectionRoute_disappears
=== RUN   TestAccEC2VPNConnection_basic
=== PAUSE TestAccEC2VPNConnection_basic
=== RUN   TestAccEC2VPNConnection_transitGatewayID
=== PAUSE TestAccEC2VPNConnection_transitGatewayID
=== RUN   TestAccEC2VPNConnection_tunnel1InsideCIDR
=== PAUSE TestAccEC2VPNConnection_tunnel1InsideCIDR
=== RUN   TestAccEC2VPNConnection_tunnel1InsideIPv6CIDR
=== PAUSE TestAccEC2VPNConnection_tunnel1InsideIPv6CIDR
=== RUN   TestAccEC2VPNConnection_tunnel1PreSharedKey
=== PAUSE TestAccEC2VPNConnection_tunnel1PreSharedKey
=== RUN   TestAccEC2VPNConnection_tunnelOptions
=== PAUSE TestAccEC2VPNConnection_tunnelOptions
=== RUN   TestAccEC2VPNConnection_tunnelOptionsLesser
=== PAUSE TestAccEC2VPNConnection_tunnelOptionsLesser
=== RUN   TestAccEC2VPNConnection_withStaticRoutes
=== PAUSE TestAccEC2VPNConnection_withStaticRoutes
=== RUN   TestAccEC2VPNConnection_withEnableAcceleration
=== PAUSE TestAccEC2VPNConnection_withEnableAcceleration
=== RUN   TestAccEC2VPNConnection_withIPv6
=== PAUSE TestAccEC2VPNConnection_withIPv6
=== RUN   TestAccEC2VPNConnection_tags
=== PAUSE TestAccEC2VPNConnection_tags
=== RUN   TestAccEC2VPNConnection_specifyIPv4
=== PAUSE TestAccEC2VPNConnection_specifyIPv4
=== RUN   TestAccEC2VPNConnection_specifyIPv6
=== PAUSE TestAccEC2VPNConnection_specifyIPv6
=== RUN   TestAccEC2VPNConnection_disappears
=== PAUSE TestAccEC2VPNConnection_disappears
=== RUN   TestAccEC2VPNConnection_updateCustomerGatewayID
=== PAUSE TestAccEC2VPNConnection_updateCustomerGatewayID
=== RUN   TestAccEC2VPNConnection_updateVPNGatewayID
=== PAUSE TestAccEC2VPNConnection_updateVPNGatewayID
=== RUN   TestAccEC2VPNConnection_updateTransitGatewayID
=== PAUSE TestAccEC2VPNConnection_updateTransitGatewayID
=== RUN   TestAccEC2VPNConnection_vpnGatewayIDToTransitGatewayID
=== PAUSE TestAccEC2VPNConnection_vpnGatewayIDToTransitGatewayID
=== RUN   TestAccEC2VPNConnection_transitGatewayIDToVPNGatewayID
=== PAUSE TestAccEC2VPNConnection_transitGatewayIDToVPNGatewayID
=== CONT  TestAccEC2VPNConnectionRoute_basic
=== CONT  TestAccEC2VPNConnection_withIPv6
=== CONT  TestAccEC2VPNConnection_withStaticRoutes
=== CONT  TestAccEC2VPNConnection_disappears
=== CONT  TestAccEC2VPNConnection_transitGatewayID
=== CONT  TestAccEC2VPNConnection_tunnel1InsideCIDR
=== CONT  TestAccEC2VPNConnection_tunnel1PreSharedKey
=== CONT  TestAccEC2VPNConnection_withEnableAcceleration
=== CONT  TestAccEC2VPNConnection_transitGatewayIDToVPNGatewayID
=== CONT  TestAccEC2VPNConnection_vpnGatewayIDToTransitGatewayID
=== CONT  TestAccEC2VPNConnection_tunnelOptionsLesser
=== CONT  TestAccEC2VPNConnection_updateTransitGatewayID
=== CONT  TestAccEC2VPNConnection_updateVPNGatewayID
=== CONT  TestAccEC2VPNConnection_updateCustomerGatewayID
=== CONT  TestAccEC2VPNConnection_specifyIPv4
=== CONT  TestAccEC2VPNConnection_tags
=== CONT  TestAccEC2VPNConnection_tunnelOptions
=== CONT  TestAccEC2VPNConnection_specifyIPv6
=== CONT  TestAccEC2VPNConnection_basic
=== CONT  TestAccEC2VPNConnection_tunnel1InsideIPv6CIDR
--- PASS: TestAccEC2VPNConnection_basic (304.32s)
=== CONT  TestAccEC2VPNConnectionRoute_disappears
--- PASS: TestAccEC2VPNConnection_tunnel1InsideCIDR (328.38s)
--- PASS: TestAccEC2VPNConnection_disappears (329.41s)
--- PASS: TestAccEC2VPNConnection_withStaticRoutes (338.14s)
--- PASS: TestAccEC2VPNConnection_tunnel1PreSharedKey (438.39s)
--- PASS: TestAccEC2VPNConnection_tunnelOptions (471.47s)
--- PASS: TestAccEC2VPNConnectionRoute_basic (490.99s)
--- PASS: TestAccEC2VPNConnection_tags (554.91s)
--- PASS: TestAccEC2VPNConnection_withIPv6 (616.73s)
--- PASS: TestAccEC2VPNConnection_specifyIPv6 (624.29s)
--- PASS: TestAccEC2VPNConnectionRoute_disappears (406.76s)
--- PASS: TestAccEC2VPNConnection_transitGatewayID (739.71s)
--- PASS: TestAccEC2VPNConnection_specifyIPv4 (775.90s)
--- PASS: TestAccEC2VPNConnection_withEnableAcceleration (802.53s)
--- PASS: TestAccEC2VPNConnection_tunnel1InsideIPv6CIDR (803.71s)
--- PASS: TestAccEC2VPNConnection_updateCustomerGatewayID (824.02s)
--- PASS: TestAccEC2VPNConnection_updateVPNGatewayID (861.35s)
--- PASS: TestAccEC2VPNConnection_transitGatewayIDToVPNGatewayID (1159.38s)
--- PASS: TestAccEC2VPNConnection_updateTransitGatewayID (1160.45s)
--- PASS: TestAccEC2VPNConnection_vpnGatewayIDToTransitGatewayID (1213.65s)
--- PASS: TestAccEC2VPNConnection_tunnelOptionsLesser (1484.87s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        1488.746s

GovCloud

% make testacc TESTARGS='-run=TestAccEC2VPNConnectionRoute_\|TestAccEC2VPNConnection_' PKG_NAME=internal/service/ec2 ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 5  -run=TestAccEC2VPNConnectionRoute_\|TestAccEC2VPNConnection_ -timeout 180m
=== RUN   TestAccEC2VPNConnectionRoute_basic
=== PAUSE TestAccEC2VPNConnectionRoute_basic
=== RUN   TestAccEC2VPNConnectionRoute_disappears
=== PAUSE TestAccEC2VPNConnectionRoute_disappears
=== RUN   TestAccEC2VPNConnection_basic
=== PAUSE TestAccEC2VPNConnection_basic
=== RUN   TestAccEC2VPNConnection_transitGatewayID
=== PAUSE TestAccEC2VPNConnection_transitGatewayID
=== RUN   TestAccEC2VPNConnection_tunnel1InsideCIDR
=== PAUSE TestAccEC2VPNConnection_tunnel1InsideCIDR
=== RUN   TestAccEC2VPNConnection_tunnel1InsideIPv6CIDR
=== PAUSE TestAccEC2VPNConnection_tunnel1InsideIPv6CIDR
=== RUN   TestAccEC2VPNConnection_tunnel1PreSharedKey
=== PAUSE TestAccEC2VPNConnection_tunnel1PreSharedKey
=== RUN   TestAccEC2VPNConnection_tunnelOptions
=== PAUSE TestAccEC2VPNConnection_tunnelOptions
=== RUN   TestAccEC2VPNConnection_tunnelOptionsLesser
=== PAUSE TestAccEC2VPNConnection_tunnelOptionsLesser
=== RUN   TestAccEC2VPNConnection_withStaticRoutes
=== PAUSE TestAccEC2VPNConnection_withStaticRoutes
=== RUN   TestAccEC2VPNConnection_withEnableAcceleration
=== PAUSE TestAccEC2VPNConnection_withEnableAcceleration
=== RUN   TestAccEC2VPNConnection_withIPv6
=== PAUSE TestAccEC2VPNConnection_withIPv6
=== RUN   TestAccEC2VPNConnection_tags
=== PAUSE TestAccEC2VPNConnection_tags
=== RUN   TestAccEC2VPNConnection_specifyIPv4
=== PAUSE TestAccEC2VPNConnection_specifyIPv4
=== RUN   TestAccEC2VPNConnection_specifyIPv6
=== PAUSE TestAccEC2VPNConnection_specifyIPv6
=== RUN   TestAccEC2VPNConnection_disappears
=== PAUSE TestAccEC2VPNConnection_disappears
=== RUN   TestAccEC2VPNConnection_updateCustomerGatewayID
=== PAUSE TestAccEC2VPNConnection_updateCustomerGatewayID
=== RUN   TestAccEC2VPNConnection_updateVPNGatewayID
=== PAUSE TestAccEC2VPNConnection_updateVPNGatewayID
=== RUN   TestAccEC2VPNConnection_updateTransitGatewayID
=== PAUSE TestAccEC2VPNConnection_updateTransitGatewayID
=== RUN   TestAccEC2VPNConnection_vpnGatewayIDToTransitGatewayID
=== PAUSE TestAccEC2VPNConnection_vpnGatewayIDToTransitGatewayID
=== RUN   TestAccEC2VPNConnection_transitGatewayIDToVPNGatewayID
=== PAUSE TestAccEC2VPNConnection_transitGatewayIDToVPNGatewayID
=== CONT  TestAccEC2VPNConnectionRoute_basic
=== CONT  TestAccEC2VPNConnection_withIPv6
=== CONT  TestAccEC2VPNConnection_tunnel1PreSharedKey
=== CONT  TestAccEC2VPNConnection_withEnableAcceleration
=== CONT  TestAccEC2VPNConnection_withStaticRoutes
=== CONT  TestAccEC2VPNConnection_withEnableAcceleration
    acctest.go:1007: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating EC2 VPN Connection: InvalidParameterValue: Invalid value specified for Accelerated VPN is not supported in this region.
                status code: 400, request id: 66bc3061-bbb0-4728-af55-385ea464d764
        
          with aws_vpn_connection.test,
          on terraform_plugin_test.tf line 16, in resource "aws_vpn_connection" "test":
          16: resource "aws_vpn_connection" "test" {
        
--- SKIP: TestAccEC2VPNConnection_withEnableAcceleration (214.32s)
--- PASS: TestAccEC2VPNConnection_tunnel1PreSharedKey (224.08s)
=== CONT  TestAccEC2VPNConnection_tunnelOptions
--- PASS: TestAccEC2VPNConnection_withStaticRoutes (229.23s)
=== CONT  TestAccEC2VPNConnection_transitGatewayID
=== CONT  TestAccEC2VPNConnection_tunnelOptions
    acctest.go:964: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating EC2 VPN Connection: InvalidParameterValue: Invalid value specified for Phase1IntegrityAlgorithms.
                status code: 400, request id: 5c8b8747-5d59-4862-838f-2881ded599bc
        
          with aws_vpn_connection.test,
          on terraform_plugin_test.tf line 18, in resource "aws_vpn_connection" "test":
          18: resource "aws_vpn_connection" "test" {
        
--- PASS: TestAccEC2VPNConnectionRoute_basic (266.08s)
=== CONT  TestAccEC2VPNConnection_tunnel1InsideIPv6CIDR
--- SKIP: TestAccEC2VPNConnection_tunnelOptions (44.64s)
=== CONT  TestAccEC2VPNConnection_tunnel1InsideCIDR
=== CONT  TestAccEC2VPNConnection_tunnelOptionsLesser
    acctest.go:964: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating EC2 VPN Connection: InvalidParameterValue: Invalid value specified for Phase2IntegrityAlgorithms.
                status code: 400, request id: e68b1771-49cf-4c8e-a6cc-17081a23a728
        
          with aws_vpn_connection.test,
          on terraform_plugin_test.tf line 18, in resource "aws_vpn_connection" "test":
          18: resource "aws_vpn_connection" "test" {
        
--- SKIP: TestAccEC2VPNConnection_tunnelOptionsLesser (23.61s)
=== CONT  TestAccEC2VPNConnection_updateVPNGatewayID
--- PASS: TestAccEC2VPNConnection_withIPv6 (517.92s)
=== CONT  TestAccEC2VPNConnection_transitGatewayIDToVPNGatewayID
--- PASS: TestAccEC2VPNConnection_tunnel1InsideCIDR (253.03s)
=== CONT  TestAccEC2VPNConnection_vpnGatewayIDToTransitGatewayID
--- PASS: TestAccEC2VPNConnection_transitGatewayID (488.46s)
=== CONT  TestAccEC2VPNConnection_updateTransitGatewayID
--- PASS: TestAccEC2VPNConnection_tunnel1InsideIPv6CIDR (494.12s)
=== CONT  TestAccEC2VPNConnection_basic
--- PASS: TestAccEC2VPNConnection_basic (223.83s)
=== CONT  TestAccEC2VPNConnection_specifyIPv6
--- PASS: TestAccEC2VPNConnection_updateVPNGatewayID (563.36s)
=== CONT  TestAccEC2VPNConnection_updateCustomerGatewayID
--- PASS: TestAccEC2VPNConnection_transitGatewayIDToVPNGatewayID (711.33s)
=== CONT  TestAccEC2VPNConnection_disappears
--- PASS: TestAccEC2VPNConnection_vpnGatewayIDToTransitGatewayID (829.77s)
=== CONT  TestAccEC2VPNConnection_specifyIPv4
--- PASS: TestAccEC2VPNConnection_specifyIPv6 (486.53s)
=== CONT  TestAccEC2VPNConnection_tags
--- PASS: TestAccEC2VPNConnection_disappears (248.13s)
=== CONT  TestAccEC2VPNConnectionRoute_disappears
--- PASS: TestAccEC2VPNConnection_updateCustomerGatewayID (538.75s)
--- PASS: TestAccEC2VPNConnection_updateTransitGatewayID (870.76s)
--- PASS: TestAccEC2VPNConnectionRoute_disappears (252.28s)
--- PASS: TestAccEC2VPNConnection_tags (283.38s)
--- PASS: TestAccEC2VPNConnection_specifyIPv4 (575.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        1936.656s

[github-actions]

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.