r/aws_athena_database: remove ForceNew from bucket field

[miyajan]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Why?

The ForceNew: true is specified in the bucket field of aws_athena_database. But there is no need for the resource to be recreated when the bucket field is changed, since the bucket field is only used to store the query results during database creation & deletion.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAthenaDatabase_' PKG_NAME=internal/service/athena
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/athena/... -v -count 1 -parallel 20 -run=TestAccAthenaDatabase_ -timeout 180m
=== RUN   TestAccAthenaDatabase_basic
=== PAUSE TestAccAthenaDatabase_basic
=== RUN   TestAccAthenaDatabase_encryption
=== PAUSE TestAccAthenaDatabase_encryption
=== RUN   TestAccAthenaDatabase_nameStartsWithUnderscore
=== PAUSE TestAccAthenaDatabase_nameStartsWithUnderscore
=== RUN   TestAccAthenaDatabase_nameCantHaveUppercase
=== PAUSE TestAccAthenaDatabase_nameCantHaveUppercase
=== RUN   TestAccAthenaDatabase_destroyFailsIfTablesExist
=== PAUSE TestAccAthenaDatabase_destroyFailsIfTablesExist
=== RUN   TestAccAthenaDatabase_forceDestroyAlwaysSucceeds
=== PAUSE TestAccAthenaDatabase_forceDestroyAlwaysSucceeds
=== CONT  TestAccAthenaDatabase_basic
=== CONT  TestAccAthenaDatabase_destroyFailsIfTablesExist
=== CONT  TestAccAthenaDatabase_nameCantHaveUppercase
=== CONT  TestAccAthenaDatabase_nameStartsWithUnderscore
=== CONT  TestAccAthenaDatabase_encryption
=== CONT  TestAccAthenaDatabase_forceDestroyAlwaysSucceeds
--- PASS: TestAccAthenaDatabase_nameCantHaveUppercase (3.94s)
--- PASS: TestAccAthenaDatabase_nameStartsWithUnderscore (57.61s)
--- PASS: TestAccAthenaDatabase_basic (57.64s)
--- PASS: TestAccAthenaDatabase_forceDestroyAlwaysSucceeds (62.24s)
--- PASS: TestAccAthenaDatabase_encryption (63.03s)
--- PASS: TestAccAthenaDatabase_destroyFailsIfTablesExist (71.76s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/athena    73.794s

[github-actions]

Welcome @miyajan 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

@xxx Thanks for the contribution 🎉 👏.
Your change has been rolled into #23745.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.