-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_memorydb_snapshot #22486
Conversation
e1fe12f
to
2fc92d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc PKG=memorydb TESTS=TestAccMemoryDBSnapshot_ ACCTEST_PARALLELISM=3 ACCTEST_TIMEOUT=600m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 3 -run='TestAccMemoryDBSnapshot_' -timeout 600m
=== RUN TestAccMemoryDBSnapshot_basic
=== PAUSE TestAccMemoryDBSnapshot_basic
=== RUN TestAccMemoryDBSnapshot_disappears
=== PAUSE TestAccMemoryDBSnapshot_disappears
=== RUN TestAccMemoryDBSnapshot_nameGenerated
=== PAUSE TestAccMemoryDBSnapshot_nameGenerated
=== RUN TestAccMemoryDBSnapshot_namePrefix
=== PAUSE TestAccMemoryDBSnapshot_namePrefix
=== RUN TestAccMemoryDBSnapshot_create_withKMS
=== PAUSE TestAccMemoryDBSnapshot_create_withKMS
=== RUN TestAccMemoryDBSnapshot_update_tags
=== PAUSE TestAccMemoryDBSnapshot_update_tags
=== CONT TestAccMemoryDBSnapshot_basic
=== CONT TestAccMemoryDBSnapshot_namePrefix
=== CONT TestAccMemoryDBSnapshot_nameGenerated
--- PASS: TestAccMemoryDBSnapshot_namePrefix (2113.74s)
=== CONT TestAccMemoryDBSnapshot_disappears
--- PASS: TestAccMemoryDBSnapshot_basic (2136.02s)
=== CONT TestAccMemoryDBSnapshot_update_tags
--- PASS: TestAccMemoryDBSnapshot_nameGenerated (2155.22s)
=== CONT TestAccMemoryDBSnapshot_create_withKMS
--- PASS: TestAccMemoryDBSnapshot_disappears (2171.08s)
--- PASS: TestAccMemoryDBSnapshot_create_withKMS (2145.63s)
--- PASS: TestAccMemoryDBSnapshot_update_tags (2263.56s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 4403.248s
GovCloud
% make testacc PKG=memorydb TESTS=TestAccMemoryDBSnapshot_ ACCTEST_PARALLELISM=3 ACCTEST_TIMEOUT=600m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 3 -run='TestAccMemoryDBSnapshot_' -timeout 600m
=== RUN TestAccMemoryDBSnapshot_basic
=== PAUSE TestAccMemoryDBSnapshot_basic
=== RUN TestAccMemoryDBSnapshot_disappears
=== PAUSE TestAccMemoryDBSnapshot_disappears
=== RUN TestAccMemoryDBSnapshot_nameGenerated
=== PAUSE TestAccMemoryDBSnapshot_nameGenerated
=== RUN TestAccMemoryDBSnapshot_namePrefix
=== PAUSE TestAccMemoryDBSnapshot_namePrefix
=== RUN TestAccMemoryDBSnapshot_create_withKMS
=== PAUSE TestAccMemoryDBSnapshot_create_withKMS
=== RUN TestAccMemoryDBSnapshot_update_tags
=== PAUSE TestAccMemoryDBSnapshot_update_tags
=== CONT TestAccMemoryDBSnapshot_basic
=== CONT TestAccMemoryDBSnapshot_create_withKMS
=== CONT TestAccMemoryDBSnapshot_update_tags
=== CONT TestAccMemoryDBSnapshot_basic
subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT TestAccMemoryDBSnapshot_create_withKMS
subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBSnapshot_basic (1.57s)
--- SKIP: TestAccMemoryDBSnapshot_create_withKMS (1.57s)
=== CONT TestAccMemoryDBSnapshot_nameGenerated
=== CONT TestAccMemoryDBSnapshot_namePrefix
=== CONT TestAccMemoryDBSnapshot_update_tags
subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
=== CONT TestAccMemoryDBSnapshot_namePrefix
subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBSnapshot_update_tags (1.58s)
=== CONT TestAccMemoryDBSnapshot_disappears
--- SKIP: TestAccMemoryDBSnapshot_namePrefix (0.00s)
=== CONT TestAccMemoryDBSnapshot_disappears
subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBSnapshot_disappears (0.00s)
=== CONT TestAccMemoryDBSnapshot_nameGenerated
subnet_group_test.go:25: MemoryDB is not supported in aws-us-gov partition
--- SKIP: TestAccMemoryDBSnapshot_nameGenerated (0.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/memorydb 5.094s
@roberth-k Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #20631
Output from acceptance testing: