Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket_lifecycle_configuration: new resource #22579

Merged
merged 8 commits into from
Feb 3, 2022
Merged

r/s3_bucket_lifecycle_configuration: new resource #22579

merged 8 commits into from
Feb 3, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 13, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4418
Relates #20433
Closes #6188
Closes #283

Output from acceptance testing:

--- PASS: TestAccS3BucketLifecycleConfiguration_disappears (294.14s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Prefix (337.06s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_EmptyBlock (337.09s)
--- PASS: TestAccS3BucketLifecycleConfiguration_NonCurrentVersionExpiration (357.39s)
--- PASS: TestAccS3BucketLifecycleConfiguration_MultipleRules (366.20s)
--- PASS: TestAccS3BucketLifecycleConfiguration_NonCurrentVersionTransition (366.25s)
--- PASS: TestAccS3BucketLifecycleConfiguration_basic (367.27s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload (454.52s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_ExpireMarkerOnly (456.94s)
--- PASS: TestAccS3BucketLifecycleConfiguration_update (550.75s)
--- PASS: TestAccS3BucketLifecycleConfiguration_DisableRule (551.39s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jan 13, 2022
@anGie44 anGie44 added the new-resource Introduces a new resource. label Jan 13, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation-and-new-resource branch from 8abed34 to 0a9fbf3 Compare January 13, 2022 20:40
@anGie44 anGie44 changed the title r/s3_bucket: deprecate lifecycle_rule and add new lifecycle_configuration resource r/s3_bucketlifecycle_configuration: new resource Jan 13, 2022
@anGie44 anGie44 changed the title r/s3_bucketlifecycle_configuration: new resource r/s3_bucket_lifecycle_configuration: new resource Jan 13, 2022
@github-actions github-actions bot removed the tags Pertains to resource tagging. label Jan 13, 2022
@anGie44 anGie44 mentioned this pull request Jan 13, 2022
Merged
@anGie44 anGie44 changed the base branch from main to release/4.x January 13, 2022 22:45
@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation-and-new-resource branch 2 times, most recently from f8fd852 to 492a520 Compare January 14, 2022 18:22
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@anGie44 anGie44 force-pushed the release/4.x branch 2 times, most recently from 44a00a8 to 5ac8e8c Compare January 26, 2022 18:37
@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation-and-new-resource branch from 3744c80 to ede486b Compare January 26, 2022 22:52
@anGie44 anGie44 marked this pull request as ready for review January 26, 2022 22:52
@anGie44 anGie44 force-pushed the release/4.x branch 5 times, most recently from 18688a6 to 322647c Compare January 28, 2022 22:37
@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation-and-new-resource branch from ede486b to 710f34b Compare January 29, 2022 00:27
Base automatically changed from release/4.x to main January 31, 2022 22:56
@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation-and-new-resource branch from 710f34b to c82ae87 Compare February 1, 2022 02:11
@ewbankkit ewbankkit added this to the v4.0.0 milestone Feb 2, 2022
@YakDriver YakDriver self-assigned this Feb 2, 2022
YakDriver
YakDriver approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

% make testacc TESTS=TestAccS3BucketLifecycleConfiguration_ PKG=s3   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketLifecycleConfiguration_'  -timeout 180m
--- PASS: TestAccS3BucketLifecycleConfiguration_disappears (149.80s)
--- PASS: TestAccS3BucketLifecycleConfiguration_basic (151.39s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Prefix (151.47s)
--- PASS: TestAccS3BucketLifecycleConfiguration_NonCurrentVersionTransition (152.43s)
--- PASS: TestAccS3BucketLifecycleConfiguration_NonCurrentVersionExpiration (152.61s)
--- PASS: TestAccS3BucketLifecycleConfiguration_MultipleRules (152.68s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_EmptyBlock (152.81s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_ExpireMarkerOnly (173.95s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload (174.09s)
--- PASS: TestAccS3BucketLifecycleConfiguration_DisableRule (191.74s)
--- PASS: TestAccS3BucketLifecycleConfiguration_update (193.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	194.894s

@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation-and-new-resource branch 2 times, most recently from 5a5959b to cddb26a Compare February 3, 2022 06:53
@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation-and-new-resource branch from 660b20a to f470b8c Compare February 3, 2022 14:39
@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation-and-new-resource branch from f470b8c to 00430af Compare February 3, 2022 15:09
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 3, 2022

Output of acceptance tests after updates:

--- PASS: TestAccS3BucketLifecycleConfiguration_disappears (151.69s)
--- PASS: TestAccS3BucketLifecycleConfiguration_NonCurrentVersionTransition (154.93s)
--- PASS: TestAccS3BucketLifecycleConfiguration_MultipleRules (155.11s)
--- PASS: TestAccS3BucketLifecycleConfiguration_basic (156.70s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_EmptyBlock (156.72s)
--- PASS: TestAccS3BucketLifecycleConfiguration_NonCurrentVersionExpiration (156.74s)
--- PASS: TestAccS3BucketLifecycleConfiguration_Prefix (156.85s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload (182.25s)
--- PASS: TestAccS3BucketLifecycleConfiguration_RuleExpiration_ExpireMarkerOnly (182.28s)
--- PASS: TestAccS3BucketLifecycleConfiguration_FilterWithPrefix (182.52s)
--- PASS: TestAccS3BucketLifecycleConfiguration_DisableRule (205.04s)
``

@anGie44 anGie44 force-pushed the f-s3-bucket-lifecycle-rule-deprecation-and-new-resource branch from d0e51cd to dd85b34 Compare February 3, 2022 17:31
@anGie44 anGie44 merged commit d8640c1 into main Feb 3, 2022
@anGie44 anGie44 deleted the f-s3-bucket-lifecycle-rule-deprecation-and-new-resource branch February 3, 2022 18:01
github-actions bot pushed a commit that referenced this pull request Feb 3, 2022
Update CHANGELOG.md for #22579
b0cc927
@gdavison gdavison mentioned this pull request Feb 4, 2022
Closed
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
3 participants
@anGie44 @YakDriver @ewbankkit