Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket_logging: new resource #22608

Merged
merged 3 commits into from
Feb 3, 2022
Merged

r/s3_bucket_logging: new resource #22608

merged 3 commits into from
Feb 3, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 15, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4418
Relates #20433

Output from acceptance testing:

--- PASS: TestAccS3BucketLogging_TargetGrantByGroup (262.51s)
--- PASS: TestAccS3BucketLogging_TargetGrantByID (266.21s)
--- PASS: TestAccS3BucketLogging_basic (104.22s)
--- PASS: TestAccS3BucketLogging_disappears (90.79s)
--- PASS: TestAccS3BucketLogging_update (266.30s)
--- SKIP: TestAccS3BucketLogging_TargetGrantByEmail (0.00s)

--- PASS: TestAccS3Bucket_Basic_acceleration (167.65s)
--- PASS: TestAccS3Bucket_Basic_basic (98.36s)
--- PASS: TestAccS3Bucket_Basic_emptyString (97.70s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (84.19s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (81.59s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (80.24s)
--- PASS: TestAccS3Bucket_Basic_generatedName (97.58s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (101.01s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (92.10s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (164.51s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (75.44s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (99.00s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (211.08s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (171.51s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (105.34s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (88.17s)
--- PASS: TestAccS3Bucket_Manage_objectLock (115.15s)
--- PASS: TestAccS3Bucket_Manage_versioning (183.71s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (98.90s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (98.69s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (197.10s)
--- PASS: TestAccS3Bucket_Replication_basic (251.40s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (74.64s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (156.28s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (156.00s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (192.99s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (191.65s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (244.21s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (100.20s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (155.05s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (129.50s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (153.59s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (147.23s)
--- PASS: TestAccS3Bucket_Security_corsDelete (87.58s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (103.21s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (171.10s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (166.35s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (97.62s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (100.95s)
--- PASS: TestAccS3Bucket_Security_grantToACL (154.13s)
--- PASS: TestAccS3Bucket_Security_logging (102.46s)
--- PASS: TestAccS3Bucket_Security_policy (236.68s)
--- PASS: TestAccS3Bucket_Security_updateACL (167.50s)
--- PASS: TestAccS3Bucket_Security_updateGrant (237.36s)
--- PASS: TestAccS3Bucket_Tags_basic (100.43s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (152.33s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (303.55s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (355.56s)
--- PASS: TestAccS3Bucket_Web_redirect (238.48s)
--- PASS: TestAccS3Bucket_Web_routingRules (168.68s)
--- PASS: TestAccS3Bucket_Web_simple (237.75s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3 Issues and PRs that pertain to the s3 service. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jan 15, 2022
anGie44 added a commit that referenced this pull request Jan 16, 2022
@anGie44
Update CHANGELOG for #22608
627ad14
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 16, 2022
@anGie44 anGie44 changed the base branch from main to release/4.x January 16, 2022 03:39
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@anGie44 anGie44 force-pushed the release/4.x branch 2 times, most recently from 44a00a8 to 5ac8e8c Compare January 26, 2022 18:37
@anGie44 anGie44 force-pushed the f-s3-bucket-logging-resource branch from 627ad14 to bfefb27 Compare January 26, 2022 22:32
@github-actions github-actions bot added the service/elasticache Issues and PRs that pertain to the elasticache service. label Jan 26, 2022
anGie44 added a commit that referenced this pull request Jan 26, 2022
@anGie44
Update CHANGELOG for #22608
daf4b24
@anGie44 anGie44 force-pushed the f-s3-bucket-logging-resource branch 2 times, most recently from daf4b24 to 37ce9d0 Compare January 26, 2022 22:34
@github-actions github-actions bot added service/elasticache Issues and PRs that pertain to the elasticache service. and removed service/elasticache Issues and PRs that pertain to the elasticache service. labels Jan 26, 2022
@anGie44 anGie44 mentioned this pull request Jan 26, 2022
Merged
@anGie44 anGie44 marked this pull request as ready for review January 27, 2022 00:45
@anGie44 anGie44 force-pushed the release/4.x branch 5 times, most recently from 18688a6 to 322647c Compare January 28, 2022 22:37
@anGie44 anGie44 force-pushed the f-s3-bucket-logging-resource branch from 37ce9d0 to 970b7b5 Compare January 29, 2022 01:10
@github-actions github-actions bot removed the service/elasticache Issues and PRs that pertain to the elasticache service. label Jan 29, 2022
Base automatically changed from release/4.x to main January 31, 2022 22:56
@anGie44 anGie44 force-pushed the f-s3-bucket-logging-resource branch from 970b7b5 to 021b940 Compare February 1, 2022 01:50
@ewbankkit ewbankkit added this to the v4.0.0 milestone Feb 2, 2022
@YakDriver YakDriver self-assigned this Feb 2, 2022
YakDriver
YakDriver approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

% make testacc TESTS=TestAccS3BucketLogging_ PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketLogging_'  -timeout 180m
--- SKIP: TestAccS3BucketLogging_TargetGrantByEmail (0.00s)
--- PASS: TestAccS3BucketLogging_disappears (24.38s)
--- PASS: TestAccS3BucketLogging_basic (27.20s)
--- PASS: TestAccS3BucketLogging_TargetGrantByGroup (68.00s)
--- PASS: TestAccS3BucketLogging_TargetGrantByID (72.10s)
--- PASS: TestAccS3BucketLogging_update (74.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	76.238s
% make testacc TESTS='TestAccS3Bucket_Basic_|TestAccS3Bucket_Manage_|TestAccS3Bucket_Replication_|TestAccS3Bucket_Security_|TestAccS3Bucket_Tags_|TestAccS3Bucket_Web_' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3Bucket_Basic_|TestAccS3Bucket_Manage_|TestAccS3Bucket_Replication_|TestAccS3Bucket_Security_|TestAccS3Bucket_Tags_|TestAccS3Bucket_Web_'  -timeout 180m
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (30.39s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (50.00s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (52.11s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (52.86s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (56.02s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (60.27s)
--- PASS: TestAccS3Bucket_Basic_basic (60.63s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (61.37s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (84.62s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (89.06s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (90.41s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (91.39s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (91.45s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (91.79s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (50.65s)
--- PASS: TestAccS3Bucket_Manage_objectLock (103.60s)
--- PASS: TestAccS3Bucket_Security_corsDelete (47.77s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (52.00s)
--- PASS: TestAccS3Bucket_Security_logging (66.47s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (96.06s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (43.22s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (137.91s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (48.88s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (141.19s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (83.85s)
--- PASS: TestAccS3Bucket_Basic_generatedName (45.07s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (91.52s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (126.38s)
--- PASS: TestAccS3Bucket_Manage_versioning (87.91s)
--- PASS: TestAccS3Bucket_Security_grantToACL (75.86s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (46.85s)
--- PASS: TestAccS3Bucket_Security_updateACL (77.45s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (44.64s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (49.80s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (78.41s)
--- PASS: TestAccS3Bucket_Web_simple (119.74s)
--- PASS: TestAccS3Bucket_Basic_acceleration (85.32s)
--- PASS: TestAccS3Bucket_Web_redirect (121.89s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (73.63s)
--- PASS: TestAccS3Bucket_Replication_basic (219.16s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (79.20s)
--- PASS: TestAccS3Bucket_Basic_emptyString (42.07s)
--- PASS: TestAccS3Bucket_Web_routingRules (80.65s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (221.91s)
--- PASS: TestAccS3Bucket_Tags_basic (46.81s)
--- PASS: TestAccS3Bucket_Security_updateGrant (119.73s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (14.86s)
--- PASS: TestAccS3Bucket_Security_policy (120.92s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (260.90s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (118.25s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (162.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	349.229s

@anGie44 anGie44 force-pushed the f-s3-bucket-logging-resource branch from 021b940 to a85f96d Compare February 3, 2022 02:01
@anGie44 anGie44 force-pushed the f-s3-bucket-logging-resource branch from 1646ecd to fe1c94f Compare February 3, 2022 06:47
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 3, 2022

Output of acceptance tests after update:

--- PASS: TestAccS3BucketLogging_disappears (30.39s)
--- PASS: TestAccS3BucketLogging_basic (32.60s)
--- PASS: TestAccS3BucketLogging_TargetGrantByGroup (80.68s)
--- PASS: TestAccS3BucketLogging_TargetGrantByID (84.30s)
--- PASS: TestAccS3BucketLogging_update (86.86s)
--- SKIP: TestAccS3BucketLogging_TargetGrantByEmail (0.00s)

@anGie44 anGie44 merged commit 71ff27a into main Feb 3, 2022
@anGie44 anGie44 deleted the f-s3-bucket-logging-resource branch February 3, 2022 14:22
github-actions bot pushed a commit that referenced this pull request Feb 3, 2022
Update CHANGELOG.md for #22608
0fac181
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anGie44 @YakDriver @ewbankkit