B add filter to iot_thing_indexing_configuration

[Oltier]

Change summary

Update the [Create|Get|Update]IndexingConfiguration requests with a new optional parameter: filter

Change details

AWS has introduced a breaking change, making filter attribute required, when named_shadow_indexing_mode is set to ON.
https://docs.aws.amazon.com/iot/latest/apireference/API_ThingIndexingConfiguration.html
https://awsapichanges.info/archive/changes/0a7be3-iot.html

If filter is missing in the described case above, then the following error message is returned when trying to add a similar configuration:

resource "aws_iot_indexing_configuration" "indexing-config" {
  thing_indexing_configuration {
    thing_indexing_mode              = "REGISTRY_AND_SHADOW"
    thing_connectivity_indexing_mode = "STATUS"
    named_shadow_indexing_mode       = "ON"

    custom_field {
      name = "shadow.name.shadowName.desired.someStringValue"
      type = "String"
    }
  }
}

Error: error updating IoT Indexing Configuration: InvalidRequestException: NamedShadowNames Filter must not be empty for enabling NamedShadowIndexingMode

Closes #27532

Output from acceptance testing:

AWS_PROFILE=default TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIoTIndexingConfiguration_serial'  -timeout 180m
=== RUN   TestAccIoTIndexingConfiguration_serial
=== RUN   TestAccIoTIndexingConfiguration_serial/basic
=== RUN   TestAccIoTIndexingConfiguration_serial/allAttributes
--- PASS: TestAccIoTIndexingConfiguration_serial (51.15s)
    --- PASS: TestAccIoTIndexingConfiguration_serial/basic (27.02s)
    --- PASS: TestAccIoTIndexingConfiguration_serial/allAttributes (24.13s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iot        52.884s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Please review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[icsaba]

@HashiCoop any update on it? what's the ETA?

[tmarlok88]

The functionality is currently broken since aws introduced this change: https://awsapichanges.info/archive/changes/0a7be3-iot.html
named_shadow_indexing_mode cannot be enabled without a filter.

[gergo-schreiner-goto]

Hey,

Can somebody review the PR and merge the changes? @breathingdust

Thanks in advance!

[BernhardRode]

Any news on when this can be merged?

[ewbankkit]

LGTM 🚀.

Before

% make testacc TESTARGS='-run=TestAccIoTIndexingConfiguration_serial' PKG=iot
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20  -run=TestAccIoTIndexingConfiguration_serial -timeout 360m
=== RUN   TestAccIoTIndexingConfiguration_serial
=== PAUSE TestAccIoTIndexingConfiguration_serial
=== CONT  TestAccIoTIndexingConfiguration_serial
=== RUN   TestAccIoTIndexingConfiguration_serial/basic
=== RUN   TestAccIoTIndexingConfiguration_serial/allAttributes
    indexing_configuration_test.go:64: Step 1/2 error: Error running apply: exit status 1
        
        Error: updating IoT Indexing Configuration: InvalidRequestException: NamedShadowNames Filter must not be empty for enabling NamedShadowIndexingMode
        
          with aws_iot_indexing_configuration.test,
          on terraform_plugin_test.tf line 2, in resource "aws_iot_indexing_configuration" "test":
           2: resource "aws_iot_indexing_configuration" "test" {
        
--- FAIL: TestAccIoTIndexingConfiguration_serial (28.95s)
    --- PASS: TestAccIoTIndexingConfiguration_serial/basic (21.73s)
    --- FAIL: TestAccIoTIndexingConfiguration_serial/allAttributes (7.23s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/iot        33.982s
FAIL
make: *** [testacc] Error 1

After

% make testacc TESTARGS='-run=TestAccIoTIndexingConfiguration_serial' PKG=iot
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20  -run=TestAccIoTIndexingConfiguration_serial -timeout 360m
=== RUN   TestAccIoTIndexingConfiguration_serial
=== PAUSE TestAccIoTIndexingConfiguration_serial
=== CONT  TestAccIoTIndexingConfiguration_serial
=== RUN   TestAccIoTIndexingConfiguration_serial/basic
=== RUN   TestAccIoTIndexingConfiguration_serial/allAttributes
--- PASS: TestAccIoTIndexingConfiguration_serial (43.69s)
    --- PASS: TestAccIoTIndexingConfiguration_serial/basic (22.00s)
    --- PASS: TestAccIoTIndexingConfiguration_serial/allAttributes (21.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	49.206s

[ewbankkit]

@Oltier Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.