Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E autoscaling traffic attachment #31527

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
79c0b5b
Using DescribeTraffice sources with context
markoskandylis May 21, 2023
b2efe86
added vpclattice test
markoskandylis May 21, 2023
a68f50f
Tests run Succesfully
markoskandylis May 22, 2023
55bbffa
Made changes after running the tests
markoskandylis May 22, 2023
a75057f
Merge branch 'main' into E-autoscaling-traffic-attachment
markoskandylis May 22, 2023
bcc9d1b
fixed typo in traffic resource resource and added traffic resource te…
markoskandylis May 27, 2023
21c38ac
multiple attachments test
markoskandylis May 28, 2023
2a92761
Added traffic sources to autoscaling group
markoskandylis May 29, 2023
5ede8eb
Merge branch 'hashicorp:main' into E-autoscaling-traffic-attachment
markoskandylis May 29, 2023
c307e6e
Merge branch 'hashicorp:main' into E-autoscaling-traffic-attachment
markoskandylis May 30, 2023
56f0f8d
Update group.go
markoskandylis May 30, 2023
43010e2
Correct CHANGELOG entry file name.
ewbankkit May 30, 2023
06b5e66
Update group_test.go
markoskandylis May 30, 2023
b799e62
r/aws_autoscaling_group: 'traffic_sources' -> 'traffic_source'.
ewbankkit May 30, 2023
7a6c656
Merge commit 'b799e6243cc9374d3a67d3fa08d44782699efe21' into HEAD
ewbankkit May 30, 2023
a115877
Correct source file names.
ewbankkit May 30, 2023
ebb667a
r/aws_autoscaling_traffic_attachment: 'traffic_sources' -> 'traffic_s…
ewbankkit May 30, 2023
fc71f42
Add 'TrafficAttachmentParseResourceID' etc.
ewbankkit May 30, 2023
7077da9
No need to generate paginator for 'DescribeTrafficSources'.
ewbankkit May 30, 2023
4410e80
Use 'slices.Chunks'.
ewbankkit May 30, 2023
4bc3b22
Remove custom Set function for 'tag'.
ewbankkit May 30, 2023
7d01f61
r/aws_autoscaling_group: 'traffic_source' conflicts with 'load_balanc…
ewbankkit May 31, 2023
cc09bed
Explicitly set 'target_group_arns' and 'load_balancers' to '[]' in ce…
ewbankkit May 31, 2023
e968169
r/aws_autoscaling_group: Note how to remove all load balancer or targ…
ewbankkit May 31, 2023
d7d32e3
r/aws_autoscaling_traffic_attachment: Remove 'ignore_changes' from ac…
ewbankkit May 31, 2023
ee314f7
r/aws_autoscaling_attachment: Remove 'ignore_changes' from acceptance…
ewbankkit May 31, 2023
679dc5d
'aws_autoscaling_traffic_attachment' -> 'aws_autoscaling_traffic_sour…
ewbankkit May 31, 2023
09c3a0f
Add 'NOTE on Auto Scaling Groups, Attachments and Traffic Source Atta…
ewbankkit May 31, 2023
15ff3c3
Update 31527.txt
ewbankkit May 31, 2023
74500ad
Fix terrafmt errors.
ewbankkit May 31, 2023
71e270e
d/aws_autoscaling_group: Add 'traffic_source' attribute.
ewbankkit May 31, 2023
f697de2
Merge commit '71e270ef1525dfebbdeba39d8f62b78bfc9ea963' into HEAD
ewbankkit May 31, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .changelog/31527.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
```release-note:new-resource
aws_autoscaling_traffic_source_attachment
```

```release-note:enhancement
resource/aws_autoscaling_group: Add `traffic_source` configuration block
```

```release-note:enhancement
data-source/aws_autoscaling_group: Add `traffic_source` attribute
```

```release-note:note
resource/aws_autoscaling_group: The `load_balancers` and `target_group_arns` attributes have been changed to `Computed`. This means that omitting this argument is interpreted as ignoring any existing load balancer or target group attachments. To remove all load balancer or target group attachments an empty list should be specified.
```
8 changes: 0 additions & 8 deletions internal/service/autoscaling/attachment_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,6 @@ resource "aws_autoscaling_group" "test" {
value = %[1]q
propagate_at_launch = true
}

lifecycle {
ignore_changes = [load_balancers]
}
}
`, rName, elbCount))
}
Expand Down Expand Up @@ -251,10 +247,6 @@ resource "aws_autoscaling_group" "test" {
value = %[1]q
propagate_at_launch = true
}

lifecycle {
ignore_changes = [target_group_arns]
}
}
`, rName, targetGroupCount))
}
Expand Down
8 changes: 8 additions & 0 deletions internal/service/autoscaling/consts.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,11 @@ func PolicyType_Values() []string {
PolicyTypeTargetTrackingScaling,
}
}

const (
TrafficSourceStateAdding = "Adding"
TrafficSourceStateAdded = "Added"
TrafficSourceStateInService = "InService"
TrafficSourceStateRemoving = "Removing"
TrafficSourceStateRemoved = "Removed"
)
Loading