Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E autoscaling traffic source data Source #31652

Conversation

markoskandylis
Copy link
Contributor

@markoskandylis markoskandylis commented May 30, 2023

Description

Add support for the Autoscaling attach-traffic-sources API, this pull requests created the new resource aws_autoscaling_traffic_attachment

Go SDK https://docs.aws.amazon.com/sdk-for-go/api/service/autoscaling/#AutoScaling.AttachTrafficSources
AWS CLI https://docs.aws.amazon.com/cli/latest/reference/autoscaling/attach-traffic-sources.html

Relations

Closes #31287.
Relates #31527.

References

Output from Acceptance Testing

➜  terraform-provider-aws git:(E-autoscaling-traffic-attachment) make testacc TESTARGS='-run=TestAccAutoScalingGroupDataSource_' PKG=autoscaling  ACCTEST_PARALLELISM=4 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 4  -run=TestAccAutoScalingGroupDataSource_ -timeout 180m
=== RUN   TestAccAutoScalingGroupDataSource_basic
=== PAUSE TestAccAutoScalingGroupDataSource_basic
=== RUN   TestAccAutoScalingGroupDataSource_launchTemplate
=== PAUSE TestAccAutoScalingGroupDataSource_launchTemplate
=== RUN   TestAccAutoScalingGroupDataSource_trafficSources
=== PAUSE TestAccAutoScalingGroupDataSource_trafficSources
=== RUN   TestAccAutoScalingGroupDataSource_mixedInstancesPolicy
=== PAUSE TestAccAutoScalingGroupDataSource_mixedInstancesPolicy
=== RUN   TestAccAutoScalingGroupDataSource_warmPool
=== PAUSE TestAccAutoScalingGroupDataSource_warmPool
=== RUN   TestAccAutoScalingGroupDataSource_tags
=== PAUSE TestAccAutoScalingGroupDataSource_tags
=== CONT  TestAccAutoScalingGroupDataSource_basic
=== CONT  TestAccAutoScalingGroupDataSource_mixedInstancesPolicy
=== CONT  TestAccAutoScalingGroupDataSource_tags
=== CONT  TestAccAutoScalingGroupDataSource_trafficSources
--- PASS: TestAccAutoScalingGroupDataSource_mixedInstancesPolicy (23.33s)
=== CONT  TestAccAutoScalingGroupDataSource_warmPool
--- PASS: TestAccAutoScalingGroupDataSource_basic (34.98s)
=== CONT  TestAccAutoScalingGroupDataSource_launchTemplate
--- PASS: TestAccAutoScalingGroupDataSource_tags (35.17s)
--- PASS: TestAccAutoScalingGroupDataSource_trafficSources (37.79s)
--- PASS: TestAccAutoScalingGroupDataSource_launchTemplate (29.34s)
--- PASS: TestAccAutoScalingGroupDataSource_warmPool (358.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        385.668s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. partner Contribution from a partner. needs-triage Waiting for first response or review from a maintainer. labels May 30, 2023
@markoskandylis markoskandylis marked this pull request as draft May 30, 2023 18:04
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/M Managed by automation to categorize the size of a PR. labels May 30, 2023
@markoskandylis markoskandylis marked this pull request as ready for review May 30, 2023 19:14
@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels May 31, 2023
@ewbankkit
Copy link
Contributor

Functionality implemented in #31527.

@ewbankkit ewbankkit closed this Jun 1, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. partner Contribution from a partner. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_autoscaling_traffic_attachment
2 participants