Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CodeBuild flag 'badge_enabled' #3297

Closed
wants to merge 7 commits into from
Closed

Added CodeBuild flag 'badge_enabled' #3297

wants to merge 7 commits into from

Conversation

vpadronblanco
Copy link
Contributor

Closes #2836

  • Added 'badge_enabled' resource property
  • Added 'badge_url' resource property to be visible for attribute referencing
  • Added properties in the documentation
  • Added acceptance test

Test output:
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCodeBuildProject_buildBatchUrlValidation -timeout 120m
=== RUN TestAccAWSCodeBuildProject_buildBatchUrlValidation
--- PASS: TestAccAWSCodeBuildProject_buildBatchUrlValidation (25.30s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 25.341s

@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Feb 8, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. labels Feb 8, 2018
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Feb 13, 2018
@vpadronblanco
Copy link
Contributor Author

I resolved the merge conflict, turns out I did not properly update my branch before committing to master. While merging, I kept all the changes from the upstream repository. But, to make sure everything is in order, I am trying to run the test Brian added called "testAccAWSCodeBuildProjectConfig_sourceAuth". This is the error produced:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCodeBuildProject_sourceAuth -timeout 120m
=== RUN TestAccAWSCodeBuildProject_sourceAuth
--- FAIL: TestAccAWSCodeBuildProject_sourceAuth (6.07s)
testing.go:513: Step 1 error: Error applying: 1 error(s) occurred:

	* aws_codebuild_project.foo: 1 error(s) occurred:
	
	* aws_codebuild_project.foo: [ERROR] Error creating CodeBuild project: InvalidInputException: No Access token found, please visit AWS CodeBuild console to connect to GitHub
		status code: 400, request id: f996a104-110f-11e8-b8bb-8947dbd30aa0
testing.go:573: Error destroying resource! WARNING: Dangling resources
	may exist. The full state and error is shown below.
	
	Error: Check failed: Default error in CodeBuild Test
	
	State: <no state>

FAIL
exit status 1
FAIL github.com/terraform-providers/terraform-provider-aws/aws 6.118s
make: *** [testacc] Error 1

@vpadronblanco
Copy link
Contributor Author

I will close this pull request since I referenced my master branch and I have conflicts with merges from upstream

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flag for build-badge in CodeBuild
2 participants