r/aws_s3_bucket_policy at al.: Migrate to AWS SDK for Go v2

[ewbankkit]

Description

Migrates the aws_s3_bucket_policy resource and data source to AWS SDK for Go v2.
Migrates the aws_s3_bucket_accelerate_configuration resource to AWS SDK for Go v2.
Migrates the aws_s3_bucket_versioning resource to AWS SDK for Go v2.

Relations

Relates #33358.
Relates #33330.
Relates #33304.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3BucketPolicy_\|TestAccS3BucketPolicyDataSource_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketPolicy_\|TestAccS3BucketPolicyDataSource_ -timeout 180m
=== RUN   TestAccS3BucketPolicyDataSource_basic
=== PAUSE TestAccS3BucketPolicyDataSource_basic
=== RUN   TestAccS3BucketPolicy_basic
=== PAUSE TestAccS3BucketPolicy_basic
=== RUN   TestAccS3BucketPolicy_disappears
=== PAUSE TestAccS3BucketPolicy_disappears
=== RUN   TestAccS3BucketPolicy_disappears_bucket
=== PAUSE TestAccS3BucketPolicy_disappears_bucket
=== RUN   TestAccS3BucketPolicy_policyUpdate
=== PAUSE TestAccS3BucketPolicy_policyUpdate
=== RUN   TestAccS3BucketPolicy_IAMRoleOrder_policyDoc
=== PAUSE TestAccS3BucketPolicy_IAMRoleOrder_policyDoc
=== RUN   TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal
=== PAUSE TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal
=== RUN   TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode
=== PAUSE TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode
=== RUN   TestAccS3BucketPolicy_migrate_noChange
=== PAUSE TestAccS3BucketPolicy_migrate_noChange
=== RUN   TestAccS3BucketPolicy_migrate_withChange
=== PAUSE TestAccS3BucketPolicy_migrate_withChange
=== CONT  TestAccS3BucketPolicyDataSource_basic
=== CONT  TestAccS3BucketPolicy_IAMRoleOrder_policyDoc
--- PASS: TestAccS3BucketPolicyDataSource_basic (27.10s)
=== CONT  TestAccS3BucketPolicy_migrate_noChange
--- PASS: TestAccS3BucketPolicy_migrate_noChange (45.30s)
=== CONT  TestAccS3BucketPolicy_migrate_withChange
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDoc (76.39s)
=== CONT  TestAccS3BucketPolicy_disappears_bucket
--- PASS: TestAccS3BucketPolicy_disappears_bucket (22.34s)
=== CONT  TestAccS3BucketPolicy_policyUpdate
--- PASS: TestAccS3BucketPolicy_migrate_withChange (44.70s)
=== CONT  TestAccS3BucketPolicy_disappears
--- PASS: TestAccS3BucketPolicy_disappears (25.30s)
=== CONT  TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode
--- PASS: TestAccS3BucketPolicy_policyUpdate (48.35s)
=== CONT  TestAccS3BucketPolicy_basic
--- PASS: TestAccS3BucketPolicy_basic (28.43s)
=== CONT  TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal (77.07s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode (127.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	275.448s

% make testacc TESTARGS='-run=TestAccS3Bucket_Basic_forceDestroy' PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3  -run=TestAccS3Bucket_Basic_forceDestroy -timeout 180m
=== RUN   TestAccS3Bucket_Basic_forceDestroy
=== PAUSE TestAccS3Bucket_Basic_forceDestroy
=== RUN   TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
=== PAUSE TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
=== RUN   TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== PAUSE TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== CONT  TestAccS3Bucket_Basic_forceDestroy
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled
=== CONT  TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (28.36s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (28.45s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (31.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	36.486s

%  make testacc TESTARGS='-run=TestAccS3BucketAccelerateConfiguration_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketAccelerateConfiguration_ -timeout 180m
=== RUN   TestAccS3BucketAccelerateConfiguration_basic
=== PAUSE TestAccS3BucketAccelerateConfiguration_basic
=== RUN   TestAccS3BucketAccelerateConfiguration_update
=== PAUSE TestAccS3BucketAccelerateConfiguration_update
=== RUN   TestAccS3BucketAccelerateConfiguration_disappears
=== PAUSE TestAccS3BucketAccelerateConfiguration_disappears
=== RUN   TestAccS3BucketAccelerateConfiguration_migrate_noChange
=== PAUSE TestAccS3BucketAccelerateConfiguration_migrate_noChange
=== RUN   TestAccS3BucketAccelerateConfiguration_migrate_withChange
=== PAUSE TestAccS3BucketAccelerateConfiguration_migrate_withChange
=== CONT  TestAccS3BucketAccelerateConfiguration_basic
=== CONT  TestAccS3BucketAccelerateConfiguration_migrate_noChange
--- PASS: TestAccS3BucketAccelerateConfiguration_basic (32.05s)
=== CONT  TestAccS3BucketAccelerateConfiguration_disappears
--- PASS: TestAccS3BucketAccelerateConfiguration_migrate_noChange (49.31s)
=== CONT  TestAccS3BucketAccelerateConfiguration_update
--- PASS: TestAccS3BucketAccelerateConfiguration_disappears (30.94s)
=== CONT  TestAccS3BucketAccelerateConfiguration_migrate_withChange
--- PASS: TestAccS3BucketAccelerateConfiguration_update (52.86s)
--- PASS: TestAccS3BucketAccelerateConfiguration_migrate_withChange (47.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	119.225s

% make testacc TESTARGS='-run=TestAccS3BucketVersioning_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketVersioning_ -timeout 180m
=== RUN   TestAccS3BucketVersioning_basic
=== PAUSE TestAccS3BucketVersioning_basic
=== RUN   TestAccS3BucketVersioning_disappears
=== PAUSE TestAccS3BucketVersioning_disappears
=== RUN   TestAccS3BucketVersioning_disappears_bucket
=== PAUSE TestAccS3BucketVersioning_disappears_bucket
=== RUN   TestAccS3BucketVersioning_update
=== PAUSE TestAccS3BucketVersioning_update
=== RUN   TestAccS3BucketVersioning_MFADelete
=== PAUSE TestAccS3BucketVersioning_MFADelete
=== RUN   TestAccS3BucketVersioning_migrate_versioningDisabledNoChange
=== PAUSE TestAccS3BucketVersioning_migrate_versioningDisabledNoChange
=== RUN   TestAccS3BucketVersioning_migrate_versioningDisabledWithChange
=== PAUSE TestAccS3BucketVersioning_migrate_versioningDisabledWithChange
=== RUN   TestAccS3BucketVersioning_migrate_versioningEnabledNoChange
=== PAUSE TestAccS3BucketVersioning_migrate_versioningEnabledNoChange
=== RUN   TestAccS3BucketVersioning_migrate_versioningEnabledWithChange
=== PAUSE TestAccS3BucketVersioning_migrate_versioningEnabledWithChange
=== RUN   TestAccS3BucketVersioning_migrate_mfaDeleteNoChange
=== PAUSE TestAccS3BucketVersioning_migrate_mfaDeleteNoChange
=== RUN   TestAccS3BucketVersioning_Status_disabled
=== PAUSE TestAccS3BucketVersioning_Status_disabled
=== RUN   TestAccS3BucketVersioning_Status_disabledToEnabled
=== PAUSE TestAccS3BucketVersioning_Status_disabledToEnabled
=== RUN   TestAccS3BucketVersioning_Status_disabledToSuspended
=== PAUSE TestAccS3BucketVersioning_Status_disabledToSuspended
=== RUN   TestAccS3BucketVersioning_Status_enabledToDisabled
=== PAUSE TestAccS3BucketVersioning_Status_enabledToDisabled
=== RUN   TestAccS3BucketVersioning_Status_suspendedToDisabled
=== PAUSE TestAccS3BucketVersioning_Status_suspendedToDisabled
=== CONT  TestAccS3BucketVersioning_basic
=== CONT  TestAccS3BucketVersioning_migrate_versioningEnabledWithChange
--- PASS: TestAccS3BucketVersioning_basic (33.00s)
=== CONT  TestAccS3BucketVersioning_Status_disabledToSuspended
--- PASS: TestAccS3BucketVersioning_migrate_versioningEnabledWithChange (46.49s)
=== CONT  TestAccS3BucketVersioning_Status_suspendedToDisabled
--- PASS: TestAccS3BucketVersioning_Status_suspendedToDisabled (33.02s)
=== CONT  TestAccS3BucketVersioning_Status_enabledToDisabled
--- PASS: TestAccS3BucketVersioning_Status_disabledToSuspended (56.04s)
=== CONT  TestAccS3BucketVersioning_MFADelete
--- PASS: TestAccS3BucketVersioning_Status_enabledToDisabled (37.30s)
=== CONT  TestAccS3BucketVersioning_migrate_versioningEnabledNoChange
--- PASS: TestAccS3BucketVersioning_MFADelete (37.68s)
=== CONT  TestAccS3BucketVersioning_migrate_versioningDisabledWithChange
--- PASS: TestAccS3BucketVersioning_migrate_versioningEnabledNoChange (52.25s)
=== CONT  TestAccS3BucketVersioning_migrate_versioningDisabledNoChange
--- PASS: TestAccS3BucketVersioning_migrate_versioningDisabledWithChange (52.21s)
=== CONT  TestAccS3BucketVersioning_Status_disabled
--- PASS: TestAccS3BucketVersioning_Status_disabled (33.64s)
=== CONT  TestAccS3BucketVersioning_Status_disabledToEnabled
--- PASS: TestAccS3BucketVersioning_migrate_versioningDisabledNoChange (48.47s)
=== CONT  TestAccS3BucketVersioning_migrate_mfaDeleteNoChange
--- PASS: TestAccS3BucketVersioning_migrate_mfaDeleteNoChange (48.18s)
=== CONT  TestAccS3BucketVersioning_disappears_bucket
--- PASS: TestAccS3BucketVersioning_Status_disabledToEnabled (58.76s)
=== CONT  TestAccS3BucketVersioning_update
--- PASS: TestAccS3BucketVersioning_disappears_bucket (29.52s)
=== CONT  TestAccS3BucketVersioning_disappears
--- PASS: TestAccS3BucketVersioning_disappears (31.54s)
--- PASS: TestAccS3BucketVersioning_update (88.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	364.952s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🪣 🚀

% make testacc TESTARGS='-run=TestAccS3BucketPolicy_\|TestAccS3BucketPolicyDataSource_' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3BucketPolicy_\|TestAccS3BucketPolicyDataSource_ -timeout 180m

--- PASS: TestAccS3BucketPolicy_disappears_bucket (27.67s)
--- PASS: TestAccS3BucketPolicy_disappears (30.17s)
--- PASS: TestAccS3BucketPolicyDataSource_basic (30.28s)
--- PASS: TestAccS3BucketPolicy_basic (33.54s)
--- PASS: TestAccS3BucketPolicy_migrate_noChange (47.30s)
--- PASS: TestAccS3BucketPolicy_migrate_withChange (47.58s)
--- PASS: TestAccS3BucketPolicy_policyUpdate (49.58s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDoc (72.12s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal (75.92s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode (130.15s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 133.391s

% make testacc TESTARGS='-run=TestAccS3Bucket_Basic_forceDestroy' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3Bucket_Basic_forceDestroy -timeout 180m

--- PASS: TestAccS3Bucket_Basic_forceDestroy (21.93s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (21.93s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (25.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 28.224s

% make testacc TESTARGS='-run=TestAccS3BucketAccelerateConfiguration_' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20  -run=TestAccS3BucketAccelerateConfiguration_ -timeout 180m

--- PASS: TestAccS3BucketAccelerateConfiguration_disappears (25.88s)
--- PASS: TestAccS3BucketAccelerateConfiguration_basic (28.64s)
--- PASS: TestAccS3BucketAccelerateConfiguration_migrate_noChange (40.89s)
--- PASS: TestAccS3BucketAccelerateConfiguration_migrate_withChange (41.49s)
--- PASS: TestAccS3BucketAccelerateConfiguration_update (44.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 47.530s

[github-actions]

This functionality has been released in v5.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.