internal/framework/flex: generic set/list of string value flatteners

[jar-b]

Description

This will allow the FlattenFrameworkStringValue[List|Set]* functions to be used with lists and sets of AWS enum types, implemented as custom string types.

Relations

Relates #34148

References

Output from Acceptance Testing

% go test -count=1 ./internal/framework/flex/...
ok      github.com/hashicorp/terraform-provider-aws/internal/framework/flex     0.223s

The regions data source utilizes the flex.FlattenFrameworkStringValueSetLegacy function.

% make testacc PKG=meta TESTS=TestAccMetaRegionsDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/meta/... -v -count 1 -parallel 20 -run='TestAccMetaRegionsDataSource_'  -timeout 360m

--- PASS: TestAccMetaRegionsDataSource_allRegions (33.47s)
--- PASS: TestAccMetaRegionsDataSource_filter (33.64s)
--- PASS: TestAccMetaRegionsDataSource_basic (33.75s)
--- PASS: TestAccMetaRegionsDataSource_nonExistentRegion (33.90s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/meta       37.214s

These data sources uncovered the need for handling sets of custom types:

% make testacc PKG=bedrock TESTS=TestAccBedrockFoundationModel
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run='TestAccBedrockFoundationModel'  -timeout 360m

--- PASS: TestAccBedrockFoundationModelsDataSource_byOutputModality (35.61s)
--- PASS: TestAccBedrockFoundationModelsDataSource_basic (35.89s)
--- PASS: TestAccBedrockFoundationModelsDataSource_byCustomizationType (36.09s)
--- PASS: TestAccBedrockFoundationModelsDataSource_byInferenceType (36.12s)
--- PASS: TestAccBedrockFoundationModelDataSource_basic (49.35s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrock    52.612s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

Can also extend (in a future PR) to slices of other types.

[ewbankkit]

LGTM 🚀.

[github-actions]

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.