Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_space - add args #35116

Merged
merged 11 commits into from
Feb 13, 2024
Merged

r/sagemaker_space - add args #35116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7b901bf
add space new args
DrFaust92 Dec 11, 2023
5047c20
fmt + focs
DrFaust92 Jan 6, 2024
8a954c3
fmt
DrFaust92 Jan 20, 2024
4e488ef
add more args + fix test
DrFaust92 Jan 20, 2024
133254e
changelog
DrFaust92 Jan 20, 2024
f46b1f2
tests + requiredwith
DrFaust92 Jan 20, 2024
8d48bcc
tests + requiredwith
DrFaust92 Jan 20, 2024
d109698
fixes + tests
DrFaust92 Jan 21, 2024
e95aca9
fmt
DrFaust92 Jan 21, 2024
90060ca
fmt
DrFaust92 Jan 21, 2024
2679494
Merge branch 'main' into HEAD
ewbankkit Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/35116.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/aws_sagemaker_space: Add `ownership_settings`, `space_sharing_settings`, `space_settings.app_type`, `space_settings.code_editor_app_settings`, `space_settings.custom_file_system`, `space_settings.jupyter_lab_app_settings`, and `space_settings.space_storage_settings` arguments
```
4 changes: 4 additions & 0 deletions internal/service/sagemaker/sagemaker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ func TestAccSageMaker_serial(t *testing.T) {
"kernelGatewayAppSettings_lifecycleConfig": testAccSpace_kernelGatewayAppSettings_lifecycleconfig,
"kernelGatewayAppSettings_imageConfig": testAccSpace_kernelGatewayAppSettings_imageconfig,
"jupyterServerAppSettings": testAccSpace_jupyterServerAppSettings,
"jupyterLabAppSettings": testAccSpace_jupyterLabAppSettings,
"codeEditorAppSettings": testAccSpace_codeEditorAppSettings,
"storageSettings": testAccSpace_storageSettings,
"customFileSystem": testAccSpace_customFileSystem,
},
"UserProfile": {
"basic": testAccUserProfile_basic,
Expand Down
Loading
Loading