-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
f/aws_codepipeline add support for triggers #35973
f/aws_codepipeline add support for triggers #35973
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCodePipeline_' PKG=codepipeline ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codepipeline/... -v -count 1 -parallel 3 -run=TestAccCodePipeline_ -timeout 360m
=== RUN TestAccCodePipeline_basic
=== PAUSE TestAccCodePipeline_basic
=== RUN TestAccCodePipeline_disappears
=== PAUSE TestAccCodePipeline_disappears
=== RUN TestAccCodePipeline_emptyStageArtifacts
=== PAUSE TestAccCodePipeline_emptyStageArtifacts
=== RUN TestAccCodePipeline_deployWithServiceRole
=== PAUSE TestAccCodePipeline_deployWithServiceRole
=== RUN TestAccCodePipeline_tags
=== PAUSE TestAccCodePipeline_tags
=== RUN TestAccCodePipeline_MultiRegion_basic
=== PAUSE TestAccCodePipeline_MultiRegion_basic
=== RUN TestAccCodePipeline_MultiRegion_update
=== PAUSE TestAccCodePipeline_MultiRegion_update
=== RUN TestAccCodePipeline_MultiRegion_convertSingleRegion
=== PAUSE TestAccCodePipeline_MultiRegion_convertSingleRegion
=== RUN TestAccCodePipeline_withNamespace
=== PAUSE TestAccCodePipeline_withNamespace
=== RUN TestAccCodePipeline_withGitHubV1SourceAction
codepipeline_test.go:479: Environment variable GITHUB_TOKEN is not set, skipping test
--- SKIP: TestAccCodePipeline_withGitHubV1SourceAction (0.00s)
=== RUN TestAccCodePipeline_ecr
=== PAUSE TestAccCodePipeline_ecr
=== RUN TestAccCodePipeline_pipelinetype
=== PAUSE TestAccCodePipeline_pipelinetype
=== CONT TestAccCodePipeline_basic
=== CONT TestAccCodePipeline_ecr
=== CONT TestAccCodePipeline_MultiRegion_update
--- PASS: TestAccCodePipeline_ecr (36.72s)
=== CONT TestAccCodePipeline_withNamespace
--- PASS: TestAccCodePipeline_basic (61.59s)
=== CONT TestAccCodePipeline_MultiRegion_convertSingleRegion
--- PASS: TestAccCodePipeline_withNamespace (32.84s)
=== CONT TestAccCodePipeline_deployWithServiceRole
--- PASS: TestAccCodePipeline_MultiRegion_update (73.33s)
=== CONT TestAccCodePipeline_MultiRegion_basic
--- PASS: TestAccCodePipeline_deployWithServiceRole (37.06s)
=== CONT TestAccCodePipeline_tags
--- PASS: TestAccCodePipeline_MultiRegion_basic (41.62s)
=== CONT TestAccCodePipeline_pipelinetype
--- PASS: TestAccCodePipeline_MultiRegion_convertSingleRegion (88.03s)
=== CONT TestAccCodePipeline_emptyStageArtifacts
--- PASS: TestAccCodePipeline_tags (69.50s)
=== CONT TestAccCodePipeline_disappears
--- PASS: TestAccCodePipeline_emptyStageArtifacts (36.18s)
--- PASS: TestAccCodePipeline_disappears (31.10s)
--- PASS: TestAccCodePipeline_pipelinetype (120.62s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline 251.145s
@neruneruo Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
resource/aws_codepipeline: Add trigger attribute
Description
Add attribute: trigger
Relations
Closes #35475
References
Announcement
Documentation
API Reference
CLI Command Reference
Output from Acceptance Testing