-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_devopsguru_notification_channel: fix filters persistent diff #36804
Conversation
Community NoteVoting for Prioritization
For Submitters
|
This changes the type of the `filters.message_types` and `filters.severities` arguments to `TypeSet`, preventing persistent differences when the AWS API returns elements in a different order than they were sent. ```console % make testacc PKG=devopsguru TESTS=TestAccDevOpsGuru_serial/NotificationChannel/ ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/devopsguru/... -v -count 1 -parallel 20 -run='TestAccDevOpsGuru_serial/NotificationChannel/' -timeout 360m --- PASS: TestAccDevOpsGuru_serial (48.85s) --- PASS: TestAccDevOpsGuru_serial/NotificationChannel (37.73s) --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/disappears (12.13s) --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/filters (12.83s) --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/basic (12.77s) --- PASS: TestAccDevOpsGuru_serial/NotificationChannelDataSource (11.12s) --- PASS: TestAccDevOpsGuru_serial/NotificationChannelDataSource/basic (11.12s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/devopsguru 54.578s ```
f6557c3
to
a607f63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
This functionality has been released in v5.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This changes the type of the
filters.message_types
andfilters.severities
arguments toTypeSet
, preventing persistent differences when the AWS API returns elements in a different order than they were sent.Relations
Depends on #36789
Closes #36731
Output from Acceptance Testing