Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable and fix semgrep diags checks for all services #37866

Merged
merged 35 commits into from
Jun 7, 2024
Merged

Enable and fix semgrep diags checks for all services #37866

merged 35 commits into from
Jun 7, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 6, 2024 •
edited
Loading

Description

Enables and fixes semgrep diags checks for all services.

Relations

Closes #37569.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSQSQueuePolicy_' PKG=sqs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/sqs/... -v -count 1 -parallel 3  -run=TestAccSQSQueuePolicy_ -timeout 360m
=== RUN   TestAccSQSQueuePolicy_basic
=== PAUSE TestAccSQSQueuePolicy_basic
=== RUN   TestAccSQSQueuePolicy_disappears
=== PAUSE TestAccSQSQueuePolicy_disappears
=== RUN   TestAccSQSQueuePolicy_Disappears_queue
=== PAUSE TestAccSQSQueuePolicy_Disappears_queue
=== RUN   TestAccSQSQueuePolicy_update
=== PAUSE TestAccSQSQueuePolicy_update
=== CONT  TestAccSQSQueuePolicy_basic
=== CONT  TestAccSQSQueuePolicy_Disappears_queue
=== CONT  TestAccSQSQueuePolicy_update
--- PASS: TestAccSQSQueuePolicy_basic (97.16s)
=== CONT  TestAccSQSQueuePolicy_disappears
--- PASS: TestAccSQSQueuePolicy_Disappears_queue (104.90s)
--- PASS: TestAccSQSQueuePolicy_update (126.83s)
--- PASS: TestAccSQSQueuePolicy_disappears (135.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	237.413s

ewbankkit added 30 commits June 6, 2024 11:14
@ewbankkit
Enable semgrep diags checks for 's' services.
d31ee56
@ewbankkit
Fix semgrep diags checks - s3.
135564f
@ewbankkit
Fix semgrep diags checks - s3control.
d67e278
@ewbankkit
Fix semgrep diags checks - scheduler.
36ee52c
@ewbankkit
Fix semgrep diags checks - schemas.
9a40562
@ewbankkit
Fix semgrep diags checks - securityhub.
cb4966c
@ewbankkit
Fix semgrep diags checks - servicecatalog.
5fcf0ed
@ewbankkit
Fix semgrep diags checks - servicediscovery.
a8d1fbe
@ewbankkit
Fix semgrep diags checks - sesv2.
4c0cac7
@ewbankkit
Fix semgrep diags checks - sfn.
af5deb0
@ewbankkit
Fix semgrep diags checks - sns.
4715960
@ewbankkit
Fix semgrep diags checks - sqs.
4a0110f
@ewbankkit
Fix semgrep diags checks - ssm.
c218273
@ewbankkit
Fix semgrep diags checks - ssmcontacts.
47ef1e1
@ewbankkit
Fix semgrep diags checks - ssmincidents.
839f967
@ewbankkit
Fix semgrep diags checks - swf.
b82ade6
@ewbankkit
Fix semgrep diags checks - synthetics.
0c98a18
@ewbankkit
Enable semgrep diags checks for 'q' and 'r' services.
788d163
@ewbankkit
Fix semgrep diags checks - qldb.
d81f968
@ewbankkit
Fix semgrep diags checks - quicksight.
af9ae26
@ewbankkit
Fix semgrep diags checks - rbin.
7f717a8
@ewbankkit
Fix semgrep diags checks - rds.
84696c5
@ewbankkit
Fix semgrep diags checks - resourcegroups.
b05f846
@ewbankkit
Fix semgrep diags checks - rolesanywhere.
1cbed99
@ewbankkit
Fix semgrep diags checks - route53.
db1b485
@ewbankkit
Fix semgrep diags checks - route53domains.
cda7103
@ewbankkit
Fix semgrep diags checks - route53resolver.
0588696
@ewbankkit
Enable semgrep diags checks for 'p' services.
f062634
@ewbankkit
Enable semgrep diags checks for all services.
6f807c5
@ewbankkit
Fix semgrep diags checks - oam.
76cae47
@github-actions github-actions bot added service/route53domains Issues and PRs that pertain to the route53domains service. service/s3control Issues and PRs that pertain to the s3control service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/securityhub Issues and PRs that pertain to the securityhub service. service/quicksight Issues and PRs that pertain to the quicksight service. service/qldb Issues and PRs that pertain to the qldb service. service/sesv2 Issues and PRs that pertain to the sesv2 service. service/synthetics Issues and PRs that pertain to the synthetics service. linter Pertains to changes to or issues with the various linters. service/schemas Issues and PRs that pertain to the schemas service. service/opensearch Issues and PRs that pertain to the opensearch service. service/rum Issues and PRs that pertain to the rum service. service/ssmincidents Issues and PRs that pertain to the ssmincidents service. service/ssmcontacts Issues and PRs that pertain to the ssmcontacts service. service/rbin Issues and PRs that pertain to the rbin service. service/rolesanywhere Issues and PRs that pertain to the rolesanywhere service. service/scheduler Issues and PRs that pertain to the scheduler service. service/pipes Issues and PRs that pertain to the pipes service. service/oam Issues and PRs that pertain to the oam service. labels Jun 6, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 6, 2024
@ewbankkit ewbankkit added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Jun 6, 2024
@ewbankkit ewbankkit added this to the v5.54.0 milestone Jun 6, 2024
@ewbankkit ewbankkit changed the title [WIP] Enable and fix semgrep diags checks for all services Enable and fix semgrep diags checks for all services Jun 7, 2024
@ewbankkit ewbankkit merged commit 240891a into main Jun 7, 2024
35 checks passed
@ewbankkit ewbankkit deleted the td-return-diags-s-etc branch June 7, 2024 12:54
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 14, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. service/oam Issues and PRs that pertain to the oam service. service/opensearch Issues and PRs that pertain to the opensearch service. service/opsworks Issues and PRs that pertain to the opsworks service. service/organizations Issues and PRs that pertain to the organizations service. service/pipes Issues and PRs that pertain to the pipes service. service/qldb Issues and PRs that pertain to the qldb service. service/quicksight Issues and PRs that pertain to the quicksight service. service/rbin Issues and PRs that pertain to the rbin service. service/rds Issues and PRs that pertain to the rds service. service/resourcegroups Issues and PRs that pertain to the resourcegroups service. service/rolesanywhere Issues and PRs that pertain to the rolesanywhere service. service/route53domains Issues and PRs that pertain to the route53domains service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/route53 Issues and PRs that pertain to the route53 service. service/rum Issues and PRs that pertain to the rum service. service/s3control Issues and PRs that pertain to the s3control service. service/s3 Issues and PRs that pertain to the s3 service. service/scheduler Issues and PRs that pertain to the scheduler service. service/schemas Issues and PRs that pertain to the schemas service. service/securityhub Issues and PRs that pertain to the securityhub service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/sesv2 Issues and PRs that pertain to the sesv2 service. service/sfn Issues and PRs that pertain to the sfn service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. service/ssm Issues and PRs that pertain to the ssm service. service/ssmcontacts Issues and PRs that pertain to the ssmcontacts service. service/ssmincidents Issues and PRs that pertain to the ssmincidents service. service/swf Issues and PRs that pertain to the swf service. service/synthetics Issues and PRs that pertain to the synthetics service. size/XL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v5.54.0
Development

Successfully merging this pull request may close these issues.

Tech debt: Complete "Collect diags instead of returning directly"
1 participant
@ewbankkit