Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase endpointInServiceTimeout to 20 min #39093

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Aug 30, 2024

Description

This PR is to increase the wait timeout for a SageMaker endpoint to become InService from 10 min to 20 min for the aws_sagemaker_endpoint resource.

Relations

Closes #39040

References

n/a

Output from Acceptance Testing

$ make testacc TESTS="TestAccSageMakerEndpoint_" PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerEndpoint_'  -timeout 360m
=== RUN   TestAccSageMakerEndpoint_basic
=== PAUSE TestAccSageMakerEndpoint_basic
=== RUN   TestAccSageMakerEndpoint_endpointName
=== PAUSE TestAccSageMakerEndpoint_endpointName
=== RUN   TestAccSageMakerEndpoint_tags
=== PAUSE TestAccSageMakerEndpoint_tags
=== RUN   TestAccSageMakerEndpoint_deploymentConfig
=== PAUSE TestAccSageMakerEndpoint_deploymentConfig
=== RUN   TestAccSageMakerEndpoint_deploymentConfig_blueGreen
=== PAUSE TestAccSageMakerEndpoint_deploymentConfig_blueGreen
=== RUN   TestAccSageMakerEndpoint_deploymentConfig_rolling
=== PAUSE TestAccSageMakerEndpoint_deploymentConfig_rolling
=== RUN   TestAccSageMakerEndpoint_disappears
=== PAUSE TestAccSageMakerEndpoint_disappears
=== CONT  TestAccSageMakerEndpoint_basic
=== CONT  TestAccSageMakerEndpoint_deploymentConfig_blueGreen
=== CONT  TestAccSageMakerEndpoint_tags
=== CONT  TestAccSageMakerEndpoint_deploymentConfig_rolling
=== CONT  TestAccSageMakerEndpoint_deploymentConfig
=== CONT  TestAccSageMakerEndpoint_endpointName
=== CONT  TestAccSageMakerEndpoint_disappears
--- PASS: TestAccSageMakerEndpoint_basic (193.10s)
--- PASS: TestAccSageMakerEndpoint_deploymentConfig_rolling (196.20s)
--- PASS: TestAccSageMakerEndpoint_deploymentConfig (198.22s)
--- PASS: TestAccSageMakerEndpoint_deploymentConfig_blueGreen (201.12s)
--- PASS: TestAccSageMakerEndpoint_tags (226.51s)
--- PASS: TestAccSageMakerEndpoint_disappears (305.60s)
--- PASS: TestAccSageMakerEndpoint_endpointName (439.28s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  439.521s

$

@acwwat acwwat requested a review from a team as a code owner August 30, 2024 03:27
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/sagemaker Issues and PRs that pertain to the sagemaker service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Aug 30, 2024
@acwwat acwwat force-pushed the b-aws_sagemaker_endpoint-increase_in_service_wait_timeout branch from 040bd7c to 2bf0da1 Compare August 30, 2024 03:35
@acwwat acwwat changed the title [WIP] fix: Increase endpointInServiceTimeout to 20 min fix: Increase endpointInServiceTimeout to 20 min Aug 30, 2024
@acwwat
Copy link
Contributor Author

acwwat commented Aug 30, 2024

Just spotted that #39090 was submitted few hours before this one.

@justinretzolk justinretzolk added timeouts Pertains to timeout increases. bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 30, 2024
@ewbankkit ewbankkit self-assigned this Sep 3, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 3, 2024
@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 👏.
As you noticed, this was address in #39090. Closing this PR as a duplicate.

@ewbankkit ewbankkit closed this Sep 3, 2024
Copy link

github-actions bot commented Oct 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. external-maintainer Contribution from a trusted external contributor. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/sagemaker Issues and PRs that pertain to the sagemaker service. timeouts Pertains to timeout increases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_sagemaker_endpoint maximum_execution_timeout_in_seconds value is ignored
4 participants