Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go 1.23 slices.Chunk as a replacement for internal/slices.Chunks #39144

Merged
merged 10 commits into from
Sep 5, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 4, 2024

Description

Use the new Go 1.23 slices.Chunk function as a replacement for our internal/slices.Chunks.

Relations

Relates #38999.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccLakeFormation_serial/^LFTags$$' PKG=lakeformation
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/lakeformation/... -v -count 1 -parallel 20  -run=TestAccLakeFormation_serial/^LFTags$ -timeout 360m
=== RUN   TestAccLakeFormation_serial
=== PAUSE TestAccLakeFormation_serial
=== CONT  TestAccLakeFormation_serial
=== RUN   TestAccLakeFormation_serial/LFTags
=== RUN   TestAccLakeFormation_serial/LFTags/values
=== RUN   TestAccLakeFormation_serial/LFTags/valuesOverFifty
=== RUN   TestAccLakeFormation_serial/LFTags/basic
=== RUN   TestAccLakeFormation_serial/LFTags/disappears
=== RUN   TestAccLakeFormation_serial/LFTags/tagKeyComplex
--- PASS: TestAccLakeFormation_serial (78.55s)
    --- PASS: TestAccLakeFormation_serial/LFTags (78.55s)
        --- PASS: TestAccLakeFormation_serial/LFTags/values (20.60s)
        --- PASS: TestAccLakeFormation_serial/LFTags/valuesOverFifty (25.66s)
        --- PASS: TestAccLakeFormation_serial/LFTags/basic (12.05s)
        --- PASS: TestAccLakeFormation_serial/LFTags/disappears (10.33s)
        --- PASS: TestAccLakeFormation_serial/LFTags/tagKeyComplex (9.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	83.418s
% make testacc TESTARGS='-run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withTrafficSourcesELBs\|TestAccAutoScalingGroup_loadBalancers\|TestAccAutoScalingGroup_targetGroups' PKG=autoscaling ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withTrafficSourcesELBs\|TestAccAutoScalingGroup_loadBalancers\|TestAccAutoScalingGroup_targetGroups -timeout 360m
=== RUN   TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== RUN   TestAccAutoScalingGroup_withTrafficSourcesELBs
=== PAUSE TestAccAutoScalingGroup_withTrafficSourcesELBs
=== RUN   TestAccAutoScalingGroup_loadBalancers
=== PAUSE TestAccAutoScalingGroup_loadBalancers
=== RUN   TestAccAutoScalingGroup_targetGroups
=== PAUSE TestAccAutoScalingGroup_targetGroups
=== CONT  TestAccAutoScalingGroup_basic
=== CONT  TestAccAutoScalingGroup_loadBalancers
--- PASS: TestAccAutoScalingGroup_basic (66.57s)
=== CONT  TestAccAutoScalingGroup_targetGroups
--- PASS: TestAccAutoScalingGroup_targetGroups (167.58s)
=== CONT  TestAccAutoScalingGroup_withTrafficSourcesELBs
--- PASS: TestAccAutoScalingGroup_loadBalancers (329.49s)
--- PASS: TestAccAutoScalingGroup_withTrafficSourcesELBs (238.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	477.936s

@ewbankkit ewbankkit requested a review from a team as a code owner September 4, 2024 19:02
Copy link

github-actions bot commented Sep 4, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53 Issues and PRs that pertain to the route53 service. service/rds Issues and PRs that pertain to the rds service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ssm Issues and PRs that pertain to the ssm service. service/neptune Issues and PRs that pertain to the neptune service. service/connect Issues and PRs that pertain to the connect service. service/kafka Issues and PRs that pertain to the kafka service. service/docdb Issues and PRs that pertain to the docdb service. service/lakeformation Issues and PRs that pertain to the lakeformation service. labels Sep 4, 2024
@ewbankkit ewbankkit removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53 Issues and PRs that pertain to the route53 service. service/rds Issues and PRs that pertain to the rds service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ssm Issues and PRs that pertain to the ssm service. service/neptune Issues and PRs that pertain to the neptune service. service/connect Issues and PRs that pertain to the connect service. service/kafka Issues and PRs that pertain to the kafka service. labels Sep 4, 2024
@ewbankkit ewbankkit added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed service/docdb Issues and PRs that pertain to the docdb service. service/lakeformation Issues and PRs that pertain to the lakeformation service. labels Sep 4, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 4, 2024
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@ewbankkit ewbankkit changed the title [WIP] Use Go 1.23 slices.Chunk as a replacement for internal/slices.Chunks Use Go 1.23 slices.Chunk as a replacement for internal/slices.Chunks Sep 4, 2024
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53 Issues and PRs that pertain to the route53 service. service/rds Issues and PRs that pertain to the rds service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ssm Issues and PRs that pertain to the ssm service. service/neptune Issues and PRs that pertain to the neptune service. service/connect Issues and PRs that pertain to the connect service. service/kafka Issues and PRs that pertain to the kafka service. service/docdb Issues and PRs that pertain to the docdb service. service/lakeformation Issues and PRs that pertain to the lakeformation service. labels Sep 4, 2024
@ewbankkit ewbankkit merged commit 367b75c into main Sep 5, 2024
59 checks passed
@ewbankkit ewbankkit deleted the td-slices.Chunk branch September 5, 2024 17:20
@github-actions github-actions bot added this to the v5.66.0 milestone Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

This functionality has been released in v5.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 5, 2024
Copy link

github-actions bot commented Oct 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/autoscaling Issues and PRs that pertain to the autoscaling service. service/connect Issues and PRs that pertain to the connect service. service/docdb Issues and PRs that pertain to the docdb service. service/kafka Issues and PRs that pertain to the kafka service. service/lakeformation Issues and PRs that pertain to the lakeformation service. service/neptune Issues and PRs that pertain to the neptune service. service/rds Issues and PRs that pertain to the rds service. service/route53 Issues and PRs that pertain to the route53 service. service/ssm Issues and PRs that pertain to the ssm service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants