Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple SASL/SCRAM associations for MSK clusters #40217

Closed
wants to merge 3 commits into from

Conversation

mmehrten
Copy link

Description

Many MSK users want to create SASL/SCRAM secrets in multiple modules and associate them with the cluster. Today, the aws_msk_scram_secret_association resource is effectively a singleton and blocks this type of use case.

This PR adds logic to manage configured state for multiple aws_msk_scram_secret_association objects separately.

Relations

Closes #16791

Output from Acceptance Testing

TF_ACC=1 go1.23.2 test ./internal/service/kafka/... -v -count 1 -parallel 20 -run='TestAccKafkaScramSecretAssociation_update'  -timeout 360m
=== RUN   TestAccKafkaScramSecretAssociation_update
=== PAUSE TestAccKafkaScramSecretAssociation_update
=== RUN   TestAccKafkaScramSecretAssociation_update_multiple_associations
=== PAUSE TestAccKafkaScramSecretAssociation_update_multiple_associations
=== CONT  TestAccKafkaScramSecretAssociation_update
=== CONT  TestAccKafkaScramSecretAssociation_update_multiple_associations
--- PASS: TestAccKafkaScramSecretAssociation_update_multiple_associations (2293.89s)
--- PASS: TestAccKafkaScramSecretAssociation_update (2297.66s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kafka      2303.569s

@mmehrten mmehrten requested a review from a team as a code owner November 20, 2024 20:14
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/kafka Issues and PRs that pertain to the kafka service. needs-triage Waiting for first response or review from a maintainer. labels Nov 20, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @mmehrten 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 10, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_msk_scram_secret_association overrides/removes existing secret associations
2 participants