Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/rds_cluster: add ability to promotion read replica cluster to standalone #40337

Merged
merged 10 commits into from
Dec 3, 2024
Merged

r/rds_cluster: add ability to promotion read replica cluster to standalone #40337

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d56b9a2
aws_rds_cluster: add ability to promote replica cluster to standalone
johnsonaj Nov 27, 2024
04dbbba
aws_rds_cluster: add test
johnsonaj Nov 27, 2024
b344538
Merge branch 'main' into f-rds_cluster_promotion
johnsonaj Nov 27, 2024
6b6d98d
chore: linter
johnsonaj Nov 27, 2024
dab506f
add CHANGELOG entry
johnsonaj Nov 27, 2024
d55fa55
chore: linter
johnsonaj Nov 27, 2024
9a9c063
aws_rds_cluster: update documentation for new functionality
johnsonaj Dec 2, 2024
8d863ba
Merge branch 'main' into f-rds_cluster_promotion
johnsonaj Dec 2, 2024
7ebbd8c
chore: linter
johnsonaj Dec 2, 2024
2e84486
aws_rds_cluster: add space to documentation
johnsonaj Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/service/rds/cluster_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1319,16 +1319,16 @@ func TestAccRDSCluster_ReplicationSourceIdentifier_promote(t *testing.T) {
{
Config: testAccClusterConfig_replicationSource_basic(rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckClusterExistsWithProvider(ctx, resourceName, &primaryCluster, acctest.RegionProviderFunc(acctest.Region(), &providers)),
testAccCheckClusterExistsWithProvider(ctx, resourceName2, &replicaCluster, acctest.RegionProviderFunc(acctest.AlternateRegion(), &providers)),
testAccCheckClusterExistsWithProvider(ctx, resourceName, &primaryCluster, acctest.RegionProviderFunc(ctx, acctest.Region(), &providers)),
testAccCheckClusterExistsWithProvider(ctx, resourceName2, &replicaCluster, acctest.RegionProviderFunc(ctx, acctest.AlternateRegion(), &providers)),
resource.TestCheckResourceAttrSet(resourceName2, "replication_source_identifier"),
),
},
{
Config: testAccClusterConfig_replicationSource_promote(rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckClusterExistsWithProvider(ctx, resourceName, &primaryCluster, acctest.RegionProviderFunc(acctest.Region(), &providers)),
testAccCheckClusterExistsWithProvider(ctx, resourceName2, &replicaCluster, acctest.RegionProviderFunc(acctest.AlternateRegion(), &providers)),
testAccCheckClusterExistsWithProvider(ctx, resourceName, &primaryCluster, acctest.RegionProviderFunc(ctx, acctest.Region(), &providers)),
testAccCheckClusterExistsWithProvider(ctx, resourceName2, &replicaCluster, acctest.RegionProviderFunc(ctx, acctest.AlternateRegion(), &providers)),
resource.TestCheckResourceAttr(resourceName2, "replication_source_identifier", ""),
),
},
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/rds_cluster.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ This resource supports the following arguments:
* `port` - (Optional) Port on which the DB accepts connections.
* `preferred_backup_window` - (Optional) Daily time range during which automated backups are created if automated backups are enabled using the BackupRetentionPeriod parameter.Time in UTC. Default: A 30-minute window selected at random from an 8-hour block of time per region, e.g. `04:00-09:00`.
* `preferred_maintenance_window` - (Optional) Weekly time range during which system maintenance can occur, in (UTC) e.g., `wed:04:00-wed:04:30`
* `replication_source_identifier` - (Optional) ARN of a source DB cluster or DB instance if this DB cluster is to be created as a Read Replica. If DB Cluster is part of a Global Cluster, use the [`lifecycle` configuration block `ignore_changes` argument](https://www.terraform.io/docs/configuration/meta-arguments/lifecycle.html#ignore_changes) to prevent Terraform from showing differences for this argument instead of configuring this value.
* `replication_source_identifier` - (Optional) ARN of a source DB cluster or DB instance if this DB cluster is to be created as a Read Replica. **Note:** Removing this attribute after creation will promote the read replica to a standalone cluster.If DB Cluster is part of a Global Cluster, use the [`lifecycle` configuration block `ignore_changes` argument](https://www.terraform.io/docs/configuration/meta-arguments/lifecycle.html#ignore_changes) to prevent Terraform from showing differences for this argument instead of configuring this value.
johnsonaj marked this conversation as resolved.
Show resolved Hide resolved
* `restore_to_point_in_time` - (Optional) Nested attribute for [point in time restore](https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/aurora-pitr.html). More details below.
* `scaling_configuration` - (Optional) Nested attribute with scaling properties. Only valid when `engine_mode` is set to `serverless`. More details below.
* `serverlessv2_scaling_configuration`- (Optional) Nested attribute with scaling properties for ServerlessV2. Only valid when `engine_mode` is set to `provisioned`. More details below.
Expand Down
Loading