appstream - image builder set MaxItems to 1 for subnet_ids in vpc_config

[anthonybouton]

…source #33027

Description

Was looking for a good first issue to get familiar with go.
Made the change mentioned by @justinretzolk in #33027 so that the MaxItems on the subnet_ids in the vpc_config is now handled in the plan phase.

The documentation edits the issue mentions already seem to be resolved in the docs.

I forked the repo on my organization account, will make sure, for future contributions, I fork to my personal space.

Relations

Closes #33027

Output from Acceptance Testing

% make testacc TESTS=TestAccAppStreamImageBuilder_ PKG=appstream
ake: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamImageBuilder_'  -timeout 360m
2024/12/30 00:09:16 Initializing Terraform AWS Provider...
=== RUN   TestAccAppStreamImageBuilder_basic
=== PAUSE TestAccAppStreamImageBuilder_basic
=== RUN   TestAccAppStreamImageBuilder_withIAMRole
=== PAUSE TestAccAppStreamImageBuilder_withIAMRole
=== RUN   TestAccAppStreamImageBuilder_disappears
=== PAUSE TestAccAppStreamImageBuilder_disappears
=== RUN   TestAccAppStreamImageBuilder_complete
=== PAUSE TestAccAppStreamImageBuilder_complete
=== RUN   TestAccAppStreamImageBuilder_tags
=== PAUSE TestAccAppStreamImageBuilder_tags
=== RUN   TestAccAppStreamImageBuilder_imageARN
=== PAUSE TestAccAppStreamImageBuilder_imageARN
=== CONT  TestAccAppStreamImageBuilder_basic
=== CONT  TestAccAppStreamImageBuilder_complete
=== CONT  TestAccAppStreamImageBuilder_imageARN
=== CONT  TestAccAppStreamImageBuilder_disappears
=== CONT  TestAccAppStreamImageBuilder_withIAMRole
=== CONT  TestAccAppStreamImageBuilder_tags
--- PASS: TestAccAppStreamImageBuilder_withIAMRole (574.51s)
--- PASS: TestAccAppStreamImageBuilder_basic (624.35s)
--- PASS: TestAccAppStreamImageBuilder_disappears (661.54s)
--- PASS: TestAccAppStreamImageBuilder_imageARN (698.80s)
--- PASS: TestAccAppStreamImageBuilder_tags (813.66s)
--- PASS: TestAccAppStreamImageBuilder_complete (1243.77s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  1243.867s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Hey @anthonybouton 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)