r/aws_ecs_task_definition: Correctly detect volume differences

.changelog/40853.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_ecs_task_definition: Correctly detect differences in `volume.configure_at_launch` and `volume.docker_volume_configuration`
+```

internal/sdkv2/set.go

@@ -4,6 +4,8 @@
 package sdkv2
 
 import (
+	"maps"
+	"slices"
 	"strconv"
 	"strings"
 
@@ -43,3 +45,21 @@ func SimpleSchemaSetFunc(keys ...string) schema.SchemaSetFunc {
 		return create.StringHashcode(str.String())
 	}
 }
+
+// HashStringValueMap returns a non-negative hash value for a map[string]string.
+func HashStringValueMap(m map[string]string) int {
+	if len(m) == 0 {
+		return 0
+	}
+
+	var str strings.Builder
+
+	for _, k := range slices.Sorted(maps.Keys(m)) {
+		str.WriteString(k)
+		str.WriteRune('=')
+		str.WriteString(m[k])
+		str.WriteRune(',')
+	}
+
+	return create.StringHashcode(str.String())
+}

internal/sdkv2/set_test.go

@@ -30,7 +30,7 @@ func TestSimpleSchemaSetFuncNil(t *testing.T) {
 	f := SimpleSchemaSetFunc("key1", "key3", "key4")
 
 	if got, want := f(v), 0; got != want {
-		t.Errorf("SimpleSchemaSetFunc(%q) err %q, want %q", v, got, want)
+		t.Errorf("SimpleSchemaSetFunc(%q) got %q, want %q", v, got, want)
 	}
 }
 
@@ -64,3 +64,24 @@ func TestSimpleSchemaSetFunc(t *testing.T) {
 		t.Errorf("expected not equal")
 	}
 }
+
+func TestHashStringValueMapNil(t *testing.T) {
+	t.Parallel()
+
+	if got, want := HashStringValueMap(nil), 0; got != want {
+		t.Errorf("HashStringValueMap(nil) got %d, want %d", got, want)
+	}
+}
+
+func TestHashStringValueMap(t *testing.T) {
+	t.Parallel()
+
+	m := map[string]string{
+		"Key1": "Value1",
+		"Key2": "Value2",
+	}
+
+	if got := HashStringValueMap(m); got < 0 {
+		t.Errorf("HashStringValueMap(%v) got %d", m, got)
+	}
+}