r/aws_route53_record: Correct fqdn for wildcard records

.changelog/40868.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_route53_record: Correct `fdqn` value if `name` is a wildcard domain name (the leftmost label is `*`). This fixes a regression introduced in [v5.83.0](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#5830-january--9-2025)
+```

CHANGELOG.md

@@ -1,4 +1,4 @@
-## 5.84.0 (Unreleased)
+## 5.83.1 (Unreleased)
 ## 5.83.0 (January  9, 2025)
 
 NOTES:

internal/service/route53/clean_test.go

@@ -51,16 +51,18 @@ func TestNormalizeAliasDomainName(t *testing.T) {
 	t.Parallel()
 
 	cases := []struct {
-		input, output string
+		input  interface{}
+		output string
 	}{
 		{"www.example.com", "www.example.com"},
 		{"www.example.com.", "www.example.com"},
 		{"dualstack.name-123456789.region.elb.amazonaws.com", "dualstack.name-123456789.region.elb.amazonaws.com"},
-		{"dualstacktest.test", "dualstacktest.test"},
+		{aws.String("dualstacktest.test"), "dualstacktest.test"},
 		{"ipv6.name-123456789.region.elb.amazonaws.com", "ipv6.name-123456789.region.elb.amazonaws.com"},
 		{"NAME-123456789.region.elb.amazonaws.com", "name-123456789.region.elb.amazonaws.com"},
 		{"name-123456789.region.elb.amazonaws.com", "name-123456789.region.elb.amazonaws.com"},
 		{"\\052.example.com", "\\052.example.com"},
+		{42, ""},
 	}
 
 	for _, tc := range cases {

internal/service/route53/record.go

@@ -442,6 +442,12 @@ func resourceRecordRead(ctx context.Context, d *schema.ResourceData, meta interf
 			return sdkdiag.AppendErrorf(diags, "setting failover_routing_policy: %s", err)
 		}
 	}
+	// findResourceRecordSetByFourPartKey returns the FQDN in API-normalized form.
+	// For backwards compatibility, restore any '*' as the leftmost label in the domain name.
+	// \052 is the octal representation of '*'.
+	if v := aws.ToString(fqdn); strings.HasPrefix(v, `\052.`) {
+		fqdn = aws.String(`*.` + strings.TrimPrefix(v, `\052.`))
+	}
 	d.Set("fqdn", fqdn)
 	if geoLocation := record.GeoLocation; geoLocation != nil {
 		tfList := []interface{}{map[string]interface{}{

internal/service/route53/record_test.go

@@ -14,7 +14,11 @@ import (
 	"github.com/hashicorp/aws-sdk-go-base/v2/endpoints"
 	sdkacctest "github.com/hashicorp/terraform-plugin-testing/helper/acctest"
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+	"github.com/hashicorp/terraform-plugin-testing/knownvalue"
+	"github.com/hashicorp/terraform-plugin-testing/plancheck"
+	"github.com/hashicorp/terraform-plugin-testing/statecheck"
 	"github.com/hashicorp/terraform-plugin-testing/terraform"
+	"github.com/hashicorp/terraform-plugin-testing/tfjsonpath"
 	"github.com/hashicorp/terraform-provider-aws/internal/acctest"
 	"github.com/hashicorp/terraform-provider-aws/internal/conns"
 	tfroute53 "github.com/hashicorp/terraform-provider-aws/internal/service/route53"
@@ -375,6 +379,15 @@ func TestAccRoute53Record_wildcard(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckRecordExists(ctx, resourceName, &record1),
 				),
+				ConfigPlanChecks: resource.ConfigPlanChecks{
+					PreApply: []plancheck.PlanCheck{
+						plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionCreate),
+					},
+				},
+				ConfigStateChecks: []statecheck.StateCheck{
+					statecheck.ExpectKnownValue(resourceName, tfjsonpath.New("fqdn"), knownvalue.StringExact("*.domain.test")),
+					statecheck.ExpectKnownValue(resourceName, tfjsonpath.New(names.AttrName), knownvalue.StringExact("*.domain.test")),
+				},
 			},
 			{
 				ResourceName:            resourceName,
@@ -389,6 +402,15 @@ func TestAccRoute53Record_wildcard(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckRecordExists(ctx, resourceName, &record2),
 				),
+				ConfigPlanChecks: resource.ConfigPlanChecks{
+					PreApply: []plancheck.PlanCheck{
+						plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionUpdate),
+					},
+				},
+				ConfigStateChecks: []statecheck.StateCheck{
+					statecheck.ExpectKnownValue(resourceName, tfjsonpath.New("fqdn"), knownvalue.StringExact("*.domain.test")),
+					statecheck.ExpectKnownValue(resourceName, tfjsonpath.New(names.AttrName), knownvalue.StringExact("*.domain.test")),
+				},
 			},
 		},
 	})