Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_codebuild_project: Properly handle setting cache type NO_CACHE #4134

Merged
merged 2 commits into from
Apr 11, 2018
Merged

resource/aws_codebuild_project: Properly handle setting cache type NO_CACHE #4134

merged 2 commits into from
Apr 11, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 9, 2018

Removes the initial workaround from #2860 to keep backwards compatibility with Computed: true on the cache attribute.

Closes #4113

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeBuildProject'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCodeBuildProject -timeout 120m
=== RUN   TestAccAWSCodeBuildProject_basic
--- PASS: TestAccAWSCodeBuildProject_basic (22.21s)
=== RUN   TestAccAWSCodeBuildProject_vpc
--- PASS: TestAccAWSCodeBuildProject_vpc (54.93s)
=== RUN   TestAccAWSCodeBuildProject_cache
--- PASS: TestAccAWSCodeBuildProject_cache (61.97s)
=== RUN   TestAccAWSCodeBuildProject_sourceAuth
--- PASS: TestAccAWSCodeBuildProject_sourceAuth (21.89s)
=== RUN   TestAccAWSCodeBuildProject_default_build_timeout
--- PASS: TestAccAWSCodeBuildProject_default_build_timeout (29.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	190.521s

@bflad bflad added bug Addresses a defect in current functionality. service/codebuild Issues and PRs that pertain to the codebuild service. labels Apr 9, 2018
@bflad bflad added this to the v1.14.1 milestone Apr 9, 2018
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Apr 9, 2018
This was referenced Apr 9, 2018
Closed
Merged
@bflad bflad requested a review from a team April 10, 2018 16:30
katbyte
katbyte approved these changes Apr 11, 2018
View reviewed changes
Copy link
Contributor

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

website/docs/r/codebuild_project.html.markdown Outdated
* `type` - (Required) The type of storage that will be used for the AWS CodeBuild project cache. The only valid value is `S3`.
* `location` - (Required) The location where the AWS CodeBuild project stores cached resources. This value must be a valid S3 bucket name/prefix.
* `type` - (Optional) The type of storage that will be used for the AWS CodeBuild project cache. Valid values: `NO_CACHE` and `S3`. Defaults to `NO_CACHE`.
* `location` - (Required when cache type is not `NO_CACHE`) The location where the AWS CodeBuild project stores cached resources. For type `S3` the value must be a valid S3 bucket name/prefix.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be slightly clearer to state 'Required when cache type is S3'. On my first read through my eyes jumped over the not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, updated to: Required when cache type is S3 👍

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Apr 11, 2018
@bflad bflad merged commit b811b46 into master Apr 11, 2018
@bflad bflad deleted the b-aws_codebuild_project-NO_CACHE branch April 11, 2018 16:40
bflad added a commit that referenced this pull request Apr 11, 2018
@bflad
Update CHANGELOG for #4134
edf8bab
@bflad
Copy link
Contributor Author

bflad commented Apr 11, 2018

This has been released in version 1.14.1 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/codebuild Issues and PRs that pertain to the codebuild service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.14.1
Development

Successfully merging this pull request may close these issues.

aws_codebuild_project: cache config does not stick when cache type set to "NO_CACHE"
2 participants
@bflad @katbyte