Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add badge_enabled and badge_url attributes to aws_codebuild_project. #4470

Closed
wants to merge 4 commits into from

Conversation

joestump
Copy link
Contributor

@joestump joestump commented May 7, 2018

Changes proposed in this pull request:

Adds a badge_enabled boolean option to aws_codebuild_project to support the badgeEnabled attribute that the AWS API now exposes.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeBuildProject_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSCodeBuildProject_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCodeBuildProject_basic
--- PASS: TestAccAWSCodeBuildProject_basic (47.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	47.706s

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label May 7, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. labels May 8, 2018
@bflad
Copy link
Contributor

bflad commented May 24, 2018

Hey @joestump 👋 -- thanks for submitting this! It looks like there was a previous PR (#3504) that also includes an acceptance test that I just reviewed. Since this PR doesn't include the previous commits we will pull in the previous PR and close this one as a duplicate.

Good news though is that I'll be getting to the other CodeBuild PRs, including your webhook one today. 👍

@bflad bflad closed this May 24, 2018
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants