-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] r/aws_route53_resolver_rule: Add resource #6571
Conversation
Add temporary '// nolint' comments.
97f06a3
to
1a11cd8
Compare
1a11cd8
to
ec6f45e
Compare
It looks like this PR has been open for a month and a half... we're really, really anxious to have this working. Any update? |
Hi @jantman - @ewbankkit is trying to figure out how best to tackle the Route53 Resolver Endpoint resource in #6574. Unfortunately that's a prerequisite to writing acceptance tests and being able to get this merged. I'm keeping an eye on progress 👍 |
Ok, thanks so much for the update!!! |
@gazoakley #6563 has (finally) been merged. Are you able to complete this one? |
@gazoakley I took the liberty of cherry picking your commit and completing the |
@gazoakley thanks for the work on getting this started. I'm going to close this PR and help push forward #7799. Please feel free to add any comments or feedback to the new PR. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Closes #6550
Output from acceptance testing: