Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] r/aws_route53_resolver_rule: Add resource #6571

Closed
wants to merge 3 commits into from

Conversation

gazoakley
Copy link
Contributor

Closes #6550

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones'

...

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service. labels Nov 24, 2018
@gazoakley gazoakley force-pushed the f-route53-resolver-rule branch 2 times, most recently from 97f06a3 to 1a11cd8 Compare November 26, 2018 02:47
@jantman
Copy link

jantman commented Jan 8, 2019

It looks like this PR has been open for a month and a half... we're really, really anxious to have this working. Any update?

@gazoakley
Copy link
Contributor Author

Hi @jantman - @ewbankkit is trying to figure out how best to tackle the Route53 Resolver Endpoint resource in #6574. Unfortunately that's a prerequisite to writing acceptance tests and being able to get this merged. I'm keeping an eye on progress 👍

@jantman
Copy link

jantman commented Jan 8, 2019

Ok, thanks so much for the update!!!

@ewbankkit
Copy link
Contributor

@gazoakley #6563 has (finally) been merged. Are you able to complete this one?

@ewbankkit
Copy link
Contributor

ewbankkit commented Mar 3, 2019

@gazoakley I took the liberty of cherry picking your commit and completing the aws_route53_resolver_rule and aws_route53_resolver_rule_association resources in #7799 as we have an urgent need for these resources.
The only attribute changes I made were to add owner_id and share_status as computed attributes to aws_route53_resolver_rule.
Thanks for the great work in getting this started.

@nywilken
Copy link
Contributor

nywilken commented Mar 4, 2019

@gazoakley thanks for the work on getting this started. I'm going to close this PR and help push forward #7799. Please feel free to add any comments or feedback to the new PR.

@nywilken nywilken closed this Mar 4, 2019
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
@gazoakley gazoakley deleted the f-route53-resolver-rule branch April 7, 2020 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53 Issues and PRs that pertain to the route53 service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Route53 Resolver Rule
4 participants