Update aws_dynamodb_table.server_side_encryption documentation noting DEFAULT encryption type #7499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DEFAULT encryption type.
ghost
added
size/XS
|
Replaces #5666. |
2 tasks
bflad
reviewed
Feb 11, 2019
There was a problem hiding this comment.
Hey @ewbankkit -- this is great information to update. Thanks for spending the time to look into it. To reduce some confusion, maybe we could:
- Update the
server_side_encryptionargument to state that AWS DynamoDB tables are automatically encrypted at rest with an AWS owned CMK and the configuration block controls options beyond that - Update the
enabledargument (right above this note) to include the bits being added in this note and maybe link out to https://docs.aws.amazon.com/kms/latest/developerguide/concepts.html to help clarify the difference between AWS owned and managed CMKs
What do you think?
bflad
added
the
waiting-response
|
@bflad I made the suggested changes which hopefully clarify the default value of AWS DynamoDB table server-side encryption. |
ghost
removed
the
waiting-response
bflad
approved these changes
Feb 13, 2019
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7498.
No applicable acceptance tests.