resource/aws_instance: update user data on change

[Dudesons]

Fixes #23

[Dudesons]

Hi,

Can I have some indications if I have to update or create a new test (with vpc or I can reuse one from an other test) to test this pr.
There is something I have to do more ?

@bflad

[bflad]

@Dudesons an additional acceptance test should be added and existing acceptance testing should be performed if possible. Please let us know if we can clarify anything in the CONTRIBUTING documentation

[et304383]

This PR is nearly 4 years in the making. What has to happen to move this along? Terraform needs to catch up to CloudFormation here.

[Dudesons]

@bflad Thank you for information I'll take a moment in the end of the week or next week to run and add the test

@et304383

[rogerhu]

Rebased and opened a separate PR with an acceptance test -- can someone review?

#16011

[nsvijay04b1]

Hi
When can we expect this? thanks!

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[anGie44]

Hi @Dudesons , thank you for submitting this PR and apologies we didn't get to it sooner. The associated issue #23 is now in our queue, however, and in an effort to get these changes merged in a timely manner I'm going to review #18043 which is based off the code changes here with the addition of some needed tests.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.