r/aws_globalaccelerator_endpoint_group: Add aws_globalaccelerator_endpoint_group resource #8328

john-delivuk · 2019-04-16T11:47:14Z

Rebase of PR #7005

Partly addresses #6739

Changes proposed in this pull request:

New Resource: aws_globalaccelerator_endpoint_group

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones'

...

…` resource

…or-listener

…point_group resource

…vider-aws into f-globalaccelerator-endpoint-group

john-delivuk · 2019-04-16T12:34:04Z

I'll look at these build failure shortly. Sorry about that.

…vider-aws into f-globalaccelerator-endpoint-group

john-delivuk · 2019-04-16T18:10:07Z

@bflad This is all ready to go. Let me know if I can do anything

john-delivuk · 2019-05-13T16:04:45Z

Anyway to get senpai to notice this?

bflad

Hi @john-delivuk 👋 Thanks for rebasing the original pull request. See the below for some initial feedback items. Please reach out if you have any questions or do not have time to implement them.

aws/provider.go

bflad · 2019-05-15T11:59:17Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+			State: schema.ImportStatePassthrough,
+		},
+
+		Timeouts: &schema.ResourceTimeout{


These customizable timeouts seem extraneous as the timeout is not based on a scalable dimension (such as data size). I would suggest removing this schema declaration and replace d.Timeout(schema.TimeoutXXX) usage with the time duration. If operations take longer than the hardcoded defaults, we should increase them for everyone. 😄

bflad · 2019-05-15T12:01:43Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+			},
+			"endpoint_group_region": {
+				Type:     schema.TypeString,
+				Required: true,


This attribute seems like it should default to the provider region rather than requiring configuration. 👍

Suggested change

Required: true,

Optional: true,

Computed: true,

In the code below:

region := meta.(*AWSClient).region // ... EndpointGroupRegion: aws.String(region), // ... if v, ok := d.GetOk("endpoint_group_region"); ok { opts.EndpointGroupRegion = aws.String(v.(string)) }

bflad · 2019-05-15T12:06:32Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+			"health_check_interval_seconds": {
+				Type:     schema.TypeInt,
+				Optional: true,
+				Computed: true,


This attribute appears to have a default (which should be used for drift detection) and validation information in the Global Accelerator API Reference:

Suggested change

Computed: true,

Default: 30,

ValidateFunc: validation.IntBetween(10, 30),

bflad · 2019-05-15T12:07:05Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+			"health_check_path": {
+				Type:     schema.TypeString,
+				Optional: true,
+				Computed: true,


This attribute appears to have a default in the Global Accelerator API Reference, which should be used to perform drift detection:

Suggested change

Computed: true,

Default: "/",

bflad · 2019-05-15T12:15:19Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+				Computed: true,
+			},
+			"endpoint_configurations": {
+				Type:     schema.TypeList,


Does the API guarantee ordering of this attribute in its responses? If not, this should be switched to schema.TypeSet

bflad · 2019-05-15T12:18:25Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+		return err
+	}
+
+	// Creating an endpoint group triggers the accelerator to change status to InPending


This logic should reuse the available function (albeit slightly poor naming): resourceAwsGlobalAcceleratorAcceleratorWaitForState

err = resourceAwsGlobalAcceleratorAcceleratorWaitForState(conn, acceleratorArn) if err != nil { return err }

Removing this duplicate logic on merge.

bflad · 2019-05-15T12:20:03Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+		return err
+	}
+
+	// Creating an endpoint group triggers the accelerator to change status to InPending


This logic should reuse the available function (albeit slightly poor naming): resourceAwsGlobalAcceleratorAcceleratorWaitForState

err = resourceAwsGlobalAcceleratorAcceleratorWaitForState(conn, acceleratorArn) if err != nil { return err }

Removing this duplicate logic on merge.

bflad · 2019-05-15T12:20:29Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+		return err
+	}
+
+	// Deleting an endpoint group triggers the accelerator to change status to InPending


This logic should reuse the available function (albeit slightly poor naming): resourceAwsGlobalAcceleratorAcceleratorWaitForState

err = resourceAwsGlobalAcceleratorAcceleratorWaitForState(conn, acceleratorArn) if err != nil { return err }

Removing this duplicate logic on merge.

bflad · 2019-05-15T12:23:25Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+	d.Set("health_check_protocol", endpointGroup.HealthCheckProtocol)
+	d.Set("threshold_count", endpointGroup.ThresholdCount)
+	d.Set("traffic_dial_percentage", endpointGroup.TrafficDialPercentage)
+	d.Set("endpoint_configurations", resourceAwsGlobalAcceleratorEndpointGroupFlattenEndpointDescriptions(endpointGroup.EndpointDescriptions))


When using d.Set() with aggregate types (TypeList, TypeSet, TypeMap), we should perform error checking to prevent issues where the code is not properly able to set the Terraform state. e.g.

Suggested change

d.Set("endpoint_configurations", resourceAwsGlobalAcceleratorEndpointGroupFlattenEndpointDescriptions(endpointGroup.EndpointDescriptions))

if err := d.Set("endpoint_configurations", resourceAwsGlobalAcceleratorEndpointGroupFlattenEndpointDescriptions(endpointGroup.EndpointDescriptions)); err != nil {

return fmt.Errorf("error setting endpoint_configurations: %s", err)

}

john-delivuk · 2019-05-22T03:37:10Z

Hey @bflad Didn't expect this much feedback, just give me about 2 weeks and I'll put this together to the best of my ability.

john-delivuk · 2019-05-22T15:05:17Z

I lied, I got most of this taken care of last night. I'll try to update the PR today.

john-delivuk · 2019-05-31T17:30:05Z

Sorry for the delay, please review the docs throughly, I went through this a few times, but I'm sure I overlooked something. Thanks @bflad

MBali-GitHub · 2019-06-14T00:15:45Z

Do we yet know by when this be released?

bflad

Hi @john-delivuk 👋 Thanks for the updates. I left some final review items below, but this is otherwise in pretty good shape. Please reach out if you have any questions or do not have time to implement the feedback.

bflad · 2019-06-19T01:32:48Z

website/aws.erb

@@ -1486,6 +1486,11 @@
                            <a href="/docs/providers/aws/r/globalaccelerator_accelerator.html">aws_globalaccelerator_accelerator</a>
                        </li>
                    </ul>
+                    <ul class="nav">
+                        <li>
+                            <a href="/docs/providers/aws/r/globalaccelerator_endpoint_group.html">globalaccelerator_endpoint_group</a>


Suggested change

<a href="/docs/providers/aws/r/globalaccelerator_endpoint_group.html">globalaccelerator_endpoint_group</a>

<a href="/docs/providers/aws/r/globalaccelerator_endpoint_group.html">aws_globalaccelerator_endpoint_group</a>

bflad · 2019-06-19T01:41:47Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+
+	acceleratorArn, err := resourceAwsGlobalAcceleratorListenerParseAcceleratorArn(d.Id())
+	if err != nil {
+		err = resourceAwsGlobalAcceleratorAcceleratorWaitForState(conn, acceleratorArn)


Sorry if my original comment was unclear. This waiter should exist outside this error conditional and replace the duplicated StateChangeConf logic below. e.g.

acceleratorArn, err := resourceAwsGlobalAcceleratorListenerParseAcceleratorArn(d.Id()) if err != nil { return err } err = resourceAwsGlobalAcceleratorAcceleratorWaitForState(conn, acceleratorArn) if err != nil { return err } return resourceAwsGlobalAcceleratorEndpointGroupRead(d, meta)

bflad · 2019-06-19T01:42:56Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+	for i, configuration := range configurations {
+		m := make(map[string]interface{})
+
+		m["endpoint_id"] = *configuration.EndpointId


To prevent potential panics, this should use the AWS Go SDK provided conversion function:

Suggested change

m["endpoint_id"] = *configuration.EndpointId

m["endpoint_id"] = aws.StringValue(configuration.EndpointId)

bflad · 2019-06-19T01:43:33Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+		m := make(map[string]interface{})
+
+		m["endpoint_id"] = *configuration.EndpointId
+		m["weight"] = *configuration.Weight


To prevent potential panics, this should use the AWS Go SDK provided conversion function:

Suggested change

m["weight"] = *configuration.Weight

m["weight"] = aws.Int64Value(configuration.Weight)

bflad · 2019-06-19T01:44:21Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+
+	acceleratorArn, err := resourceAwsGlobalAcceleratorListenerParseAcceleratorArn(d.Id())
+	if err != nil {
+		err = resourceAwsGlobalAcceleratorAcceleratorWaitForState(conn, acceleratorArn)


Same here -- sorry if my original comment was unclear. This waiter should exist outside this error conditional and replace the duplicated StateChangeConf logic below. e.g.

acceleratorArn, err := resourceAwsGlobalAcceleratorListenerParseAcceleratorArn(d.Id()) if err != nil { return err } err = resourceAwsGlobalAcceleratorAcceleratorWaitForState(conn, acceleratorArn) if err != nil { return err } return resourceAwsGlobalAcceleratorEndpointGroupRead(d, meta)

bflad · 2019-06-19T01:48:35Z

website/docs/r/globalaccelerator_endpoint_group.html.markdown

+
+```hcl
+resource "globalaccelerator_endpoint_group" "example" {
+  listener_arn            = "arn:aws:globalaccelerator::123456789012:accelerator/1234abcd-abcd-1234-abcd-1234abcdefgh/listener/0123vxyz"


Examples should prefer to use resource references where possible to illustrate real world usage, e.g.

Suggested change

listener_arn = "arn:aws:globalaccelerator::123456789012:accelerator/1234abcd-abcd-1234-abcd-1234abcdefgh/listener/0123vxyz"

listener_arn = "${aws_globalaccelerator_listener.example.id}"

bflad · 2019-06-19T01:49:45Z

website/docs/r/globalaccelerator_endpoint_group.html.markdown

+resource "globalaccelerator_endpoint_group" "example" {
+  listener_arn            = "arn:aws:globalaccelerator::123456789012:accelerator/1234abcd-abcd-1234-abcd-1234abcdefgh/listener/0123vxyz"
+  endpoint_configuration {
+    EndpointId   = "arn:aws:elasticloadbalancing:us-east-1:123456789012:loadbalancer/app/my-load-balancer/50dc6c495c0c9188"


The argument name here is endpoint_id. Also, same here where examples should prefer to use resource references where possible to illustrate real world usage, e.g.

Suggested change

EndpointId = "arn:aws:elasticloadbalancing:us-east-1:123456789012:loadbalancer/app/my-load-balancer/50dc6c495c0c9188"

endpoint_id = "${aws_lb.example.arn}"

bflad · 2019-06-19T01:51:43Z

website/docs/r/globalaccelerator_endpoint_group.html.markdown

+  listener_arn            = "arn:aws:globalaccelerator::123456789012:accelerator/1234abcd-abcd-1234-abcd-1234abcdefgh/listener/0123vxyz"
+  endpoint_configuration {
+    EndpointId   = "arn:aws:elasticloadbalancing:us-east-1:123456789012:loadbalancer/app/my-load-balancer/50dc6c495c0c9188"
+    Weight = "100"


The argument name here is lowercase weight and is an integer which does not need to be wrapped in quotes:

Suggested change

Weight = "100"

weight = 100

bflad · 2019-06-19T01:52:05Z

website/docs/r/globalaccelerator_endpoint_group.html.markdown

+
+**endpoint_configuration** supports the following attributes:
+
+* `EndpointId` - (Optional) An ID for the endpoint. If the endpoint is a Network Load Balancer or Application Load Balancer, this is the Amazon Resource Name (ARN) of the resource. If the endpoint is an Elastic IP address, this is the Elastic IP address allocation ID.


Suggested change

* `EndpointId` - (Optional) An ID for the endpoint. If the endpoint is a Network Load Balancer or Application Load Balancer, this is the Amazon Resource Name (ARN) of the resource. If the endpoint is an Elastic IP address, this is the Elastic IP address allocation ID.

* `endpoint_id` - (Optional) An ID for the endpoint. If the endpoint is a Network Load Balancer or Application Load Balancer, this is the Amazon Resource Name (ARN) of the resource. If the endpoint is an Elastic IP address, this is the Elastic IP address allocation ID.

bflad · 2019-06-19T01:52:14Z

website/docs/r/globalaccelerator_endpoint_group.html.markdown

+**endpoint_configuration** supports the following attributes:
+
+* `EndpointId` - (Optional) An ID for the endpoint. If the endpoint is a Network Load Balancer or Application Load Balancer, this is the Amazon Resource Name (ARN) of the resource. If the endpoint is an Elastic IP address, this is the Elastic IP address allocation ID.
+* `Weight` - (Optional) The weight associated with the endpoint. When you add weights to endpoints, you configure AWS Global Accelerator to route traffic based on proportions that you specify. 


Suggested change

* `Weight` - (Optional) The weight associated with the endpoint. When you add weights to endpoints, you configure AWS Global Accelerator to route traffic based on proportions that you specify.

* `weight` - (Optional) The weight associated with the endpoint. When you add weights to endpoints, you configure AWS Global Accelerator to route traffic based on proportions that you specify.

john-delivuk · 2019-06-19T18:08:33Z

@bflad Thanks for the feedback, everything is updated according to your notes. Let me know if there is anything else required.

…vider-aws into f-globalaccelerator-endpoint-group

john-delivuk · 2019-06-19T21:32:10Z

For my own knowledge, should I mark resolved, or should I let the reviewer :)

bflad

Thanks for the updates, @john-delivuk. Performed some final adjustments in a followup commit to get the acceptance testing fully passing (noted below) and this is good to go. Great work. 🚀

Output from acceptance testing:

--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (258.79s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_update (316.32s)

bflad · 2019-06-19T21:25:08Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+			"traffic_dial_percentage": {
+				Type:         schema.TypeFloat,
+				Optional:     true,
+				Default:      100,


When running the acceptance testing, this Default and ValidateFunc were causing the below failure:

--- FAIL: TestAccAwsGlobalAcceleratorEndpointGroup_basic (1.79s) testing.go:568: Step 0 error: config is invalid: expected type of traffic_dial_percentage to be int --- FAIL: TestAccAwsGlobalAcceleratorEndpointGroup_update (1.79s) testing.go:568: Step 0 error: config is invalid: expected type of traffic_dial_percentage to be int

The fix here is to switch them to Default: 100.0 and ValidateFunc: validation.FloatBetween(0.0, 100.0) to match Type: schema.TypeFloat 👍

bflad · 2019-06-19T21:26:57Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+	}
+
+	if v, ok := d.GetOk("endpoint_configuration"); ok {
+		opts.EndpointConfigurations = resourceAwsGlobalAcceleratorEndpointGroupExpandEndpointConfigurations(v.([]interface{}))


When running the acceptance testing, the type assertion here caused a panic:

panic: interface conversion: interface {} is *schema.Set, not []interface {} goroutine 1169 [running]: github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsGlobalAcceleratorEndpointGroupCreate(0xc0013ed8f0, 0x5238f40, 0xc00008fc00, 0x2, 0xaa129c0) /Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_globalaccelerator_endpoint_group.go:136 +0xbb1

The fix here is to use v.(*schema.Set).List() for converting the Type: schema.TypeSet attribute into a []interface() for the function call. Same update needed in the Update function.

bflad · 2019-06-19T21:28:33Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+		return err
+	}
+
+	// Creating an endpoint group triggers the accelerator to change status to InPending


Removing this duplicate logic on merge.

bflad · 2019-06-19T21:28:56Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+		return err
+	}
+
+	// Creating an endpoint group triggers the accelerator to change status to InPending


Removing this duplicate logic on merge.

bflad · 2019-06-19T21:29:11Z

aws/resource_aws_globalaccelerator_endpoint_group.go

+		return err
+	}
+
+	// Deleting an endpoint group triggers the accelerator to change status to InPending


Removing this duplicate logic on merge.

bflad · 2019-06-19T21:29:54Z

website/docs/r/globalaccelerator_endpoint_group.html.markdown

@@ -0,0 +1,55 @@
+---
+layout: "aws"
+page_title: "AWS: globalaaws_globalaccelerator_endpoint_groupccelerator_endpoint_group"


Fixing on merge: page_title: "AWS: aws_globalaccelerator_endpoint_group"

bflad · 2019-06-19T21:30:09Z

website/docs/r/globalaccelerator_endpoint_group.html.markdown

+
+Provides a Global Accelerator endpoint group.
+
+## Attributes Reference


Fixing on merge.

bflad · 2019-06-19T21:38:53Z

aws/resource_aws_globalaccelerator_endpoint_group_test.go

+					resource.TestCheckResourceAttr(resourceName, "threshold_count", "3"),
+					resource.TestCheckResourceAttr(resourceName, "traffic_dial_percentage", "100"),
+					resource.TestCheckResourceAttr(resourceName, "endpoint_configuration.#", "1"),
+					resource.TestCheckResourceAttr(resourceName, "endpoint_configuration.0.weight", "10"),


Since the endpoint_configuration attribute is Type: schema.TypeSet, the .0. index in the state needs to instead be calculated from the Set function for the attribute (if Set is undefined for a TypeSet attribute, it falls back to an automatically calculated value from the underlying types):

--- FAIL: TestAccAwsGlobalAcceleratorEndpointGroup_basic (252.96s) testing.go:568: Step 0 error: Check failed: Check 9/9 error: aws_globalaccelerator_endpoint_group.example: Attribute 'endpoint_configuration.0.weight' not found

Since the endpoint_id value is dynamic, the index hash value in turn is dynamic as well and this type of state checking in the acceptance testing is problematic.

If the resource supports import, the ImportStateVerify: true testing will automatically ensures all state values match after Terraform refresh into an empty state (e.g. the values returned by just Read function itself), so this problematic TestCheckResourceAttr() can typically be removed fairly safely in that scenario.

bflad · 2019-06-20T00:59:10Z

aws/resource_aws_globalaccelerator_endpoint_group_test.go

+				Config: testAccGlobalAcceleratorEndpointGroup_update(rInt),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckGlobalAcceleratorEndpointGroupExists(resourceName),
+					resource.TestCheckResourceAttr(resourceName, "health_check_interval_seconds", "10"),


It seems like the API needs at least one endpoint configuration for health check updates to actually occur (tried injecting a one minute delay between the update and read to no avail):

--- FAIL: TestAccAwsGlobalAcceleratorEndpointGroup_update (289.47s) testing.go:568: Step 1 error: Check failed: Check 2/8 error: aws_globalaccelerator_endpoint_group.example: Attribute 'health_check_interval_seconds' expected "10", got "30"

Opted to keep an endpoint configuration in the second configuration for now so the testing properly passes.

final feedback Reference: hashicorp#8328 Output from acceptance testing: ``` --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (258.79s) --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_update (316.32s) ```

jorgebay · 2019-06-20T08:02:50Z

Thanks @john-delivuk and @bflad for landing support for Global Accelerator!! 🎉

bflad · 2019-06-20T22:08:49Z

This has been released in version 2.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

ghost · 2019-11-03T15:22:07Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

gazoakley and others added 6 commits December 29, 2018 16:45

r/aws_globalaccelerator_listener: Add `aws_globalaccelerator_listener…

b1b19d3

…` resource

Merge branch 'f-globalaccelerator-accelerator' into f-globalaccelerat…

8cfafdd

…or-listener

r/aws_globalaccelerator_accelerator: Fix flatten port range, tests

d6d6a1e

r/aws_globalaccelerator_accelerator: Fix tests

f9691f6

r/aws_globalaccelerator_endpoint_group: Add aws_globalaccelerator_end…

3a6fb63

…point_group resource

Merge branch 'master' of github.com:terraform-providers/terraform-pro…

c82d688

…vider-aws into f-globalaccelerator-endpoint-group

ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 16, 2019

john-delivuk mentioned this pull request Apr 16, 2019

[WIP] r/aws_globalaccelerator_endpoint_group: Add aws_globalaccelerator_endpoint_group resource #7005

Closed

Merge branch 'master' of github.com:terraform-providers/terraform-pro…

b367746

…vider-aws into f-globalaccelerator-endpoint-group

john-delivuk force-pushed the f-globalaccelerator-endpoint-group branch from 476ba71 to b367746 Compare April 16, 2019 17:47

john-delivuk changed the title ~~F globalaccelerator endpoint group~~ r/aws_globalaccelerator_endpoint_group: Add aws_globalaccelerator_endpoint_group resource Apr 22, 2019

bflad added new-resource Introduces a new resource. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. labels May 15, 2019

bflad reviewed May 15, 2019

View reviewed changes

bflad added the waiting-response Maintainers are waiting on response from community or contributor. label May 23, 2019

Adding docs, updating defaults and timeouts

0fb9ebc

ghost added the documentation Introduces or discusses updates to documentation. label May 31, 2019

ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label May 31, 2019

Missed a few 's' on endpoint_configuration rename

6f54a62

bflad self-assigned this Jun 19, 2019

bflad suggested changes Jun 19, 2019

View reviewed changes

bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jun 19, 2019

Fixing errors, updating name of args, removing quotes

49291e5

ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jun 19, 2019

john-delivuk added 2 commits June 19, 2019 14:50

Merge branch 'master' of github.com:terraform-providers/terraform-pro…

cd2fd7f

…vider-aws into f-globalaccelerator-endpoint-group

Removing prematue returns

0dab14f

bflad self-requested a review June 19, 2019 19:32

bflad added this to the v2.16.0 milestone Jun 19, 2019

bflad reviewed Jun 20, 2019

View reviewed changes

bflad merged commit 0dab14f into hashicorp:master Jun 20, 2019

bflad added a commit that referenced this pull request Jun 20, 2019

Update CHANGELOG for #8328

5e132d2

ghost locked and limited conversation to collaborators Nov 3, 2019

	Computed: true,
	Default: 30,
	ValidateFunc: validation.IntBetween(10, 30),

-	d.Set("endpoint_configurations", resourceAwsGlobalAcceleratorEndpointGroupFlattenEndpointDescriptions(endpointGroup.EndpointDescriptions))
+	if err := d.Set("endpoint_configurations", resourceAwsGlobalAcceleratorEndpointGroupFlattenEndpointDescriptions(endpointGroup.EndpointDescriptions)); err != nil {
+		return fmt.Errorf("error setting endpoint_configurations: %s", err)
+	}

	<a href="/docs/providers/aws/r/globalaccelerator_endpoint_group.html">globalaccelerator_endpoint_group</a>
	<a href="/docs/providers/aws/r/globalaccelerator_endpoint_group.html">aws_globalaccelerator_endpoint_group</a>

	m["endpoint_id"] = *configuration.EndpointId
	m["endpoint_id"] = aws.StringValue(configuration.EndpointId)

	m["weight"] = *configuration.Weight
	m["weight"] = aws.Int64Value(configuration.Weight)

	listener_arn = "arn:aws:globalaccelerator::123456789012:accelerator/1234abcd-abcd-1234-abcd-1234abcdefgh/listener/0123vxyz"
	listener_arn = "${aws_globalaccelerator_listener.example.id}"

	EndpointId = "arn:aws:elasticloadbalancing:us-east-1:123456789012:loadbalancer/app/my-load-balancer/50dc6c495c0c9188"
	endpoint_id = "${aws_lb.example.arn}"


		endpoint_configuration supports the following attributes:

		* `EndpointId` - (Optional) An ID for the endpoint. If the endpoint is a Network Load Balancer or Application Load Balancer, this is the Amazon Resource Name (ARN) of the resource. If the endpoint is an Elastic IP address, this is the Elastic IP address allocation ID.

	* `EndpointId` - (Optional) An ID for the endpoint. If the endpoint is a Network Load Balancer or Application Load Balancer, this is the Amazon Resource Name (ARN) of the resource. If the endpoint is an Elastic IP address, this is the Elastic IP address allocation ID.
	* `endpoint_id` - (Optional) An ID for the endpoint. If the endpoint is a Network Load Balancer or Application Load Balancer, this is the Amazon Resource Name (ARN) of the resource. If the endpoint is an Elastic IP address, this is the Elastic IP address allocation ID.

	* `Weight` - (Optional) The weight associated with the endpoint. When you add weights to endpoints, you configure AWS Global Accelerator to route traffic based on proportions that you specify.
	* `weight` - (Optional) The weight associated with the endpoint. When you add weights to endpoints, you configure AWS Global Accelerator to route traffic based on proportions that you specify.


		Provides a Global Accelerator endpoint group.

		## Attributes Reference

r/aws_globalaccelerator_endpoint_group: Add aws_globalaccelerator_endpoint_group resource #8328

r/aws_globalaccelerator_endpoint_group: Add aws_globalaccelerator_endpoint_group resource #8328

Conversation

john-delivuk commented Apr 16, 2019 • edited Loading

john-delivuk commented Apr 16, 2019

john-delivuk commented Apr 16, 2019

john-delivuk commented May 13, 2019

bflad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

john-delivuk commented May 22, 2019

john-delivuk commented May 22, 2019

john-delivuk commented May 31, 2019

MBali-GitHub commented Jun 14, 2019

bflad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

john-delivuk commented Jun 19, 2019

john-delivuk commented Jun 19, 2019

bflad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jorgebay commented Jun 20, 2019

bflad commented Jun 20, 2019

ghost commented Nov 3, 2019

john-delivuk commented Apr 16, 2019 •

edited

Loading