Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spot fleet request panic #9836

Merged
merged 4 commits into from
Sep 16, 2019
Merged

Fix spot fleet request panic #9836

merged 4 commits into from
Sep 16, 2019

Conversation

aeschright
Copy link
Contributor

@aeschright aeschright commented Aug 21, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Handle errors on the spot fleet request resource that happen when an instance store-backed AMI is specified.

Note: the included test is skipped because it fails for an unrelated reason.

Closes #9814
Relates #9775

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSpotFleetRequest_WithInstanceStoreAmi'
--- FAIL: TestAccAWSSpotFleetRequest_WithInstanceStoreAmi (108.34s)
    testing.go:629: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: errors during refresh: Instance store backed AMIs do not provide a root device name - Use an EBS AMI
        
        State: <nil>
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	109.126s

@aeschright aeschright requested a review from a team August 21, 2019 00:12
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 21, 2019
@aeschright aeschright changed the title [WIP] Fix spot fleet request panic Fix spot fleet request panic Sep 16, 2019
@aeschright
Copy link
Contributor Author

Confirmed the fix with local testing:

Error: Instance store backed AMIs do not provide a root device name - Use an EBS AMI

  on main.tf line 75, in resource "aws_spot_fleet_request" "foo":
  75: resource "aws_spot_fleet_request" "foo" {

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight changed requested but otherwise good to go. Approving in advance.

aws/resource_aws_spot_fleet_request.go Outdated Show resolved Hide resolved
@aeschright aeschright added this to the v2.29.0 milestone Sep 16, 2019
@aeschright aeschright merged commit 38fc3b9 into master Sep 16, 2019
@aeschright aeschright deleted the b-spot-fleet-panic branch September 16, 2019 23:29
@ghost
Copy link

ghost commented Sep 20, 2019

This has been released in version 2.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform0.12 with aws2.24 crashes during plan
2 participants