Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final retries for instances #9879

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Final retries for instances #9879

merged 1 commit into from
Sep 12, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_instance: Final retries after timeouts creating and updating instance and getting instance password data

Output from acceptance testing:

NOTE: The 2 failures are not new


$ --- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (12.58s)
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (57.56s)
--- PASS: TestAccAWSInstance_GP2WithIopsValue (67.59s)
--- PASS: TestAccAWSInstance_rootInstanceStore (71.79s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (77.16s)
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (62.91s)
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgId (78.67s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (82.38s)
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (75.33s)
--- PASS: TestAccAWSInstance_userDataBase64 (124.28s)
--- PASS: TestAccAWSInstance_sourceDestCheck (133.16s)
--- PASS: TestAccAWSInstance_tags (114.48s)
--- PASS: TestAccAWSInstance_privateIP (71.09s)
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (70.44s)
--- PASS: TestAccAWSInstance_keyPairCheck (71.44s)
--- PASS: TestAccAWSInstance_volumeTags (97.42s)
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (71.16s)
--- PASS: TestAccAWSInstance_volumeTagsComputed (103.38s)
--- PASS: TestAccAWSInstance_placementGroup (177.22s)
--- PASS: TestAccAWSInstance_GP2IopsDevice (184.37s)
--- PASS: TestAccAWSInstance_blockDevices (184.56s)
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgName (193.73s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (50.99s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (71.09s)
--- PASS: TestAccAWSInstance_basic (232.22s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (61.14s)
--- PASS: TestAccAWSInstance_disableApiTermination (234.85s)
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (118.13s)
--- PASS: TestAccAWSInstance_multipleRegions (242.33s)
--- PASS: TestAccAWSInstance_addSecondaryInterface (105.23s)
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (70.80s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (70.77s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (77.15s)
--- PASS: TestAccAWSInstance_primaryNetworkInterface (173.69s)
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (334.10s)
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (90.81s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (182.56s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (260.54s)
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (157.84s)
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (206.48s)
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (182.76s)
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (183.06s)
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (224.05s)
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (167.63s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (96.48s)
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (79.05s)
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (79.32s)
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (216.95s)
--- PASS: TestAccAWSInstance_changeInstanceType (326.46s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (303.67s)
--- PASS: TestAccAWSInstance_disappears (229.18s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (313.76s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (290.35s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (311.03s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (430.33s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (471.78s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (964.12s)
--- FAIL: TestAccAWSInstance_vpc (13.45s)
--- FAIL: TestAccAWSInstance_importBasic (5109.10s)

make testacc TESTARGS="-run=TestAccAWSInstance_instanceProfileChange"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSInstance_instanceProfileChange -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSInstance_instanceProfileChange
=== PAUSE TestAccAWSInstance_instanceProfileChange
=== CONT  TestAccAWSInstance_instanceProfileChange
--- PASS: TestAccAWSInstance_instanceProfileChange (181.45s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       182.440s

make testacc TESTARGS="-run=TestAccAWSInstance_NetworkInstanceSecurityGroups"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSInstance_NetworkInstanceSecurityGroups -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSInstance_NetworkInstanceSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceSecurityGroups
=== CONT  TestAccAWSInstance_NetworkInstanceSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (135.37s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       136.253s

make testacc TESTARGS="-run=TestAccAWSInstance_ipv6_supportAddressCount"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSInstance_ipv6_supportAddressCount -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSInstance_ipv6_supportAddressCount
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCount
=== RUN   TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== CONT  TestAccAWSInstance_ipv6_supportAddressCount
=== CONT  TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (140.29s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (140.95s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       141.881s

@ryndaniels ryndaniels requested a review from a team August 26, 2019 11:46
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Aug 26, 2019
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Aug 26, 2019
aeschright
aeschright approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ make testacc TESTARGS="-run=TestAccAWSInstance_"

--- PASS: TestAccAWSInstance_disappears (287.56s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (90.66s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (109.79s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (131.99s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (152.52s)
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (165.51s)
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (191.00s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (210.08s)
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (242.05s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (283.94s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (323.98s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (329.36s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (479.78s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (528.29s)
--- PASS: TestAccAWSInstance_keyPairCheck (77.96s)
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (130.04s)
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (132.57s)
--- PASS: TestAccAWSInstance_multipleRegions (354.04s)
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (22.94s)
--- PASS: TestAccAWSInstance_importInEc2Classic (110.69s)
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (149.01s)
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (169.68s)
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (59.71s)
--- PASS: TestAccAWSInstance_rootInstanceStore (73.27s)
--- PASS: TestAccAWSInstance_volumeTags (105.07s)
--- PASS: TestAccAWSInstance_volumeTagsComputed (134.42s)
--- PASS: TestAccAWSInstance_tags (316.37s)
--- PASS: TestAccAWSInstance_instanceProfileChange (216.10s)
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (186.01s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (170.49s)
--- PASS: TestAccAWSInstance_disableApiTermination (122.05s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (62.57s)
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (69.69s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (82.86s)
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (83.01s)
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (184.22s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (194.41s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (194.59s)
--- PASS: TestAccAWSInstance_blockDevices (85.82s)
--- PASS: TestAccAWSInstance_GP2IopsDevice (65.46s)
--- PASS: TestAccAWSInstance_GP2WithIopsValue (72.36s)
--- PASS: TestAccAWSInstance_privateIP (193.42s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (198.49s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (198.74s)
--- PASS: TestAccAWSInstance_userDataBase64 (117.85s)
--- PASS: TestAccAWSInstance_placementGroup (72.12s)
--- PASS: TestAccAWSInstance_vpc (302.45s)
--- PASS: TestAccAWSInstance_sourceDestCheck (139.50s)        
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (81.74s)
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (82.95s)
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (87.68s)
--- PASS: TestAccAWSInstance_basic (152.84s)
--- PASS: TestAccAWSInstance_changeInstanceType (222.70s)
--- PASS: TestAccAWSInstance_addSecondaryInterface (123.64s)
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (239.98s)
--- PASS: TestAccAWSInstance_primaryNetworkInterface (194.30s)
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (194.40s)
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (229.76s)
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (315.37s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (86.32s)
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgId (69.78s)
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgName (186.10s)        
--- PASS: TestAccAWSInstance_importBasic (204.63s)

@ryndaniels ryndaniels added this to the v2.28.0 milestone Sep 12, 2019
@ryndaniels ryndaniels merged commit d031093 into master Sep 12, 2019
@ryndaniels ryndaniels deleted the rfd-retry-instance branch September 12, 2019 09:15
@ghost
Copy link

ghost commented Sep 12, 2019

This has been released in version 2.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschright aeschright aeschright approved these changes

Assignees

@aeschright aeschright

Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryndaniels @aeschright