Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iotevents service #9916

Merged
merged 3 commits into from
Aug 30, 2019
Merged

Add iotevents service #9916

merged 3 commits into from
Aug 30, 2019

Conversation

oleksiyVeretiuk
Copy link
Contributor

@oleksiyVeretiuk oleksiyVeretiuk commented Aug 29, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Add IoTEvents service

Changes proposed in this pull request:

  • Add IoTEvents service

Reference #9917

@oleksiyVeretiuk oleksiyVeretiuk requested a review from a team August 29, 2019 14:06
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 29, 2019
@oleksiyVeretiuk oleksiyVeretiuk changed the title Add iotevents service Add iotevents service with IoTEvents Input resource Aug 29, 2019
@bflad
Copy link
Contributor

bflad commented Aug 30, 2019 •
edited
Loading

Hi @oleksiyVeretiuk 👋 Thank you for submitting this. Can you please separate the addition of the new AWS Go SDK service from the new resource by creating two pull requests, following the Contributing Guide? In particular, this is also currently missing this line item:

In aws/provider.go Add a new service entry to endpointServiceNames. This service name should match the AWS Go SDK or AWS CLI service name.

See also these other recent service additions: #9794, #9874, #9875 👍

@oleksiyVeretiuk
Copy link
Contributor Author

Hi @oleksiyVeretiuk wave Thank you for submitting this. Can you please separate the addition of the new AWS Go SDK service from the new resource by creating two pull requests, following the Contributing Guide? In particular, this is also currently missing this line item:

In aws/provider.go Add a new service entry to endpointServiceNames. This service name should match the AWS Go SDK or AWS CLI service name.

See also these other recent service additions: #9794, #9874, #9875 +1

Understood. I will make this PR responsible only for IoTEvents Service, because of branch name and make another for IoTEvents Input resource. Thank you for reply.

@oleksiyVeretiuk oleksiyVeretiuk mentioned this pull request Aug 30, 2019
Open
@oleksiyVeretiuk oleksiyVeretiuk changed the title Add iotevents service with IoTEvents Input resource Add iotevents service Aug 30, 2019
@bflad bflad added this to the v2.27.0 milestone Aug 30, 2019
bflad
bflad approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @oleksiyVeretiuk 🚀

@bflad bflad merged commit 998ffa2 into hashicorp:master Aug 30, 2019
@ghost
Copy link

ghost commented Sep 5, 2019

This has been released in version 2.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksiyVeretiuk @bflad