Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input validation to automation resources and change account_name parameter #4776

Closed
draggeta opened this issue Oct 31, 2019 · 1 comment · Fixed by #4777
Closed

Add input validation to automation resources and change account_name parameter #4776

draggeta opened this issue Oct 31, 2019 · 1 comment · Fixed by #4777

Comments

@draggeta
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Not all automation resources have validation for the automation account, runbook and schedule names. These already exist in the helpers and this PR just adds them to the fields.

Furthermore, the azurerm_automation_credential resource still uses the account_name parameter. This PR

New or Affected Resource(s)

  • azurerm_automation_account
  • azurerm_automation_credential
  • azurerm_automation_dsc_configuration
  • azurerm_automation_module
  • azurerm_automation_runbook
  • azurerm_automation_schedule

Potential Terraform Configuration

For the azurerm_automation_credential, one could add automation_account_name as an alternative to account_name. The code can be copied from what is in azurerm_automation_schedule.

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.
resource "azurerm_automation_credential" "test" {
  name                    = "devicePassword"
  resource_group_name     = "${azurerm_resource_group.test.name}"
  automation_account_name = "${azurerm_automation_account.test.name}"
  username                = "test_user"
  password                = "test_pwd"
}

References

  • #0000
@draggeta draggeta changed the title Add input validation to automation resources and change account_name Add input validation to automation resources and change account_name parameter Oct 31, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant