Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 'public_ips' in the network_configuration block of azurerm_batch_pool #5920

Closed
materia-org opened this issue Feb 26, 2020 · 2 comments · Fixed by #5967
Closed

Comments

@materia-org
Copy link

materia-org commented Feb 26, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The current implementation of azurerm_batch_pool contains a network_configuration block that only supports 'subnet_id' and 'endpoint_configuration'. The actual Batch Pool resource in Microsoft Azure (see https://docs.microsoft.com/en-us/azure/templates/microsoft.batch/2019-08-01/batchaccounts/pools) also includes a 'PublicIPs' field. Without this field, it is not always possible to set up the batch pool correctly (e.g. the nodes in the pool cannot be started or time out).

New or Affected Resource(s)

  • azurerm_batch_pool

Potential Terraform Configuration

resource "azurerm_batch_pool" "example" {
   ...
    network_configuration {
       subnet_id                     = data.azurerm_subnet.example.id
       public_ips                    =  [data.azurerm_public_ip.example1.id, data.azurerm_public_ip.example2.id]
       endpoint_configuration {
           name                                = "SSH"
           backend_port                   = 22
           protocol                            = "TCP"
           frontend_port_range        = "4000-4100"
	   network_security_group_rules {
                access                   = "Deny"
                priority                 = 170
                source_address_prefix    = "Internet"
       }
    }	
}
	

References

katbyte added a commit that referenced this issue Mar 4, 2020
fix #5920

the original sdk version 2018-12-01 does not support fields public_ips, so I upgraded the version to 2019-08-01
@katbyte katbyte added this to the v2.1.0 milestone Mar 5, 2020
@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants