New Resource/Data Source: azurerm_databox_edge_order and azurerm_databox_edge_device
#10392
Conversation
WodansSon
changed the title
azurerm_databox_edge_order and azurerm_databox_edge_deviceazurerm_databox_edge_order and azurerm_databox_edge_device
There was a problem hiding this comment.
Thanks @WodansSon - just have some schema questionss otherwise is looking good
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils" | ||
| ) | ||
|
|
||
| func dataSourceDataboxEdgeDevice() *schema.Resource { |
There was a problem hiding this comment.
I don't think there is much a reason to include a datasource here?
| Computed: true, | ||
| Elem: &schema.Schema{ | ||
| Type: schema.TypeString, | ||
| }, |
There was a problem hiding this comment.
I'm not sure it is required here as this is a read only field that is returned from the service? 🤷♂️
| Computed: true, | ||
| }, | ||
|
|
||
| "device_local_capacity": { |
There was a problem hiding this comment.
is local necessary?
| "device_local_capacity": { | |
| "device_capacity": { |
| Computed: true, | ||
| }, | ||
|
|
||
| "device_type": { |
There was a problem hiding this comment.
given there are so man device properties should we put these into a block?
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils" | ||
| ) | ||
|
|
||
| func dataSourceDataboxEdgeOrder() *schema.Resource { |
There was a problem hiding this comment.
I don't think there is much a reason to include a datasource here?
| }, | ||
| }, | ||
|
|
||
| "update_date_time": { |
There was a problem hiding this comment.
not sure this property makes sense in terraform?
There was a problem hiding this comment.
I think this is a valuable field since it lets the end user know when was the last time the RP made a change to their order. WDYT?
There was a problem hiding this comment.
thats fair, we generally don't include properties like this in tf thou
| MaxItems: 1, | ||
| Elem: &schema.Resource{ | ||
| Schema: map[string]*schema.Schema{ | ||
| "address_line1": { |
There was a problem hiding this comment.
should we just makt this an list which each element being a line?
| "address_line1": { | |
| "address": { |
| }, | ||
| }, | ||
|
|
||
| "delivery_tracking_info": { |
There was a problem hiding this comment.
| "delivery_tracking_info": { | |
| "shipment": { |
There was a problem hiding this comment.
How about we compromise, shipping_info? 🙂
There was a problem hiding this comment.
how about shipment_info or shipment_tracking - shipping seems to be the wrong verb for this?
| Computed: true, | ||
| Elem: &schema.Resource{ | ||
| Schema: map[string]*schema.Schema{ | ||
| "additional_order_details": { |
There was a problem hiding this comment.
| "additional_order_details": { | |
| "additional_details": { |
| }, | ||
| }, | ||
|
|
||
| "return_tracking_info": { |
There was a problem hiding this comment.
should this be
| "return_tracking_info": { | |
| "return_shipment": { |
There was a problem hiding this comment.
I went with return_tracking hopes that's ok... it made more sense to me... if you really want me to update this to use shipment I can do that too... 🙂
|
Creating new branch based off master. |
|
new PR #10730 |
|
This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.49.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
No description provided.