Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap d.Set("location") with a nil check call and normalize d.Get("location") #1074

Merged
merged 2 commits into from
Apr 5, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Apr 5, 2018

No description provided.

@katbyte katbyte requested review from tombuildsstuff and a team April 5, 2018 04:45
@katbyte katbyte force-pushed the b-getset_location_fix branch from 9b66706 to aa7865e Compare April 5, 2018 05:08
@katbyte katbyte added this to the 1.3.3 milestone Apr 5, 2018
@tombuildsstuff
Copy link
Contributor

Context for this PR: Azure appears to return the state of a resource at the time that it was last modified, rather than as right now. This means for older resources the location field can be omited (which will cause a crash) - this PR fixes this.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this! 👍

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants