Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disks: scaffolding the service package & adding the embedded sdk #14673

Merged
merged 4 commits into from
Dec 21, 2021

Conversation

tombuildsstuff
Copy link
Contributor

Foundational work for splitting out Disk Pools into their own service package - since this has been incorrectly added to the storage package when it's unrelated (and so also needs renaming etc).

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tombuildsstuff tombuildsstuff merged commit 4a65c65 into main Dec 21, 2021
@tombuildsstuff tombuildsstuff deleted the f/disks-sdk branch December 21, 2021 06:41
katbyte pushed a commit that referenced this pull request Jan 5, 2022
This PR introduces a new resource azurerm_disk_pool which supersedes the existing azurerm_storage_disks_pool - this is because the existing resource is unrelated to the Storage package and is a collection of (Managed) Disks. Since there's a number of Disk related resources (and will be more with #14268) - this pulls the existing resource and this new resource out into it's own package.

There's a follow up here to move Managed Disks into this package too, but that's outside the scope of this PR.

Dependent on #14673 and #14672
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

This functionality has been released in v2.91.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants