Checking the HTTP Response isn't nil
. Fixes #200
#204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Read function for most resources we check the http response code before raising an error (to check if it's a 404 not found) - however issue #200 has highlighted an issue where it's possible for the response to be
nil
if the connection doesn't return a response / is dropped - which currently crashes.This PR does two things:
Response
object isn't nil before checking the status code is a 404I'm running the entire test suite now - but the Virtual Network tests have run through successfully:
Fixes #200